summaryrefslogtreecommitdiff
path: root/board/voxel
Commit message (Collapse)AuthorAgeFilesLines
* ish: Trim down the release branchstabilize-wristpin-14469.59.B-ishstabilize-voshyr-14637.B-ishstabilize-quickfix-14695.187.B-ishstabilize-quickfix-14695.124.B-ishstabilize-quickfix-14526.91.B-ishstabilize-14695.85.B-ishstabilize-14695.107.B-ishstabilize-14682.B-ishstabilize-14633.B-ishstabilize-14616.B-ishstabilize-14589.B-ishstabilize-14588.98.B-ishstabilize-14588.14.B-ishstabilize-14588.123.B-ishstabilize-14536.B-ishstabilize-14532.B-ishstabilize-14528.B-ishstabilize-14526.89.B-ishstabilize-14526.84.B-ishstabilize-14526.73.B-ishstabilize-14526.67.B-ishstabilize-14526.57.B-ishstabilize-14498.B-ishstabilize-14496.B-ishstabilize-14477.B-ishstabilize-14469.9.B-ishstabilize-14469.8.B-ishstabilize-14469.58.B-ishstabilize-14469.41.B-ishstabilize-14442.B-ishstabilize-14438.B-ishstabilize-14411.B-ishstabilize-14396.B-ishstabilize-14395.B-ishstabilize-14388.62.B-ishstabilize-14388.61.B-ishstabilize-14388.52.B-ishstabilize-14385.B-ishstabilize-14345.B-ishstabilize-14336.B-ishstabilize-14333.B-ishrelease-R99-14469.B-ishrelease-R98-14388.B-ishrelease-R102-14695.B-ishrelease-R101-14588.B-ishrelease-R100-14526.B-ishfirmware-cherry-14454.B-ishfirmware-brya-14505.B-ishfirmware-brya-14505.71.B-ishfactory-kukui-14374.B-ishfactory-guybrush-14600.B-ishfactory-cherry-14455.B-ishfactory-brya-14517.B-ishJack Rosenthal2021-11-059-1551/+0
| | | | | | | | | | | | | | | | | | | | | | In the interest of making long-term branch maintenance incur as little technical debt on us as possible, we should not maintain any files on the branch we are not actually using. This has the added effect of making it extremely clear when merging CLs from the main branch when changes have the possibility to affect us. The follow-on CL adds a convenience script to actually pull updates from the main branch and generate a CL for the update. BUG=b:204206272 BRANCH=ish TEST=make BOARD=arcada_ish && make BOARD=drallion_ish Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I17e4694c38219b5a0823e0a3e55a28d1348f4b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3262038 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* BB Retimer: Add new HPD callback to boardsDiana Z2021-09-161-0/+2
| | | | | | | | | | | | | | | Now that the BB retimer has its own HPD interface, add this interface to every board using the bb_usb_retimer driver. BRANCH=None BUG=b:195773400 TEST=on voxel, pass tast typec.Mode*.manual Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ia70d139431739e8f2c0577359cb3aaa7fb906d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3163930 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* zephyr: Add BB retimer emulatorTomasz Michalec2021-09-021-2/+1
| | | | | | | | | | | | | | | | | | Add BB retimer emulator on i2c bus. Emulator properties can be defined using device tree or runtime emulator API. Emulator checks if RO registers and reserved bits are accessed correctly. API allows to set custom read/write i2c messagess handlers to emulate complex behaviour. BUG=b:184856919 BRANCH=none TEST=none Signed-off-by: Tomasz Michalec <tm@semihalf.com> Change-Id: I4b641a90e6fb55e89aaee388c0ac04ab7bf367ba Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3110085 Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Yuval Peress <peress@chromium.org>
* lid_angle: Create a common callback for lid angle changesWai-Hong Tam2021-08-051-19/+0
| | | | | | | | | | | | | | | | | | | | | | Each board defines its own callback lid_angle_peripheral_enable(). The implementation is very similar. Create a common implementation and reduce the duplicated code. This CL removes the board callbacks which are identifical to the common callback. If it is slightly different, keep it and add the __override tag. The check of TEST_BUILD is unnecessary as the board callback is not linked in the test build. BRANCH=None BUG=b:194922043 TEST=Build all the images. Change-Id: I73d381730f35b80eff69399cdfc5fb54f839aee0 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3069175 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* keyboard_scan: Add consts needed for factory test to headerRob Barnes2021-07-281-3/+0
| | | | | | | | | | | | | | | | | Add keyboard_factory_scan_pins and keyboard_factory_scan_pins_used to keyboard_scan header so they do not need to be declared as extern by individual boards. These constants need to be defined if CONFIG_KEYBOARD_FACTORY_TEST is enabled. BUG=None TEST=Build BRANCH=None Change-Id: I1a100f626b3cea251ca72703d17b2d27db0f8f28 Signed-off-by: Rob Barnes <robbarnes@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3053101 Commit-Queue: Diana Z <dzigterman@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
* keyboard: Use __override for keyboard_scan_configDaisuke Nojiri2021-07-231-1/+1
| | | | | | | | | | | | | | | | | Currently keyboard_scan_config is defined by each board using CONFIG_KEYBOARD_BOARD_CONFIG. This patch makes it defined as __override hence removes CONFIG_KEYBOARD_BOARD_CONFIG. BUG=None BRANCH=None TEST=buildall Change-Id: I53a356741ba4d00e829ca59b74ee6dc704188728 Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3044403 Tested-by: Gwendal Grignou <gwendal@chromium.org> Commit-Queue: Gwendal Grignou <gwendal@chromium.org> Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
* voxel: support factory keyboard test.David Huang2021-06-212-0/+21
| | | | | | | | | | | | | | | | | | | | | connector-to-GPIO map: {-1,-1}, { 0, 5}, { 1, 1}, { 1, 0}, { 0, 6}, { 0, 7}, {-1,-1}, {-1,-1}, { 1, 4}, { 1, 3}, {-1,-1}, { 1, 6}, { 1, 7}, { 3, 1}, { 2, 0}, { 1, 5}, { 2, 6}, { 2, 7}, { 2, 1}, { 2, 4}, { 2, 5}, { 1, 2}, { 2, 3}, { 2, 2}, { 3, 0}, {-1,-1}, { 0, 4}, {-1 -1}, { 8, 2}, {-1,-1}, {-1,-1}, BUG=b:174411155 BRANCH=volteer TEST=`ectool kbfactorytest` PASS. Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com> Change-Id: Id9466e525efba3799bf2d0183de6a0cddc669385 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2944524 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* volta: support 45w adapterBen Chen2021-05-171-1/+1
| | | | | | | | | | | | | change pd mw power to 45w supply. BUG=b:186383390 BRANCH=volteer TEST=make BOARD PASS, and thermal/power test PASS Change-Id: I84aaf0a94e10941daadc0dda12337d557bf43c13 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2891683 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* LED On/Off: Make battery LED optionalDiana Z2021-04-221-4/+5
| | | | | | | | | | | | | | | Currently, all boards using the LED On/Off module have battery LEDs. However, if we'd like to expand support to Chromeboxes then the battery LED must become optional. BRANCH=None BUG=b:185508707 TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ieae098829ebe6c8b103f23d5abdbf70e7bcbdf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2832692 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* voema: support kx022/bma255 with ssfc bits mapBen Chen2021-04-191-4/+4
| | | | | | | | | | | | | | | | config kx022 or bma255 motion sensor by ssfc bits map, and rename volteer ssfc bits map. BUG=b:178447173 BRANCH=main TEST=Using ectool 'motionsense' verified lid angle now goes from 0 to 360 and swtiches to tablet mode after crossing 200 threshold on re-work kx022/bma255 DUT. Change-Id: I2901b0cc980e50324eb4f20d073c5f3a4c3f80e3 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2825719 Reviewed-by: Keith Short <keithshort@chromium.org>
* voxel: add New battery COSMX AP20CBLstabilize-coil-13902.B-mainBen Chen2021-04-082-0/+30
| | | | | | | | | | | | | | new battery config : AP20CBL BUG=b:184225420 BRANCH=volteer TEST=Check found battery info in console and cutoff work. Change-Id: I9496eb025a20a9da029be060dc7df50cd6b04306 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2799332 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* voxel: add refresh key maskBen Chen2021-04-011-0/+1
| | | | | | | | | | | | | | | | Add refresh key mask to enable recovery mode. BUG=b:183353285 BRANCH=volteer TEST=Press and hold Esc + Refresh , then press Power. check recovery mode is workable. Change-Id: I21d465f42f4e3be428ed3c4f4011a76ce6870008 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2780457 Reviewed-by: Zhuohao Lee <zhuohao@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* volteer, voxel: Add VIF override filesAbe Levkoy2021-03-241-0/+158
| | | | | | | | | | | | | | | | | Override VIF contents that genvif generates by default to create accurate VIFs for volteer and voxel. BUG=b:172276715 TEST=genvif -b volteer -o /tmp -v build/volteer/vif_override.xml TEST=genvif -b voxel -o /tmp -v build/voxel/vif_override.xml TEST=Similar compliance results on Voxel to handwritten VIF BRANCH=firmware-volteer-13672.B-main Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I4c72744a5d8b08aa46ef966299f0661a50499e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2785505 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* Reland "voxel, drobit: Create EC mode entry builds"Abe Levkoy2021-03-171-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a reland of 5cc244149f9d2f2502860bb7fc718676001c3d26 Original change's description: > voxel, drobit: Create EC mode entry builds > > Disable AP-driven mode entry to facilitate regression testing. Also > remove now-unused voxel_apmodeentry build. > > BUG=b:181144682 > TEST=make BOARD=voxel_ecmodeentry; make BOARD=drobit_ecmodeentry > TEST=Inspect .config files > BRANCH=firmware-volteer-13672.B-main > > Signed-off-by: Abe Levkoy <alevkoy@chromium.org> > Change-Id: I5e52a46013315db4415a3255c12cd0fcd39354bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2760804 > Reviewed-by: Keith Short <keithshort@chromium.org> > Commit-Queue: Keith Short <keithshort@chromium.org> Bug: b:181144682 Change-Id: Id8b1e0031f917ed38e9adfa1408c6be6392fcd98 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2770187 Tested-by: Abe Levkoy <alevkoy@chromium.org> Auto-Submit: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* Revert "voxel, drobit: Create EC mode entry builds"Abe Levkoy2021-03-171-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 5cc244149f9d2f2502860bb7fc718676001c3d26. Reason for revert: This breaks builds outside the EC that still rely on voxel_apmodeentry (that should also be deleted). Original change's description: > voxel, drobit: Create EC mode entry builds > > Disable AP-driven mode entry to facilitate regression testing. Also > remove now-unused voxel_apmodeentry build. > > BUG=b:181144682 > TEST=make BOARD=voxel_ecmodeentry; make BOARD=drobit_ecmodeentry > TEST=Inspect .config files > BRANCH=firmware-volteer-13672.B-main > > Signed-off-by: Abe Levkoy <alevkoy@chromium.org> > Change-Id: I5e52a46013315db4415a3255c12cd0fcd39354bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2760804 > Reviewed-by: Keith Short <keithshort@chromium.org> > Commit-Queue: Keith Short <keithshort@chromium.org> Bug: b:181144682 Change-Id: Ie07201658ef47a209b12b63583628a4ed19fe3de Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2764974 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Keith Short <keithshort@chromium.org>
* voxel, drobit: Create EC mode entry buildsAbe Levkoy2021-03-161-0/+3
| | | | | | | | | | | | | | | | Disable AP-driven mode entry to facilitate regression testing. Also remove now-unused voxel_apmodeentry build. BUG=b:181144682 TEST=make BOARD=voxel_ecmodeentry; make BOARD=drobit_ecmodeentry TEST=Inspect .config files BRANCH=firmware-volteer-13672.B-main Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I5e52a46013315db4415a3255c12cd0fcd39354bd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2760804 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* Voxel: Enable FRSEric Herrmann2021-03-102-5/+20
| | | | | | | | | | | | | | | | | | Set flag and configure GPIOs to enable Fast Role Swap on Voxel. Clear the GPIOs passed to the PPC driver for boards which don't support FRS due to older PPC versions. BUG=b:148144711 TEST=With an FRS device with power passed through, remove the power cord and check that the device doesn't re-enumerate. Test with 5V and 20V wall adapters BRANCH=None Signed-off-by: Eric Herrmann <eherrmann@chromium.org> Change-Id: Ib60478d4f840967b1f08d0e621b74350c8f0658c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2733593 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* voxel: Enable AP-driven alt mode entryAbe Levkoy2021-03-021-8/+2
| | | | | | | | | | | | | | Wait for the AP to direct the EC to enter USB PD alternate modes. BUG=b:150611251,b:181144682 TEST=make buildall; observe alt mode entry BRANCH=firmware-volteer-13672.B-main Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I832f69b6ed58d3502b9f6be054f295a95f94f62b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2727838 Tested-by: Prashant Malani <pmalani@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* board: Set Accelerometer range to 4gGwendal Grignou2021-02-131-1/+1
| | | | | | | | | | | | | | | | | For accelerometer presented to Android, set default range to 4g. Required by Android CDD - Section 7.3.1 - Paragraph C.1.4. mems_setup can correct it, but it is cleaner if the default setting is right. BUG=b:144004449 BRANCH=none TEST=compile Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Change-Id: I781eafc003823e2595d46d7170f717aaee08dc6d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2657956 Reviewed-by: Alexandru M Stan <amstan@chromium.org>
* retimer: PD port retimer firmware update supportli feng2021-02-051-6/+0
| | | | | | | | | | | | | | | | Added one field to struct usb_mux_driver, which returns true if retimer update is supported. Moved query function from usb_retimer_fw_update.c to usb_mux.c. BUG=b:162528867 BRANCH=none TEST=Tested on Voxel, together with related coreboot and kernel changes. EC returns correct port information to kernel. Signed-off-by: li feng <li1.feng@intel.com> Change-Id: I5cab34a14adbf0470cffe6a13234ad53b6f6a90c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2651866 Reviewed-by: Keith Short <keithshort@chromium.org>
* retimer: support retimer firmware updateli feng2021-02-051-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To support AP to update firmware during boot up, one byte EC RAM is allocated for AP <-> EC communication. AP queries PD port/requests EC to perform operations via EC_CMD_ACPI_WRITE; and fetches result from EC via EC_CMD_ACPI_READ. The flow is: 1. AP queries EC PD ports which port supports retimer firmware update. 2. AP queries current MUX. 3. a) If no device attached, AP requests EC to suspend PD task of the port. Then AP requests EC to set MUX to USB mode, Safe mode, TBT mode. After entering TBT mode, the OS can either enumerate the retimers or do firmware update on the enumerated retimers. Once done, AP requests EC to disconnect MUX and resume PD task. 3. b) If device attached, AP moves on as usual. Retimer firmware update is not performed. BUG=b:162528867 BRANCH=none TEST=Tested NDA case on Voxel board, together with coreboot and kernel changes. Coreboot changes are merged. Kernel patches list is: https://chromium-review.googlesource.com/c/chromiumos/ third_party/kernel/+/2670719 After power up, host scans retimers, in sysfs localhost ~ # ls /sys/bus/thunderbolt/devices/ 0-0 0-0:1.1 0-0:3.1 domain0 On PD port 1, manually update retimer firmware. Copy firmware to nvm_non_active1/nvmem, then authenticate it. Host starts flow to update firmware. After it's done, PD port 1 resumes. Hotplug DP dongle/TBT device, devices should function fully. TEST=Tested DA cases on Voxel board, together with coreboot and kernel changes. USB4/TBT devices function as usual. Signed-off-by: li feng <li1.feng@intel.com> Change-Id: Ie976e75f892d5caf48a948598a058a4f42e07eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2594492 Reviewed-by: Keith Short <keithshort@chromium.org>
* voxel: Add keyboard backlight support by FW_CONFIGBen Chen2021-02-032-2/+19
| | | | | | | | | | | | | | switch keyboard backlight enable/disable by fw_config BIT14 BUG=b:162632407 BRANCH=none TEST=Set FW_CONFIG to 0x4000 and make sure "ectool inventory" had keyboard backlight present. Change-Id: I766b5179340c155a98fb854bba66e93f820d1e6b Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2662935 Reviewed-by: Keith Short <keithshort@chromium.org>
* voxel: disable tablet mode by fw_configBen Chen2021-02-022-15/+24
| | | | | | | | | | | | | Disable/Enable tablet mode by fw_config BUG=b:178456852 BRANCH=cros/main TEST=`make buildall` PASS Change-Id: I829b2486f63430ef7bf59bf582b914d33dae71c0 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2649885 Reviewed-by: Keith Short <keithshort@chromium.org>
* voxel: Remove CONFIG_SYSTEM_UNLOCKEDBen Chen2021-02-021-2/+0
| | | | | | | | | | | | | | Progressed enough in development that we no longer need to force an unlocked state on the EC. BRANCH=None BUG=b:178569971 TEST=make -j buildall Change-Id: I6574acc424509dec027c18898d1fe060b770ae03 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2663095 Reviewed-by: Keith Short <keithshort@chromium.org>
* voxel: fix rotation matrixBen Chen2021-01-281-2/+2
| | | | | | | | | | | | | | | Fix rotation matrix of base motion sensor BUG=b:178338414 BRANCH=master TEST=Using ectool 'motionsense' verified lid angle now goes from 0 to 360 and swtiches to tablet mode after crossing 200 threshold. Change-Id: Ica60a90270bddbfad4117ecec422e72502284018 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2652109 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* voxel: Enable CONFIG_KEYBOARD_VIVALDIBen Chen2021-01-262-6/+43
| | | | | | | | | | | | | | This CL implements vivald function row config for voxel keyboard. BUG=b:177043612 BRANCH=main TEST=verify keycode is correct in `evtest` Change-Id: I02d59bf1ec9fac802f0b47f38bba1cd3915573b8 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2620732 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org>
* voxel: add new batteryand remove the unused batteryBen Chen2021-01-232-24/+25
| | | | | | | | | | | | | add new battery AP18C8K, and remove battery L17L3PB0 BUG=b:177969026 BRANCH=cros/main TEST=Make sure battery can cutoff by console "cutoff" or "ectool cutoff" Change-Id: I7fc44eb8cad3e2d804040210571562076b1ac601 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2639420 Reviewed-by: Keith Short <keithshort@chromium.org>
* config: Provide default VCONN Swap delayAbe Levkoy2021-01-221-1/+0
| | | | | | | | | | | | | | | | | Almost every relevant board copy-pastes 5000 us. Make that the default and get rid of the redundant definitions. This is the approximate result of this command: find . -type f -name *.h | xargs sed -i -E \ '/#define CONFIG_USBC_VCONN_SWAP_DELAY_US[[:space:]]+5000[[:space:]]/d' BUG=b:144165680 TEST=make buildall BRANCH=none Change-Id: Ife86f9752971abcd7ab5ad5a5e607eb2ccbde2ba Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2628132 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* config: Make VCONN Swap delay a documented optionAbe Levkoy2021-01-221-1/+1
| | | | | | | | | | | | | | | | | | | | | Replace PD_VCONN_SWAP_DELAY with CONFIG_USBC_VCONN_SWAP_DELAY_US. This is the approximate result of the following command, run from platform/ec: find . -type f -\( -name '*.c' -o -name '*.h' -\) | \ xargs sed -iE 's/PD_VCONN_SWAP_DELAY/CONFIG_USBC_VCONN_SWAP_DELAY/g' Fix some latent formatting errors in usb_pd_protocol.c, because they were preventing pre-upload hooks from passing. BUG=b:144165680 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: Icaf3b309c08fdcd162e960cf5dc88185016b5d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2628131 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
* voxel: update thermal tableBen Chen2021-01-211-5/+5
| | | | | | | | | | | | | | | | update thermal config BUG=b:167523658 BRANCH=none TEST=make buildall TEST=verify by thermal team Change-Id: Ic96a6bcc7ef12ab94d5bebcf643331a7634e3496 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2634891 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org> Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
* voxel: Create voxel_apmodentry board configAbe Levkoy2021-01-191-0/+8
| | | | | | | | | | | | | | Help partners debug AP-driven mode entry. BUG=b:177105656 TEST=make buildall; observe new build BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: I5c549237a38bcf0d9e10db3101c934cf6461c1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2638088 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* voxel: Add motion sensor config for kx022/icm-426xxBen Chen2021-01-093-4/+120
| | | | | | | | | | | | | | | | Add icm-426xx config for new second source base accel/gyro, and lid accel config for new second source. BUG=b:176039213, b:175843510 BRANCH=main TEST=Using ectool 'motionsense' verified lid angle now goes from 0 to 360 and swtiches to tablet mode after crossing 200 threshold on re-work kx022/icm-426xx DUT. Change-Id: I6815a46f01f8334f4f8c1b07deee16046566fbce Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2607207 Reviewed-by: Keith Short <keithshort@chromium.org>
* TCPMv2: Update source-out configsDiana Z2020-12-241-6/+0
| | | | | | | | | | | | | | | | | | | | Now that the DPM will be handling source-out decisions for TCPMv2, remove references to its old configuration options from TCPMv2 boards in order to avoid any confusion as to what code is running now. Also remove the charge manager notifications of sink attach/detach since the policy is being centralized into the DPM. Note that the previous configuration options only ever allocated one 3.0 A port, and so the default number of 3.0 A ports has been set to 1. BRANCH=None BUG=b:168862110,b:141690755 TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ie452e3da32b04226503539daa67b6b9f4a58aa58 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2597431 Reviewed-by: Keith Short <keithshort@chromium.org>
* Mux: Program retimer mux mode firstDivya Sasidharan2020-12-101-14/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | Configure BB retimer first and then TCSS mux for the following boards 1. Adlrvpp 2. Boldar 3. Copano 4. Drobit 5. Halvor 6. Lingcod 7. Malefor 8. Terrador 9. Tglrvpu/y 10.Todor 11.Trondo 12.Volteer 13.Voxel BUG=b:166300460 BRANCH=None TEST=Able to configure the BB retimer before the TCSS mux Change-Id: Ife3074e3f45f00d3263eb0c5c2bea713db67541b Signed-off-by: Divya Sasidharan <divya.s.sasidharan@intel.com> Signed-off-by: Ayushee Shah <ayushee.shah@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2506629 Reviewed-by: Keith Short <keithshort@chromium.org>
* voxel: update thermal tableBen Chen2020-12-091-36/+13
| | | | | | | | | | | | | | update thermal config BUG=b:167523658 BRANCH=none TEST=make buildall TEST=verify by thermal team Change-Id: I2a86e95d0abfe3eed25eefe95838b2c0d580729f Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2571142 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* voxel: disable CONFIG_KEYBOARD_VIVALDIBen Chen2020-12-071-0/+6
| | | | | | | | | | | | | | | | | | | Disable Vivaldi keyboard since Vivaldi currently does not allow for side volume buttons to be distinguished from keyboard volume F9/F10 keys. This is necessary so that Chrome can ignore F9/F10 in tablet mode, but side volume buttons still work. BUG=b:173147060 BRANCH=master TEST=make -j BOARD=voxel TEST=make buildall TEST=test on voxel, side-buttons work in clamshell/tablet mode and that F9/F10 only work in clamshell. Change-Id: I6bcc07ede9e88a82c44642493037eca81936f98f Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2573658 Reviewed-by: Keith Short <keithshort@chromium.org>
* voxel: Enabling sourcing of 4.5A on type-C portsKeith Short2020-11-121-0/+6
| | | | | | | | | | | | | | | To support USB4, source a total of 4.5A on the type-C ports. This ensures that if the first device requests 3A (15W), the chromebook continues to source 3A even after a second device is connected. BUG=none BRANCH=firmware-volteer-13521.B-master TEST=make buildall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I5e3e81defa3ef62cd0735481e6efbc0b41f4261e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2533518 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* usb: Remove references to usb23Caveh Jalali2020-11-062-13/+0
| | | | | | | | | | | | | | | | | The TCSS port mapping is not used by the EC and the higher layers no longer query the EC for this mapping. We can remove this feature and disable CONFIG_INTEL_VIRTUAL_MUX which was added to enable it. BRANCH=none BUG=b:153941950 TEST=buildall passes Change-Id: I2d7f51212f3e64d74827d7f82654eb93534b8db4 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2427632 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Commit-Queue: Keith Short <keithshort@chromium.org>
* COIL: Rename CONFIG_I2C_CONTROLLERDiana Z2020-11-051-1/+1
| | | | | | | | | | | | | Rename CONFIG_I2C_CONTROLLER and related comments. BRANCH=None BUG=None TEST=make -j buildall Signed-off-by: Diana Z <dzigterman@chromium.org> Change-Id: Ied6a1829bf54a5c9a32e6772982a4b8aa31aaf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2518659 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* voxel: add Lid operates in forced modeBen Chen2020-10-261-0/+2
| | | | | | | | | | | | | | | | add define Lid force mode mask BUG=b:162940877,b:171009897 BRANCH=none TEST=Using ectool 'motionsense' verified lid angle now goes from 0 to 360 and swtiches to tablet mode after crossing 200 threshold. Change-Id: I04679d770ab8bcdf84bfd5b2b742feacdd53a743 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2477402 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* voxel: Configure temperature sensorsAbe Levkoy2020-10-231-0/+3
| | | | | | | | | | | | | | Enable the ADC alternate function to reduce power usage. BUG=b:155882590 TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: If5ec0c0a85cc300b2ede3187415c297e2874d438 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2493413 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* volteer: move thermal setting to variantScott Chao2020-10-071-0/+52
| | | | | | | | | | | | | | | Since each variant may have different thermal sensor placement. Move thermal params and configs from baseboard to variant. BUG=b:170143672 BRANCH=none TEST=make -j BOARD=eldrid TEST=make buildall Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: Ie12f4cecad5f93c491e51a5fadfe856829f5b2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2449510 Reviewed-by: Keith Short <keithshort@chromium.org>
* volteer: Enable SW charge rampingKeith Short2020-10-011-0/+1
| | | | | | | | | | | | | | | | Enable CONFIG_CHARGE_RAMP_SW because hardware based charge ramping doesn't work on the ISL9241. BUG=b:169350714, b:168960587 BRANCH=none TEST=make buildall TEST=Connect 1.5A CDP device to Volteer and verify charge ramp from 0.5A to 1.5A over about 7 seconds. Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I81e8a3913bd776d0d3fda6d294fdeabbde5df62a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2438912 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* Revert "volteer: Move USB PID to board files"Abe Levkoy2020-09-281-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6ed9b65ae38977118f0d5f02d6f5c61da23c5f24. Reason for revert: Historically, Octopus variants used the baseboard VID and PID. Original change's description: > volteer: Move USB PID to board files > > Add TODOs to update variants boards. > > BUG=none > TEST=make buildall > BRANCH=none > > Signed-off-by: Abe Levkoy <alevkoy@chromium.org> > Change-Id: If0d8d0dd544c06114f355dcf281b2841a8397aee > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2417348 > Reviewed-by: Keith Short <keithshort@chromium.org> BUG=b:168826898,b:168827570,b:168827133,b:168827128,b:168827420 BUG=b:168827418,b:168826886,b:168826868,b:168827029,b:168826914 Change-Id: I5b9b1cee25e34a4b922fd604b49deabc9591b4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2431687 Tested-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Abe Levkoy <alevkoy@chromium.org>
* voxel: undefine CONFIG_CHIP_INIT_ROM_REGIONBen Chen2020-09-261-2/+0
| | | | | | | | | | | | | | Supports NPCX797FC dose not leave unused flash space. BUG=b:169172356 BRANCH=master TEST=make buildall Change-Id: I643790fc34b949d4efc847bb102f3d29fd341a12 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2425986 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org>
* volteer: Move USB PID to board filesAbe Levkoy2020-09-181-0/+2
| | | | | | | | | | | | | Add TODOs to update variants boards. BUG=none TEST=make buildall BRANCH=none Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Change-Id: If0d8d0dd544c06114f355dcf281b2841a8397aee Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2417348 Reviewed-by: Keith Short <keithshort@chromium.org>
* voxel: delete voxel_npcx797fc switch variantBen Chen2020-09-141-6/+0
| | | | | | | | | | | | | the only support CHIP_VARIANT npcx797fc ec chip BUG=b:163687531 BRANCH=master TEST=make buildall, workable on the re-worked Board. Change-Id: I313d3669d6acc7815dbd67e0730b5ae2bcf9522e Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2405714 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* voxel:Switch RT1715 TCPC for TUSB422Ben Chen2020-09-102-29/+32
| | | | | | | | | | | | | | | Replace the TUSB422 driver/I2C address with the RT1715 of C0/C1 type-C port by BOARD version define BUG=b:165765710 BRANCH=master TEST=check usb and DP function workable. Change-Id: Id53e4b05e9a5509e8af9eb7ffff35c2941899104 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2389725 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* voxel: modify mb gpio pin defineBen Chen2020-09-032-11/+9
| | | | | | | | | | | | | config mb gpio pin define. BUG=b:160363945 BRANCH=master TEST=make buildall PASS. Change-Id: Iee9295b09d4629be3fbbe7852db43d1b607f1086 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2388364 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* voxel:: modify mb gpio pin for BB retimer INT.Ben Chen2020-09-021-2/+2
| | | | | | | | | | | | | | Add USB_C0_RT_INT_ODL/USB_C1_RT_INT_ODL default INPUT dtype for mb typec C0/C1 port. BUG=b:166003345 BRANCH=master TEST=make buildall PASS, check system can power on. Change-Id: Ibeb457d127b22d6d7c93481536cea864a7750dd9 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2386684 Reviewed-by: Keith Short <keithshort@chromium.org>
View Lorry Controller Status