| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Normally we don't do this, but enough changes have accumulated that
we're doing a tree-wide one-off update of the name & style.
BRANCH=none
BUG=chromium:1098010
TEST=`repo upload` works
Change-Id: Icd3a1723c20595356af83d190b2c6a9078b3013b
Signed-off-by: Mike Frysinger <vapier@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891203
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable CONFIG_ASSERT_CCD_MODE_ON_DTS_CONNECT on all dedede boards. This
will assert GPIO_CCD_MODE_ODL when a debug device is connected to a CCD
port. GPIO_CCD_MODE_ODL must be configured as an open drain so EC and
Cr50 don't drive fight.
BUG=b:190189242
TEST=Build dedede
BRANCH=None
Change-Id: I2d71312967f2d4a693ac9753279f49478e8c092c
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2976759
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add internal pull-ups to volume button GPIOs.
BRANCH=None
BUG=b:172487251
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I884f5180fa09318192b50ec1b7da6d3a8c741cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2520100
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For boards which are using the SM charger chips, they will have a Psys
offset register to generate the OCPC Psys output.
BRANCH=None
BUG=b:168783892
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ib963ed11f73a76dfeffa11d5ab4a81ccbbd71102
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2435746
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is an external pull-up on this signal, and so the EC pull-up is
unnecessary and may cause an intermediate voltage when the system enters
G3.
BRANCH=None
BUG=b:169179804
TEST=make -j buildall, boot to S0 on drawlat
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I82a513777018eb9a6cd86450612a5c943d7bd357
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2429385
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove VSYNC sensor, and related GPIOs and configs.
BRANCH=None
BUG=b:169056723
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ib37e648ea04b5da3ed9ce6a660fcd60f2bfe264a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2424891
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 27ee378bb78a299a0983379be83eb6d55860b4ae.
Reason for revert: b/162508724
A wake-up source from hibernation needs to be determined only by RO. Reverting back to the original implementation: CL:2236589.
Original change's description:
> power: Clear AP_IDLE when waking up by PB or LID
>
> Currently, AP_IDLE is cleared when EC wakes up by the power button or
> the lid open.
>
> This patch extends the logic from CONFIG_EXTPOWER_GPIO to
> CONFIG_EXTPOWER so that the bug (chromium:1073960) can be also fixed
> on the boards using non-GPIO method for extpower_is_present.
>
> Tested as follows on Trembyle:
> 1. Put DUT in hibernation.
> 2. Wake up DUT and observe:
> a. When waking up by power button, AP is turned on.
> b. When waking up by lid open, AP is turned on.
> c. When waking up by AC, AP is left idle.
>
> BUG=b:157077589, chromium:1073960, b:159350276
> BRANCH=none
> TEST=See above.
>
> Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
> Change-Id: I944aaac036ce58659e81b7021e52a3291f31e951
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2283946
> Reviewed-by: Jett Rink <jettrink@chromium.org>
Bug: b:157077589
Bug: chromium:1073960
Bug: b:159350276
Bug: b:162508724
Change-Id: Iaf9d0af2ca8c48bbf2529c4ba05493837dd76287
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2333106
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Auto-Submit: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As of board revision 1, there is a GPIO to enable Vbus for the type-A
port. Turn this GPIO on when we're booted, and off when the system is
shut down. This pin is NC on revision 0, so it should be fine to set
regardless of hardware version.
BRANCH=None
BUG=b:160336151
TEST=on waddledee rev 1, able to use flash drive plugged into MB
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Idc1ae5fd05b904b01bc56bd8dd2a69d34caee9ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2283943
Tested-by: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=None
BUG=b:160362315
TEST=on waddledee proto 1, no leakage is observed on PP3300_SOC_A
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I4ec568d77b80343a958d486a84dbda93a4f7c423
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2278598
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Will Arthur <wda@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The C1 interrupt line is swapped between board versions 0 and 1. Track
which line is correct for the board version in a variable. Note that
this commit would not allow the pen charging line to output correctly.
BRANCH=None
BUG=b:153684907
TEST=on waddledee version 0, ensure C1 still works
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ie07052b8b27c219505da5f463d6846a18b08e6a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2220450
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This GPIO will be used for communication with the cr50 when EFS2 is
enabled.
BRANCH=None
BUG=b:156785198
TEST=make -j buildall, waddledee boots
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ia1193bf61995ec0f1892a753570f28eaba64ab26
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2210863
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to tPLT17 in the PDG, the time from SLP_S3_L assertion to
VCCIN_EN de-assertion should be less than 200us, but this was not
occurring on waddledoo. This commit adds a special interrupt handler
in order to meet that timing requirement by immediately deasserting
ALL_SYS_PGOOD once SLP_S3_L is asserted.
BUG=b:152552074
BRANCH=None
TEST=Build and flash waddledoo, boot and shut AP down, verify that the
time between SLP_S3_L asserting and ALL_SYS_PGOOD deasserting is less
than 200us.
TEST=`make -j buildall`
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: Ib34016d5bdfa956f410dde3e3b3074bd306a18f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2142744
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit changes EC_MKBP_INT_L to be an open-drain output. The AP
firmware will also be configured to apply an internal pull-up to allow
this configuration to work.
BUG=b:151680590
BRANCH=None
TEST=Build and flash waddledoo with modified AP FW that sets internal
pull-up, verify that EC_MKBP_INT_L is asserted when the AP shuts down
and is de-asserted when the AP turns on.
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Change-Id: I76a772f88ab8af1a9c7c699e5922eb86b926ae86
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2109117
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit configures the DAC module in the waddledee build and sets
up the PSYS output to use it.
BUG=b:149094279
BRANCH=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I1b08e46f25ec3f14924b0ed9da17a8cd213ddacc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2110534
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit adds tasks to cover PD functionality, charging, and LED
behavior. The charger and TCPC functionality are a part of the ITE
variant code for now, but may be moved out as OEM boards are determined.
BUG=b:146557556
BRANCH=None
TEST=make -j buldall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I50df3caabfae5e3981d7a8b76c0a76332f7d00a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2110532
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the EC isn't using EN_VCCST itself, but we are using
external logic to set this pin. The pin is initialized to low on the
EC which causes a drive fight.
This commit changes GPIO_EN_VCCST to an input while we determine
whether or not we will use this pin in the EC.
BUG=b:149775160
BRANCH=None
TEST=`make -j buildall`
TEST=Build and flash waddledoo, verify EC cannot set EN_VCCST.
Change-Id: Ia9f439d3d049580ac66689fdde11ed75ca044584
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068801
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
This commit contains the initial code for waddledee, the ITE reference
board for dedede. All of the GPIOs are defined, and any tasks that can
be enabled to begin with are. Since the charger driver is still in
progress, this commit undefs any charger related baseboard features,
and they will be re-enabled once the driver is ready.
BUG=b:146557556
BRANCH=None
TEST=builds
Change-Id: Ie5901304f92bf9040f1c883fb738c9f3bda0e95e
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2044359
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|