| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the interest of making long-term branch maintenance incur as little
technical debt on us as possible, we should not maintain any files on
the branch we are not actually using.
This has the added effect of making it extremely clear when merging CLs
from the main branch when changes have the possibility to affect us.
The follow-on CL adds a convenience script to actually pull updates from
the main branch and generate a CL for the update.
BUG=b:204206272
BRANCH=ish
TEST=make BOARD=arcada_ish && make BOARD=drallion_ish
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I17e4694c38219b5a0823e0a3e55a28d1348f4b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3262038
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gyro sensor add 2nd source icm-40608
BUG=b:196286186
BRANCH=zork
TEST=make BOARD=woomax
1. Set CBI SSFC 0x03 and using command
"watch ectool motionsense lid_angle" for sensor icm-40608.
2. Using command "watch ectool motionsense lid_angle" for BMI160.
Signed-off-by: Michael5 Chen1 <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I8db74d6e42858f0e7c6f5c60b22f811c6ab0d190
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3088971
Reviewed-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the LED on/off module towards using a more flexible LED support
approach. Define a weak power LED table and setter for boards to
override when needed. Note that during run-time these functions will
not get called since led_auto_control_is_enabled() will return false for
nonexistent LEDs.
This consumes an average of 165 additional bytes of flash space on
boards which do not use a power LED.
BRANCH=None
BUG=b:185508707
TEST=make -j buildall, load on guybrush (battery LED only) and confirm
no errors are seen. Load on Boten (both LEDs) and confirm behavior
appears normal
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Iaa1e22a7f5d8be39eb8792ee13d358087d7f7482
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2832691
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
C++ doesn't allow forward enum references.
BRANCH=none
BUG=b:144959033
TEST=make buildall
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I7e1f8890005e05136eeb4e5084505988dbbb15b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2740566
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GPIO-only MKBP only works when the AP is awake; we need to use
GPIO_AND_HOST_EVENT in order to support waking the AP in response to
MKBP events; in particular DP_ALT_MODE_ENTERED.
We also configure the MKBP wakeup mask so powerd can apply configuration
at runtime per chromeos-config: if no mask is configured then the
hostcmd to set the wakeup mask is not included in the firmware.
Wake on MKBP (and thus wake on DP) also requires AP firmware support.
https://review.coreboot.org/c/coreboot/+/48844 implements it for Zork.
BUG=b:174121852
TEST=Generating DP event via EC console on morphius with patched AP
firmware successfully wakes system from S3.
BRANCH=zork
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Change-Id: Ifb193399259674da17694aac5213bfd1f189ee59
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2607026
Reviewed-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The issue with F9/F10 in tablet mode has not been fixed,
but that is lower priority than functional top row keys,
so re-enable Vivaldi keyboard layout for Woomax.
BUG=b:156200330 b:164207227
BRANCH=zork
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Iad7158fde2af0837de5352ff5791306bb7eb78c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2519399
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement EC fan control table by thermal request.
BUG=b:171025573
BRANCH=firmware-zork-13434.B
TEST=make BOARD=woomax
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: Iafdea26ecc9f27092df92634f7d89a9b4ce8d7db
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2491940
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For board version 2, the OPT3 USB HPD change to EC GPIOB1.
BUG=b:160579667
BRANCH=firmware-zork-13434.B
TEST=make BOARD=woomax
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: Ic7ea0d02bd8942779138402155e9941f36c6d9f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2494601
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Woomax's battery takes serval seconds to come back from the cutoff
state.
Recorded about ~4 seconds, so bump the init timeout up to 5 second for
some margin as well.
BUG=b:169739759
BRANCH=zork
TEST=Verify DUT will boot up from cutoff a few seconds after AC power is
pluging in.
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I94f412a3b8955c83c511d4073b121cd701de5168
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2455014
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:169300359
BRANCH=zork
TEST=check power consumption
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: Ie1736313d004783ac2dc6bfd41591afa05c4edbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2437573
Reviewed-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The RTD2141 MST hub on some daughterboard options requires the EC to drive
its HPD input because HPD comes over USB-PD, but the MST hub then drives
the AP's HPD input. The EC was incorrectly driving nothing, causing DP
outputs on port C1 to not be detected.
Because the MST's HPD input is connected to an IO expander on current
hardware, configure the USB-C and Trembyle-specific HPD twiddling code to
support regular or expander GPIOs. Experience says IO expanders tend to be
too slow for reliable HPD, but this should allow some (possibly flaky) HPD
support until hardware changes are completed to put the output directly on
an EC GPIO.
BUG=b:159051013,b:165622386
TEST=still builds (I have no v3 hardware to test against)
BRANCH=None
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Change-Id: I9e041ab7c222927a11b8972920b7e978ab30d751
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2366456
Reviewed-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Use an UNIMPLEMENTED GPIO for PORT_TO_HPD so that EC does not drive HPD
for OPT3 DB.
2. Remove USBC_PORT_C1 IOEX 10 (HDMI_CONN_HPD_3V3_DB)
BUG=b:160579667, b:161579729
BRANCH=none
TEST=make buildall
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I09a0551ca3ab5a61980fdde6e557c54d8c38fc58
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2322746
Reviewed-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable Vivaldi keyboard for all Zork devices now that the related
coreboot support is present.
BUG=b:156200330
BRANCH=none
TEST=enter recovery, enter VT2
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Id64a1243aa3845bc61b05f62d888e6b84a8efda9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2307716
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initialize the vivaldi keyboard.
BUG=b:156200330
BRANCH=master
TEST=Manual
1. Scan all key.
2. Check F1 to F10 function.
3. Check ALT + Volup + H.
4. Check ALT + Volup + R.
5. Check F2 + powerbutton (EC reboot).
6. Check ESC + F2 + powerbutton.
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I3a8309050747f424aa18c790094d0c2500b35761
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2299600
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable GMR sensor.
BUG=b:160834197
BRANCH=master
TEST=manual
Check TABLET_MODE_L pin status when gmr sensor triger.
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: Ib12fd74947025fcdb92b8e257f291f5757b197f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2289471
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove CONFIG_SYSTEM_UNLOCKED and CONFIG_I2C_DEBUG from all
Zork boards.
BUG=b:138601010
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I846335e8402b719bbbf5711aa805b727a0902919
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2288153
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the EC LED code dependent on spec.
BUG=b:160542345
BRANCH=master
TEST=manual
1. Check battery LED on full charging / Charging / Discharging.
2. Check power LED on S0/suspend/S5.
3. Check "ectool led" command for battery and power LED control.
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: Ibbb5b97a368805267a28f0da6ec7c9684a2ce3bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2280869
Reviewed-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Config the EC battery setting depend on battery spec.
BUG=b:160412962
BRANCH=master
TEST=manual
1. Check EC log found battery.
2. Check battery cutoff maode (ectool batterycutoff at-shutdown)
3. Check battery Discharging FET status when battery full.
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: Ia17721bb6a9d968842a3e5e2bfdbd8d68cc84c4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2279343
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove USB-A1 and correct FW_CONFIG.
BUG=b:160293750
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I6e415c3dac85905af812ac5ce26ad3bbf4fcf869
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2277212
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
Create the initial EC image for the woomax variant by copying the
trembyle reference board EC files into a new directory named for
the variant.
(Auto-Generated by create_initial_ec_image.sh version 1.0.3).
dbrockus: Adjusted missing portions of the code to allow
woomax to build.
BUG=b:158692530
BRANCH=none
TEST=make BOARD=woomax
Signed-off-by: Michael5 Chen <michael5_chen1@pegatron.corp-partner.google.com>
Change-Id: I35abb2a9358d24d1f20bcbc2caa216d36a89fce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2241085
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Tested-by: Denis Brockus <dbrockus@chromium.org>
|