summaryrefslogtreecommitdiff
path: root/board
Commit message (Collapse)AuthorAgeFilesLines
* krane: set end of charge current threshold to 140mAstabilize-12607.6.Bstabilize-12607.5.Bstabilize-12607.3.BTing Shen2019-10-181-0/+14
| | | | | | | | | | | | | | | | According to the battery spec in b/142097561#comment15, EoC current should be 140mA. BUG=b:142097561 TEST=make BRANCH=kukui Change-Id: I913a1abecd2fc6ac28ba16513c3f0cc145afc38c Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1866212 Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* board/hammer: Fix masterball touchpad settingsNicolas Boichat2019-10-181-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | Fix the dimensions, and also the size, and make sure that updating the FW actually works (it seems like increasing the timeout to 2000ms is needed). BRANCH=kukui BUG=b:140596094 TEST=Flash masterball, no warning in console on start TEST= Host: make TOUCHPAD_FW=S8648A-15H0_FW01.bin BOARD=masterball -j USE=updater_utils emerge-kukui -av ec-utils cros deploy $IP ec-utils DUT: usb_updater2 -d 18d1:503c -r; sleep 0.5; \ usb_updater2 -d 18d1:503c -s; usb_updater2 -d 18d1:503c ec.bin usb_updater2 -d 18d1:503c -p S8648A-15H0_FW01.bin Change-Id: Ia473ac420b42f52ad1639f950a3f08ff5d32df09 Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1847512 Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-by: Joel Kitching <kitching@chromium.org>
* krane: Modify the Charging and Fully charged LED colorLeo Zhou2019-10-181-5/+4
| | | | | | | | | | | | | | | Based on the Lenovo requirement,modify the Charging and Fully charged LED color as white BUG=b:137618886 BRANCH=kukui TEST=Do a charge test Change-Id: I75a3e9f24c98a67cb6b9dda8294c73926c20d4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1706248 Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Tested-by: Leo Zhou <zhoubo@huaqin.corp-partner.google.com> Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
* helios: Modify EC fan control tableMichael5 Chen2019-10-181-12/+6
| | | | | | | | | | | | | | | | | | Modify EC fan control table by Thermal request. (#21) BUG=b:136565336 BRANCH=none TEST=Manual Verify fan behavior by thermal team. Remove DPTF and check fan speed with temperature. When temperature over 65 degree, the fan start working. When temperature over 85 degree, the fan full run. And check system shutdown when temperature over 90 degree. Change-Id: I0d4633e9ba93ba12f28d4d069a9ae2a7a82fcedd Signed-off-by: Michael5 Chen <michael5_chen@pegatroncorp.com> Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1833944
* dratini: correct accel orientationDevin Lu2019-10-181-7/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BUG=none BRANCH=none TEST=When device is laying on a table, lid angle at 180, both sensors report gravity along Z axis: localhost ~ # ectool motionsense Motion sensing active Sensor 0: -1040 4336 15408 Sensor 1: 760 -291 17127 Sensor 2: 0 0 0 When on the base bottom edge, report gravity along Y axis: localhost ~ # ectool motionsense Motion sensing active Sensor 0: -960 14112 -5952 Sensor 1: 453 16136 -373 Sensor 2: 0 0 0 When on its left side, report gravity along X axis: localhost ~ # ectool motionsense Motion sensing active Sensor 0: 16352 -432 64 Sensor 1: 16802 -338 192 Sensor 2: 0 0 0 and check the screen rotation was normally. Change-Id: Idbe7184d5c14eb31d7823f9e17648d9bf3df4443 Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1866209 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
* Cr50: In hash crypto test, return valid hash for empty input.Gurleen Grewal2019-10-171-2/+0
| | | | | | | | | | | | | | | | | | | | FIPS ACVP tests require that on an empty input, the result is the hash of the empty string. In the current implementation, an empty result is returned. Change the implementation so it matches FIPS expectations. Also added two test cases in hash crypto test to check the corner case of the empty input. BUG=None BRANCH=cr50 TEST=test/tpm_test/tpmtest.py Change-Id: I9f5c3f71e4b10cbce2ea204eeb52e57ef26ad0e7 Signed-off-by: Gurleen Grewal <gurleengrewal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1866444 Reviewed-by: Andrey Pronin <apronin@chromium.org> Tested-by: Gurleen Grewal <gurleengrewal@google.com>
* volteer: Configure power sequencing signalsAbe Levkoy2019-10-174-0/+26
| | | | | | | | | | | | | | Configure power sequencing interrupts and power-enable lines. Leave SLP_S4_L, which will be virtual, unimplemented for now. BUG=b:139553375 TEST=make buildall BRANCH=none Change-Id: Idf11290c84deb9ea2a71f5498a4a0db5363d2a3b Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1865481 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* kukui: runtime usb mux config selectionTing Shen2019-10-171-0/+6
| | | | | | | | | | | | | | | | | The compile time IF_ENABLED(CONFIG_USB_MUX_XXX) does not work on kukui, change this to runtime selection. BUG=b:135079572 TEST=On Krane Rev5/Kodama, verify the mux switch to dp + usb mode (i2cxfer r 0 0x48 0x11 returns 0x03 or 0x13) BRANCH=kukui Change-Id: Ib44f0c383ed5f9156e3dd3bf6faa3daebb22e146 Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1864493 Tested-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
* cr50: Fix building with CRYPTO_TEST=1Vadim Sukhomlinov2019-10-171-2/+1
| | | | | | | | | | | | | | | | | | | | 1. Recent change https://crrev/1730605 introduced syntax error which is only affecting build with CRYPTO_TEST=1. This patch fixes it. 2. -Wformat which was turned on for /platform/ec caught another issue with CPRINTF() not receiving right number of parameters. BUG=none BRANCH=cr50 TEST=make BOARD=cr50 CRYPTO_TEST=1 Change-Id: Id5e61f7633d6e93aff761771c22b888aebd87265 Signed-off-by: Vadim Sukhomlinov <sukhomlinov@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1863813 Tested-by: Andrey Pronin <apronin@chromium.org> Commit-Queue: Andrey Pronin <apronin@chromium.org> Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org>
* fleex: Change adjust charge max sleep time to 10selthanhuang2019-10-161-0/+11
| | | | | | | | | | | | | | | Change CHARGE_MAX_SLEEP_USEC to 10 seconds. BUG=b:133375756 BRANCH=octopus TEST=Verify access battery once per 10 seconds by ec console. Change-Id: I273ec13381d131866c536b879f5a912a63a53ecb Signed-off-by: elthanhuang <elthan_huang@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1852864 Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Jett Rink <jettrink@chromium.org> Tested-by: Jett Rink <jettrink@chromium.org>
* dratini: enable ec_feature kbbacklit by SKUIDDevin Lu2019-10-162-0/+25
| | | | | | | | | | | | | BUG=b:140610519 BRANCH=none TEST=make sure ectool inventory has shown keyboard backlight support with dratini/dragonair kbbacklit SKU. Change-Id: I8fceebc417d4b5b319dbc6126d8311346f09bdcf Signed-off-by: Devin Lu <Devin.Lu@quantatw.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1859234 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
* Trembyle: Add USB-A retimer GPIO definitionsEdward Hill2019-10-151-1/+4
| | | | | | | | | | | | | | Add enable and reset IO expander signal definitions for USB-A PS8811 retimers. BUG=b:138600008 BRANCH=none TEST=none Change-Id: I48731c143c08f450047a920c090c6abc6b30af4f Signed-off-by: Edward Hill <ecgh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1854373 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* icelake: Cleanup GPIO_PCH_DSW_PWROKKeith Short2019-10-152-7/+9
| | | | | | | | | | | | | | | | | | Change GPIO_EC_PCH_DSW_PWROK to GPIO_PCH_DSW_PWROK to match convention for EC to PCH signals used by other Intel processors (specifically cannonlake already used GPIO_PCH_DSW_PWROK). BUG=none BRANCH=none TEST=buildall -j Change-Id: I59fb8d3ee3867c70dde74c186ba3974490c3cd27 Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1848252 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* cometlake: Cleanup GPIO_PCH_SYS_PWROKKeith Short2019-10-157-48/+55
| | | | | | | | | | | | | | | | | | | | Change GPIO_EC_PCH_SYS_PWROK to GPIO_PCH_SYS_PWROK on cometlake to conform with naming convention used on other Intel processors. Leave gpio.inc files unchanged and add a mapping from GPIO_EC_PCH_SYS_PWROK to GPIO_PCH_SYS_PWROK in the board files. BUG=none BRANCH=none TEST=make buildall -j TEST=boot kohaku Change-Id: I722cb06dd90ee5d7e426664508f54a5cbe19de4a Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1848251 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* cometlake/icelake: cleanup GPIO_PCH_RSMRST_LKeith Short2019-10-151-1/+0
| | | | | | | | | | | | | | | | | | | | | Replaced references of GPIO_EC_PCH_RSMRST_L with GPIO_PCH_RSMRST_L in to match convention used in common Intel power sequencing. Boards still use GPIO_EC_PCH_RSMRST_L in their gpio.inc files to match schematic net names. BUG=none BRANCH=none TEST=buildall -j TEST=boot kohaku (cometlake device) TEST=run "apshutdown" on kohaku Change-Id: Ic9fa13dbf2d4e6c8953b82a9dd20f48a6cf8d2c8 Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1846690 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* kohaku: Change halt temperature to 90 CTim Wawrzynczak2019-10-151-1/+1
| | | | | | | | | | | BUG=b:142410208 BRANCH=none TEST=buildall Change-Id: I8eb8d2b8ef35572f50cc3dfd1a56b7503fadb1e1 Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1859828 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* helios: Support GMR sensor for rev2 boardMichael5 Chen2019-10-143-1/+16
| | | | | | | | | | | | | BUG=b:141723737 BRANCH=Master TEST=Manual Check tablet mode behavior for board version 1 and 2. Change-Id: Iea992b726d9c5a8e4562362dbd24aec8460742c4 Signed-off-by: Michael5 Chen <michael5_chen@pegatroncorp.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1831933 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
* Kled: fix rotation matrices of lid sensorsben.chen2@quanta.corp-partner.google.com2019-10-141-7/+2
| | | | | | | | | | | | | | | | Has a set lid sensors place change.The rotation of lid matrices need to be fixed. BUG=b:142029194 BRANCH=Master TEST=Using ec console 'accelinfo on' verified lid angle now goes from 0 to 360 and swtiches to tablet mode after crossing 180 threshold. Change-Id: I0cc5ef07368366f9a645fa44fa29cceec5181539 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1839712 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Philip Chen <philipchen@chromium.org>
* volteer: Support keyboardAbe Levkoy2019-10-111-1/+3
| | | | | | | | | | | | | | | Configure keyboard features, enable keyboard-related tasks, and define a custom time period to wait for output to settle during key scan. BUG=b:139554320 TEST=make buildall BRANCH=none Change-Id: I0d28389361c87a868f62325b86b65fc5b2550a70 Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1841885 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* volteer: enable CONFIG_BRINGUPKeith Short2019-10-111-0/+6
| | | | | | | | | | | | | | Prevent EC from powering up AP during initial board bringup. BUG=none BRANCH=none TEST=make buildall -j Change-Id: Id0ec787ed34444a9e40174925d8c11a8e71d66d0 Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1850276 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* helios: Add TEMP_SENSOR4Paul Fagerburg2019-10-103-1/+10
| | | | | | | | | | | | | | | | | | Helios adds TEMP_SENSOR4 to the EC ADC2 pin. Add this to the list of temperature sensors that the EC can report on. BRANCH=None BUG=b:142266102 TEST=`make buildall -j` Verify that Helios builds correctly. Change-Id: I05ccaf5ac339d8a7e1ccd1e3079fc7bddfb841be Signed-off-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1848968 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com> Commit-Queue: Sean Abraham <seanabraham@chromium.org> Commit-Queue: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
* akemi: Add battery informationPaul Ma2019-10-102-31/+55
| | | | | | | | | | | | | | | | | | Akemi support three batteries: - LGC: L18L4PE0 - SUNWODA: L19D4PG2 - SMP: L19M4PG2 This CL add the support of them. BUG=b:141621369, b:141660298 BRANCH=none TEST=boot akemi board with battery, charging/discharging/cutoff work as expected. Change-Id: I8735f6a0bcd90abc4923d98b2d337ca41b9f12c7 Signed-off-by: Paul Ma <magf@bitland.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1831717 Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
* trembyle: define the IOEX_USB_A0_RETIMER_EN pinDenis Brockus2019-10-101-0/+1
| | | | | | | | | | | | BUG=b:138600691 BRANCH=none TEST=make buildall -j Change-Id: I4083e501e76a626370ebb36fa05418af532f3bc7 Signed-off-by: Denis Brockus <dbrockus@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1850192 Commit-Queue: Edward Hill <ecgh@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* trembyle: board specific fast switch enable/disableDenis Brockus2019-10-091-0/+2
| | | | | | | | | | | | | | | | | Added board specific tcpc FRS enable/disable to work around timing issues that we found with trembyle. Also added some of the bringup debug settings BUG=b:138599218 BRANCH=none TEST=make buildall -j Change-Id: Ia16db22a9c2b3a47a4273ea1350a5ea58b78f5aa Signed-off-by: Denis Brockus <dbrockus@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1847174 Commit-Queue: Edward Hill <ecgh@chromium.org> Reviewed-by: Edward Hill <ecgh@chromium.org>
* Trembyle: Update config for bringupEdward Hill2019-10-091-0/+2
| | | | | | | | | | | | BUG=none BRANCH=none TEST=build Change-Id: I05c3fa2a8b72941ef1758be45428b9911938d013 Signed-off-by: Edward Hill <ecgh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1845783 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* kodama: not provide dock keyboard power supply in S5/G3xiong.huang2019-10-081-3/+0
| | | | | | | | | | | | | | | When dock keyboard is connected to MB, MB doesn't provide power supply for dock keyboard to save system power in S5/G3. BUG=b:141157295 BRANCH=master TEST=GPIO EN_PP3300_POGO level is 0 through command 'ectool gpioget'. measure power of dock keyboard with multimeter. Change-Id: I587f39063054de83dbbeb12bd23a1113a04e61da Signed-off-by: Xiong Huang <xiong.huang@bitland.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1809180 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* jacuzzi: disable PP1800 when chipset offTing Shen2019-10-082-1/+30
| | | | | | | | | | | | | | | | | To improve G3 power consumption, a pin EN_PP1800_S5_L is added in board rev 1 and should be turned on before pmic on, and turned off after pmic off. BUG=b:138180455,b:141592177 TEST=verify jacuzzi rev 1 is bootable with this change BRANCH=master Change-Id: Iacd9b0fab97d775f15faa9b2df491940871bc7ff Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1773031 Reviewed-by: Yilun Lin <yllin@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
* Trembyle: Use correct battery settings.Edward Hill2019-10-082-17/+17
| | | | | | | | | | | | BUG=b:138601173 BRANCH=none TEST=battery charges ok Change-Id: I5dc993bfeb125ab188029375a5f37b3c06d67dd4 Signed-off-by: Edward Hill <ecgh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1845782 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
* Volteer: fix I2C bus 0Keith Short2019-10-081-1/+1
| | | | | | | | | | | | | | | | Wrong pins were configured for alternate mode on I2C bus 0. BUG=none BRANCH=none TEST=make buildall -j TEST=Loaded volteer image on Kohaku (which uses same EC and I2C configuration, verified i2cscan Change-Id: If9cd2eb38424c3cc821cf2cfe1ab4209a5f77b4a Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1846236 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* jerry: Enable LTO to save spaceDouglas Anderson2019-10-081-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | We're outta space on jerry. Builders are failing. It seems like we can magically save space like CL:1663540 by turning on LTO. Let's do it! Before on my local build: *** 28 bytes in flash and 5380 bytes in RAM still available on jerry RO **** *** 4476 bytes in flash and 5380 bytes in RAM still available on jerry RW **** After on my local build: *** 3168 bytes in flash and 5448 bytes in RAM still available on jerry RO **** *** 7616 bytes in flash and 5448 bytes in RAM still available on jerry RW **** BRANCH=None BUG=chromium:1011621 TEST=See above Change-Id: I2de0e6474a6d561fa4c44cc12d904a7c6339712f Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1846231 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
* cr50: correct the comment on ENTERING_RW in gpio.incNamyoon Woo2019-10-071-2/+5
| | | | | | | | | | | | | | | | The previous comments were not correct. ENTERING_RW is not a GPIO at H1. The reason of marking it unimplemented in gpio.inc is to avoid the compile error from cros FW common module. BUG=None BRANCH=cr50 TEST=make buildall. Change-Id: Ieecbc9128e4071accbe4408d41ec51cefb68cffc Signed-off-by: Namyoon Woo <namyoon@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1842031 Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* trembyle: change from SN53S330 to AOZ1380Denis Brockus2019-10-061-3/+4
| | | | | | | | | | BUG=b:138599218 BRANCH=none TEST=make buildall -j Change-Id: I1bcbd60636629751a8aad4f2574f33f391a4ad4c Signed-off-by: Denis Brockus <dbrockus@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1833923
* volteer: Configure GPIOs connected to keyboardAbe Levkoy2019-10-052-0/+11
| | | | | | | | | | | | | Configure the pins connected to the keyboard scan lines. BUG=b:139554320 TEST=make buildall BRANCH=none Change-Id: I245122aa589424b1cb397f99b5fd60deb434d87a Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1841884 Reviewed-by: Keith Short <keithshort@chromium.org>
* include: De-longify BIT() macroEvan Green2019-10-052-4/+4
| | | | | | | | | | | | | | | | | | | | | | | The BIT() macro was recently introduced to make things more comfortable to upstream Linux. However, there's no need for it to be a long. Change the macro back to being an int (int and long are the same on 32-bit platforms, which all of our ECs are), so that we can reduce the number of %l specifiers. The semantics of %l have changed, we are deprecating its use on master to reduce the risk that we accidentally cherry-pick one of those printfs to an old firmware branch. BUG=chromium:984041 TEST=make -j buildall BRANCH=None Change-Id: I95b9cd49895cc67998dcb1de9bab5b5591d93243 Signed-off-by: Evan Green <evgreen@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1834601 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: caveh jalali <caveh@chromium.org>
* printf: Fix formatting errorsEvan Green2019-10-054-6/+6
| | | | | | | | | | | | | | | | | | | This change fixes the printf formatting errors found by the compile-time prinf format checker. The errors fall into a few categories: 1. Incorrect size specifier (missing or extra l). 2. Missing or extra arguments. 3. Bad line splitting. BUG=chromium:984041 TEST=make -j buildall BRANCH=none Change-Id: I5618097a581210b9fcbfc81560dec050ae30b61c Signed-off-by: Evan Green <evgreen@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1819653 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* printf: Convert %h to %phEvan Green2019-10-051-2/+2
| | | | | | | | | | | | | | | | | | | | | In order to make printf more standard, use %ph. Pass a pointer to a struct describing the buffer, including its size. Add a convenience macro so that conversion between the old style and new style is purely mechanical. The old style of %h cannot be converted directly to %ph as-is because the C standard doesn't allow flags, precision, or field width on %p. Ultimately the goal is to enable compile-time printf format checking. This gets us one step closer to that. BUG=chromium:984041 TEST=make -j buildall BRANCH=None Cq-Depend:chrome-internal:1559798,chrome-internal:1560598 Change-Id: I9c0ca124a048314c9b62d64bd55b36be55034e0e Signed-off-by: Evan Green <evgreen@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1730605
* printf: Convert %T to %pTEvan Green2019-10-053-7/+9
| | | | | | | | | | | | | | | | | | | | | | In order to be more compliant to standards, and ultimately turn on compile-time printf format validation, switch the non-standard %T into %pT, which takes a pointer to a 64-bit timestamp as an argument. For convenience, define PRINTF_TIMESTAMP_NOW, which will use the current time as the timestamp value, rather than forcing everyone to pass a pointer to get_time().val. For a couple of instances, simply use CPRINTS instead. BUG=chromium:984041 TEST=make -j buildall BRANCH=None Cq-Depend:chrome-internal:1473305 Change-Id: I83e45b55a95ea27256dc147544ae3f7e39acc5dd Signed-off-by: Evan Green <evgreen@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1704216 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* kukui_scp: support CONFIG_PRESERVE_LOGSYilun Lin2019-10-041-0/+1
| | | | | | | | | | | | | | | | | Enable CONFIG_PRESERVE_LOGS to gather more information when SCP is crashed. TEST=1. crash scp 2. restart scp 3. restart timberslide to ensure the logs are fetched 4. see that untransmitted logs are fetched into /var/log/cros_scp.log BUG=b:140220117 BRANCH=none Change-Id: I12635afa6c92fd8fa9cc889ce75999f855f18db0 Signed-off-by: Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1833943 Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
* jacuzzi: enable bc12 interruptTing Shen2019-10-033-1/+11
| | | | | | | | | | | | | | BUG=b:141600087 TEST=make sure usb charge task receives USB_CHG_EVENT_BC12 event, and ec console prints "sts = 0x2, lim = 2400 mA, supplier = 6" BRANCH=master Change-Id: I3f654edc38792a71b33975db5de0577bc52e8f35 Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1833945 Reviewed-by: Yilun Lin <yllin@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* board/hammer: Add variant with backlight totally disabledNicolas Boichat2019-10-024-25/+34
| | | | | | | | | | | | | | | | | | | Some boards lack the external pull-up to indicate absence of keyboard backlight, so add a new HAS_BACKLIGHT define. Also, remove support for long deprecated early staff boards, and move backlight detection to RW only. BRANCH=none BUG=b:67722756 BUG=b:140596094 TEST=make BOARD=masterball -j Change-Id: I20d83ec9df64e2b00eed2ca540e4d302bbbee4d1 Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1833034 Reviewed-by: Wei-Han Chen <stimim@chromium.org> Reviewed-by: Yilun Lin <yllin@chromium.org>
* hammer: Finish renaming CONFIG_HALL_SENSOR to CONFIG_GMR_TABLET_MODENicolas Boichat2019-10-022-3/+3
| | | | | | | | | | | | | | | | 0beadf2ff "tablet_mode: Renaming for GMR sensor" missed part of the config name update (probably because the refactoring happened at the same time as the changes in hammer folder). BUG=b:139378190 BRANCH=none TEST=make buildall Change-Id: Ibb92cf12a2177630d31ad6a887cad6aa6f403b71 Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1830540 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Philip Chen <philipchen@chromium.org>
* juniper: initial setupTing Shen2019-10-021-0/+1
| | | | | | | | | | | | | | | Create a new build target "juniper" and point to jacuzzi board. BUG=b:141526426 TEST=make BOARD=juniper BRANCH=master Change-Id: Idc43368b05ef05370d7a98786f68bdfdc91c2d19 Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1816345 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org>
* host_command: Change host command return value to enum ec_statusTom Hughes2019-10-024-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the host command handler callback function returns an int, it's easy to accidentally mix up the enum ec_error_list and enum ec_status types. The host commands always expect an enum ec_status type, so we change the return value to be of that explicit type. Compilation will then fail if you accidentally try to return an enum ec_error_list value. Ran the following commands and then manually fixed up a few remaining instances that were not caught: git grep --name-only 'static int .*(struct host_cmd_handler_args \*args)' |\ xargs sed -i 's#static int \(.*\)(struct host_cmd_handler_args \*args)#\ static enum ec_status \1(struct host_cmd_handler_args \*args)##' git grep --name-only 'int .*(struct host_cmd_handler_args \*args)' |\ xargs sed -i 's#int \(.*\)(struct host_cmd_handler_args \*args)#\ enum ec_status \1(struct host_cmd_handler_args \*args)##' BRANCH=none BUG=chromium:1004831 TEST=make buildall -j Cq-Depend: chrome-internal:1872675 Change-Id: Id93df9387ac53d016a1594dba86c6642babbfd1e Signed-off-by: Tom Hughes <tomhughes@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1816865 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* volteer: Configure the GPIOs connected to LEDsAbe Levkoy2019-10-021-0/+6
| | | | | | | | | | | | | | | Configure the individual LEDs for PWM and the selector for GPIO. BUG=b:139554899 BRANCH=none TEST=make buildall Change-Id: I0f86cb86c6dbf1fa30f2782d4382d8509c7ecc57 Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1832886 Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
* drallion: Update Accel and Gyro I2C slave addressBernardo Perez Priego2019-10-011-2/+2
| | | | | | | | | | | | | BUG=b:141831203 BRANCH=master TEST=System boots and accel and gyro should be accessible Change-Id: I0c3bddfc55fbb157aff358871fe8389e81254a7d Signed-off-by: Bernardo Perez Priego <bernardo.perez.priego@intel.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1832342 Reviewed-by: Mathew King <mathewk@chromium.org> Commit-Queue: Mathew King <mathewk@chromium.org> Tested-by: Mathew King <mathewk@chromium.org>
* krane: change sensor-ref point to default device orintationYilun Lin2019-09-301-1/+1
| | | | | | | | | | | | | | | Switch from display scanout orientation to device default orientation. (go/chromeos-tablet-orientation) TEST=Ensure the display acts normal with UI patch. BUG=b:133201004 BRANCH=None Change-Id: If7a1632f3fcc03b381411b46d7b5441f8de5847d Signed-off-by: Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1826360 Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
* hammer: Use different KB scanning matrix for masterballNicolas Boichat2019-09-301-0/+26
| | | | | | | | | | | | | | ODM/OEM decided to change pinout. BRANCH=none BUG=b:140596094 TEST=make BOARD=masterball TEST=Check that there is not interrupt conflict in gpio.inc Change-Id: I45adaf77faecfb4fb99122abe146691c9c77098b Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1830539 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
* volteer: Add RTC resetKeith Short2019-09-296-25/+3
| | | | | | | | | | | | | | | Add support for the RTC reset on Volteer. This change also deduplicates the board_rtc_reset() function which was identical on boards that enabled CONFIG_BOARD_HAS_RTC_RESET. BUG=b:141321096 BRANCH=none TEST=make buildall Change-Id: Ifc6959f8271400174fd4999a3c70800b03b9c2d0 Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1816869 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* servo_v4: Disable CCD (monitoring SBU) when DTS-mode disabled by a userWai-Hong Tam2019-09-282-11/+14
| | | | | | | | | | | | | | | | | | | | | | | | The SBU monitoring logic is used for muxing the correct polarity for CCD. If the DTS-mode is disabled by a user, meaning that CCD is supposed not being used, the SBU monitoring logic can be disabled. For DP alt-mode, the SBU lines are used for AUX channel. This SBU monitoring logic affects the AUX channel, due to the strong pull-up on the USB D+ line. It should be disabled. Remove the original calls of ccd_enable(), which is called when supplying power and detecting DUT Rd/Rd or Rp/Rp. This requires PD comm. We don't want CCD depends on PD comm. BRANCH=servo BUG=b:137219603 TEST=The default role "cc srcdts", CCD works on both phyical polarity. TEST=Called "cc src", checked GPIO SBU_MUX_EN 0. Change-Id: I8f2f7bda88426e6097f0f4efd811114b7a1135c3 Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1815557 Reviewed-by: Nick Sanders <nsanders@chromium.org>
* kohaku: Enable multiple DPTF profileSeunghwan Kim2019-09-271-0/+3
| | | | | | | | | | | | | | This change enables multiple DPTF profile in EC. BUG=b:138395625 BRANCH=none TEST=Verified multiple DPTF profile works with test coreboot. Change-Id: I8742205fd7b4c5eb511cce934eb425499ca13244 Signed-off-by: Seunghwan Kim <sh_.kim@samsung.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1773025 Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Tim Wawrzynczak <twawrzynczak@chromium.org>
View Lorry Controller Status