| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL enables a given board to have its own policy regarding the mf
preference bit which is used by a UFP to signal its preferred pin
configuration in the DP Status message.
BUG=b:175434634
BRANCH=None
TEST=Verfied that the mf bit in the DP status message follows the
board preference.
Signed-off-by: Scott Collyer <scollyer@google.com>
Change-Id: Ied7cdb72d1e302aab25dd5531856b1c7c148e64f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2765422
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Scott Collyer <scollyer@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update touchpad parameter for zed.
There's no integer solution for CONFIG_USB_HID_TOUCHPAD_PHYSICAL_MAX_Y
(calculation appended below), this CL also modified the runtime check in
elan tp driver to allow rounding errors.
Math details:
Given dpi_y = 800, LOGICAL_MAX_Y = 1811, we want to find an integer
PHYSICAL_MAX_Y such that
dpi == 254 * LOGICAL_MAX_Y / PHYSICAL_MAX_Y.
The closest solution is
1)
PHYSICAL_MAX_Y = 574,
254 * LOGICAL_MAX_Y / PHYSICAL_MAX_Y = 801.3832 != dpi_y, or
2)
PHYSICAL_MAX_Y = 575,
254 * LOGICAL_MAX_Y / PHYSICAL_MAX_Y = 799.9895 != dpi_y
Both cannot pass our runtime verification.
BUG=None
TEST=No "TP mismatch" in ec console
BRANCH=trogdor
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I9d0c54d029bb2f9e78114341a6246857b41937b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2825473
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:184920909
BRANCH=firmware-octopus-11297.B
TEST=Test on charging/discharging/battery cut off pass.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I80d15bdef79e8e228c68d866c32e87d445bcf28e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2817139
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enabled keyboard backlight when system resume to S0
Disabled keyboard backlight when system suspend
BUG=b:184103439
BRANCH=none
TEST=Keyboard backlight can work normally
Signed-off-by: Josh Tsai <Josh_Tsai@compal.corp-partner.google.com>
Change-Id: Idd4454bfba48d92bdfd75144141afac34c3781c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2822275
Reviewed-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-by: caveh jalali <caveh@chromium.org>
Tested-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Commit-Queue: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add console/host, ectool, command for testing
BUG=b:184821618
BRANCH=volteer
TEST=make buildall, test command, ex. "ectool lighbar off".
Lindar: Lightbar test code
Signed-off-by: reno.wang <reno.wang@lcfc.corp-partner.google.com>
Change-Id: I2b250d1b9bbc34ef533da34588ee969104f3b7f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2814721
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Move to SSFC to check if system support lightbar instead of sku id
2. Add lightbar 12 led support and EC can base on SSFC_LIGHTBAR type to
adopt different lightbar led cfg.
BUG=b:183826778
BRANCH=volteer
TEST=makee buildall, test SSFC_LIGHTBAR
Signed-off-by: reno.wang <reno.wang@lcfc.corp-partner.google.com>
Change-Id: Ic8fac16e846638c403e37261ecf15a72e805a8e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2822270
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Update code to match lightbar V9 behavior spec
2. Update lightbar led cfg to match lightbar HW design
3. Update amber (orange) color's current to increase brightness for
mechanism team's request.
BUG=b:183826778
BRANCH=volteer
TEST=makee buildall, test lightbar behavior follow V9 SPEC, check
lightbar green and amber color brightness.
Signed-off-by: reno.wang <reno.wang@lcfc.corp-partner.google.com>
Change-Id: I2626601aebc002fdf03fb5bb10f387a033378fa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2814720
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Baklava is a quiche variant that does not have the user facing DP
capable usbc port. This CL modifies the starting quiche image to
account for usbc port that is removed.
BUG=b:184595837
BRANCH=quiche
TEST=make -j BOARD=baklava. Verified C0 (host) port operation
Signed-off-by: Scott Collyer <scollyer@google.com>
Change-Id: Ic4455958d5cc6dbedfc17011113792ae3809e7be
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2727858
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Scott Collyer <scollyer@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add battery information for sunwoda.
BUG=b:182790995, b:181624369, b:178565802
BRANCH=None
TEST=make -j BOARD=sasuke
Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com>
Change-Id: I592f9ade6f700138d9302ca3c4bbca0e047e975a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2812598
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to SENSE_RESISTOR 10milliohm and battery spec,
modify ACProchot to 4096mA and DCProchot to 6000mA.
BUG=b:182753738
BRANCH=dedede
TEST=make BOARD=sasukette successfully,and local build test ok
Signed-off-by: Mike Lee <mike5@huaqin.corp-partner.google.com>
Change-Id: I52f1b0b1a6bf5e262771c01d07e803a729b30f56
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2822406
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable pull-down of GPIOB4 & GPIOB5.
When I2C function is enabled,
the pull-down option for GPIOB4,GPIOB5 is not work.
So alternative setting for these GPIOs must be cleared.
BUG=b:184914946
BRANCH=None
TEST=make -j BOARD=sasuke
Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com>
Change-Id: I3d125e844816f0a7c07cb0b166390e7131100e6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2822277
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the common LED on/off states for LED behavior. Set it up for our
two colors: amber and white.
BRANCH=None
BUG=b:184845299
TEST=on guybrush, confirm charging shows Amber, discharging is white,
shutdown shows no LED on
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Idc57de843fd2addaaa3006d4abd8566d76b2de6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2818151
Reviewed-by: Rob Barnes <robbarnes@google.com>
Commit-Queue: Rob Barnes <robbarnes@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
config adc temp senosr enable, re-config KB_BL_EN
to gpioG3 from GPIOI7
BUG=b:184885443
BRANCH=asurada
TEST=make buildall PASS
Change-Id: Ia0d12724ca33295f2817ee2a9a32dbff09aba87a
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2816939
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function is needed to detect the correct product ID for each port.
Add it.
BUG=b:183296099, b:183118990
BRANCH=none
TEST=Build lazor on zephyr; no obvious changes when run
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: I1c7637a6fa6ccd1f0b82cbbd62575c43f096b641
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2822391
Reviewed-by: Wai-Hong Tam <waihong@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the wake source pin definitions needed by the NPCX9 chip
support code for brya board ID 1. Note that board ID 1 needs a rework on
VCC1_RST to prevent it from falsely waking the board.
BRANCH=none
BUG=b:183246197
TEST=booted same image on old and new rev. of board
Used "hibernate" on EC console hibernate the system. It woke
up immediately (b/183412004) with cause "hibernate" indicating
this was a PSL wake:
--- UART initialized after reboot ---
[Image: RO, brya_v2.0.8357-19a8f337db 2021-04-08 01:09:30 caveh@caveh]
[Reset cause: power-on hibernate wake-pin]
LID_OPEN was tested as a PSL wake source by artificially disabling
CONFIG_HIBERNATE_PSL_VCC1_RST_WAKEUP to eliminate VCC1 as a false
wake source.
Change-Id: If4cca6d1e20ddc3c422697e6838c9df0ddd8cb15
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2728679
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates the GPIO functional changes to support the new rev. (ID 1)
of the brya board.
EC_KB_BL_EN moved from GPIO85 to GPIOA3 (was EN_SLP_Z). EC_KB_BL_EN is
set to low since that's the preferred setting for the initial keyboard
backlight. This does not break the old board due to a hardware bug on
the old board that causes it to come out of sleep unconditionally.
GPIO85 does not need to be configured here when PSL is enabled.
EN_SLP_Z is no longer used.
EC_RST_ODL (VCC1_RST#/GPO77) has been removed from config. This was an
unused input on the old board. This pin functions as a wake source when
we enable HIBERNATE_PSL_VCC1_RST_WAKEUP and does not need to be
configured here.
finally, PSL is enabled on pins PSL_IN1-3.
BRANCH=none
BUG=b:184811017,b:183246197
TEST=both old new new revision of the brya board can boot
Cq-Depend: chromium:2728679
Change-Id: I4b3ab17bb44d18167328faee1a1b604bf0428dd3
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2813460
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a new config CONFIG_USB_PD_ONLY_FIXED_PDOS. If that config is
enabled, ignore non-FIXED PDOs in both the console command `ada_srccaps`
and also when selecting the preferred PDO for a voltage.
Enable CONFIG_USB_PD_ONLY_FIXED_PDOS for servo_v4 and servo_v4p1, since
they don't expose non-fixed PDO in their srccaps. Without this change,
there is a risk that the "best" PDO for a given voltage will be
non-FIXED and then that voltage just won't be supported at all.
BRANCH=none
BUG=b:178484932
TEST=added
Change-Id: I0d1187ca372120c7fe21d627e1b82b59f6334add
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2809353
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable pull-down of GPIOB4 & GPIOB5
BUG=b:184914946
BRANCH=None
TEST=make -j BOARD=sasuke
Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com>
Change-Id: I27e1b612956f217418178783cf28c5c466f281ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2817140
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove GPIO43 of ADC Alternate function and set Input and Internal pull up.
BUG=b:181325655
BRANCH=dedede
TEST=make BOARD=cret
Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com>
Change-Id: I3e506c0916a284a57afa93f8e100f45c285a38bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2817683
Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the Forest Creek battery to Cret.
BUG=b:185066840
BRANCH=dedede
TEST=make BOARD=cret
Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com>
Change-Id: Ib4c9c3feb7236b2d2a3d6224249003797ce1c189
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2817691
Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous equation in CL:2771482,
would cause lux = 0 on some ALS board in specific ambient light
, we worked with vendor and update the lux equation:
Lux = LuxScalar * (DGFn * ((C * Ccoefn) + (R * Rcoefn) +
(G * Gcoefn) + (B * Bcoefn)) / (Atime*Again))
Lux = MAX(0, Lux)
If (G+B)/C < 0.692 n=1
If (G+B)/C >= 0.692 and < 1.012 n=2
else n=3
LuxScalar = 1.00
Coeffs n=1(Lo) n=2(Med) n=3(Hi)
Ccoef 0.009 0.202 -0.661
Rcoef 0.056 - 1.1 1.334
GCoef 2.735 8.692 1.095
BCoef -1.903 -7.068 -1.821
DGF 799.797 801.347 795.574
BUG=b:184238881
BRANCH=puff
TEST=verify equation works as intended.
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: Ic9e41579c37544496f54a4faeb1a0d0aeea8f7c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2812601
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Commit-Queue: Gwendal Grignou <gwendal@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is the starting image for baklava which is a quiche
varaint. The only changes made are updating the year and board
name. The follow on CL contains changes relative to quiche.
BUG=b:184595837
BRANCH=quiche
TEST=make -j BOARD=baklava
Signed-off-by: Scott Collyer <scollyer@google.com>
Change-Id: I62f1b6cd710f272833a97f50dc7fe7e1ac27b85e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2806185
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initial base BMI160 sensor.
BUG=b:178213305
BRANCH=none
TEST=make -j BOARD=guybrush
TEST=can read the sensor data in ec console by i2cxfer.
Signed-off-by: Matt_Wang <Matt_Wang@compal.corp-partner.google.com>
Change-Id: Id49ff98dc921ba173b24f3c389fcfbde337ce77c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2783514
Tested-by: Matt Wang <matt_wang@compal.corp-partner.google.com>
Reviewed-by: Bhanu Prakash Maiya <bhanumaiya@google.com>
Reviewed-by: Rob Barnes <robbarnes@google.com>
Commit-Queue: Rob Barnes <robbarnes@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch extend CPU prochot latch time to 60ms,
when OCP protect triggered to pass safety requirement.
BUG=b:184812462
BRANCH=puff
TEST=verify CPU prochot can latch 60ms when OCP triggered.
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: I41721670d6fac9266bad546fc86b0c1e0f46b183
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2810427
Reviewed-by: Andrew McRae <amcrae@chromium.org>
Commit-Queue: Andrew McRae <amcrae@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds support for the power button including a new task to
allow for power sequencing delays.
The power button is used for two purposes. First, to turn the dock on
or off, and second, to allow for a user set preference of the MF for
DP 2 or 4 lane selection. If the dock is off, the dock will be turned
on as soon as the short press timer expires. If the dock is already
on, then a short press action is only recognized on the release so a
long press will only change the MF preference.
BUG=b:164157329
BRANCH=quiche
TEST=manaual
short press -> turns dock on off as expected
long press -> toggles MF preference and flashes LED
Signed-off-by: Scott Collyer <scollyer@google.com>
Change-Id: I8519c072a7f10657c369344ead6149fc7d31bb36
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2718268
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Sam Hurst <shurst@google.com>
Commit-Queue: Scott Collyer <scollyer@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This renames some GPIOs to match the new board revision (ID 1):
LID_OPEN_OD to LID_OPEN
TABLET_MODE_ODL to TABLET_MODE_L
PRB_EC_GPIOC0 to EC_PCH_WAKE_R_ODL
Even though EC_PCH_WAKE_R_ODL looks like a new signal, in both cases,
this pin is not connected to anything. So, there are no functional
changes involved.
BRANCH=none
BUG=b:184811017
TEST=buildall passes
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Change-Id: Ib8eb016f2a209bec8ffb547605c967985a38e232
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2813459
Reviewed-by: Boris Mittelberg <bmbm@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create initial commit for Homestar keyboard.
BUG=b:183899273
BRANCH=trogdor
TEST=bootable on Coachz/Zed
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: Ibed73189bd518b54e0205fe24255a4c3a0ae84fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2816304
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Commit-Queue: Wai-Hong Tam <waihong@google.com>
Tested-by: Wai-Hong Tam <waihong@google.com>
Auto-Submit: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the SM5803 shares an interrupt line with the TCPC, allow the
PD_INT task for C1 to process interrupts for this chip. This will
ensure that any interrupts from the charger are handled at a high
priority and cannot leave the shared IRQ line low for extended periods.
(This CL aligns with CL:2803462)
BUG=none
BRANCH=dedede
TEST=On kracko, confirm charger attach to C1 works reliably.
Signed-off-by: Tommy Chung <tommy.chung@quanta.corp-partner.google.com>
Change-Id: I21622c1ca06db9b600079487053f6efdaa8cf88e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2817138
Reviewed-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove open-drain flags in led pwm ch.0 and ch.2.
BUG=b:184662294
BRANCH=ambassador
TEST=make sure the led behavior is normal.
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Change-Id: I253035f19207414b9a3126c4dc22d913b6f90994
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2812604
Reviewed-by: Joe Tessler <jrt@chromium.org>
Commit-Queue: Joe Tessler <jrt@chromium.org>
Tested-by: Joe Tessler <jrt@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two C1 muxes are currently supported for guybrush. Configure the correct
C1 mux at runtime based on fw_config.
Move board_c1_ps8818_mux_set to guybrush board.c since it's board
specific tuning.
BUG=b:184548806
TEST=Build and run on guybrush B2
BRANCH=None
Signed-off-by: Rob Barnes <robbarnes@google.com>
Change-Id: I6ff809a9cbd1ddc2a408d2ce84f75d6723b7844f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2809259
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:184793035
TEST=make BOARD=asurada_scp && make BOARD=cherry_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: I3d9406bf15275a0423cdf2b9ca5ea1b2ea96f7df
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2814478
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cherry's SRAM size is 768KB. Changes the memory layout accordingly.
BRANCH=none
BUG=b:184793035
TEST=make BOARD=cherry_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: I46de843610942842511d47922bd7d99a84ddeca8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2813400
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is basically: cp -r board/asurada_scp board/cherry_scp.
BRANCH=none
BUG=b:184793035
TEST=make BOARD=cherry_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: I7a035962a5a371587b5bea6f1cd78cd777dcdc8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2813399
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves common code from board/asurada_scp to baseboard/mtscp-rv32i.
BRANCH=asurada
BUG=b:184793035
TEST=make BOARD=asurada_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: I34f9d789ee60449630dd580a9eccff69493b4b21
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2814042
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement motion sensor setting on MB side and sensor board side.
The sensor of model:
1.MB: LSM6DSOTR
2.Sensor board: LIS2DE12TR
BUG=b:184504094
BRANCH=dedede
TEST=make BOARD=cret
Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com>
Change-Id: Ie010e38e5c2ffeb5acc09cdcf15aea429169cf5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2809925
Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Config the EC battery setting depend on battery spec.
BUG=b:175350831
BRANCH=firmware-dedede-13606.B
TEST=BOARD=galtic
1. Check battery found on EC log.
2. Check battery cutoff function on EC console.
3. Check battery charging FET status when battery full.
Signed-off-by: Jacky Wang <jacky5_wang@pegatron.corp-partner.google.com>
Change-Id: Ifcfcf0f14f89d4ce2fea1f1abd7db89f0d26fbb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2809778
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initialize vivaldi keyboard.
BUG=b:182016897
BRANCH=main
TEST=make BOARD=cret
Signed-off-by: Josh Tsai <Josh_Tsai@compal.corp-partner.google.com>
Change-Id: I727639a74aa2b11caf482ad3f1d91d4e84129b45
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2812602
Reviewed-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add ambient light sensor (with RGB) to motionsense task
BRANCH=none
BUG=b:179648721
TEST=manual tests. ALS test from AP console:
$ ectool motionsense calibrate 3
$ ectool motionsense
See the reading for sensor #3 (clear light) and #4 (RGB)
Sensor 3: 18366 0 0
Sensor 4: 9673 5656 3832
The values above change with light intensity and color. I've used Lifx
RGB light bulb to verify each channel works.
Signed-off-by: Boris Mittelberg <bmbm@google.com>
Change-Id: I5f0c1529ae1e05f4df0b0ec6fa01808f64092466
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2808136
Reviewed-by: caveh jalali <caveh@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add motionsense task with following sensors: lid accel, base accel, base
gyro.
BRANCH=none
BUG=b:179648721
TEST=manual tests were performed
Base accel/gyro test on EC console:
> accelread 1
Current data 1: -65461 65488 8163
> accelread 2
Current data 2: -2 2 65518
Lid accel test from AP console:
$ ectool motionsense
Sensor 0: 392 10548 12708
All the values above changed when I moved the boards
Signed-off-by: Boris Mittelberg <bmbm@google.com>
Change-Id: I03cddcf74611da6d2b5557a3998db6f0314a015a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2798977
Reviewed-by: caveh jalali <caveh@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new battery config : AP20CBL
BUG=b:184225420
BRANCH=volteer
TEST=Check found battery info in console and cutoff work.
Change-Id: I9496eb025a20a9da029be060dc7df50cd6b04306
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2799332
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This addresses a problem where brya shuts down when running without a
battery. The root cause is that VSYS droops too much when SoC power
demand spikes.
The solution is to raise the VSYS_TH2 threshold in the bq25720 charger
chip to provide an early throttle feedback signal to the SoC during high
load. The default threshold is 5.9v which is low enough to cause
problems. On Brya, we see VSYS drop all the way down to 5.4v at which
point the SoC shuts down. The voltage should never be drawn down that
low, so tune the charger to assert PROCHOT at 7.0v instead. This
throttles the SoC sufficiently during high load to avoid
instability. 7.0v was selected after consulting with EE team.
BRANCH=none
BUG=b:183474163
TEST=booted brya to the OS without a battery
Change-Id: Id06e567b9f8a499da7ceb345e673e091c94d90c2
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2798980
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Will Arthur <wda@google.com>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
change lid sensor from BMA255 to LIS2DH12
BRANCH=none
BUG=none
TEST=Verified the LIS2DH12 detection on the target system.
Change-Id: I014917c8eab60e1582f08dd8259efdec92ca6d91
Signed-off-by: Deepti Deshatty <deepti.deshatty@intel.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2812477
Reviewed-by: Sooraj Govindan <sooraj.govindan@intel.com>
Reviewed-by: caveh jalali <caveh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dual VBUS ADC are supported since board revision >= 4.
This is to address the inaccurate VBUS present detection on SYV682x.
SYV682X assumes can only recognize VBUS equals Vsafe5V or Vsafe0V.
If the VBUS is not falling at the both range, it assume the VBUS >
vSafe5V and thus VBUS is presented. But if the votlage is fallint
between Vsafe5V and Vsafe0V, it still thinks VBUS presented, and this
is a false positive.
BUG=b:181203590
TEST=ensure VBUS ADC reports reasonable value
BRANCH=asurada
Change-Id: I1b57395216f1d6788bcd09306b503bdd3b49ddc8
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2793853
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the function signature to
void pd_extract_pdo_power(uint32_t pdo, uint32_t *ma,
uint32_t *max_mv, uint32_t *min_mv);
Replace the original caller with an extra unused parameter, no
functional changes.
BUG=none
TEST=`pd 0 srccaps` prints the correct PDO info
BRANCH=asurada
Change-Id: I9b508e1a13737fe3ed61e6086416cff0c8ffb9a9
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2810660
Reviewed-by: Wai-Hong Tam <waihong@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clear the SourceCaps to prevent misleading info.
BUG=none
TEST=`pd 0 srccaps` no output if adapter unplugged
BRANCH=asurada
Change-Id: Ibfefb3cc2e91c548fdf6579603dd5be20d68c08e
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2810659
Reviewed-by: Wai-Hong Tam <waihong@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Each guybrush variant may have a different fw_config schema. Defining a
schema agnostic fw_config interface at baseboard. Each guybrush variant
must implement the interface. Fields that are not applicable outside a
specific variant do not need to be exposed in the baseboard interface.
BUG=b:178215011
TEST=Build and run on Guybrush B2
BRANCH=None
Change-Id: I41d24ffddfc41d3148ba6d3685f728f6ec962919
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2722982
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch updates oz554 register setting by each panel.
BUG=b:168444976
BRANCH=puff
TEST=read back oz554 setting through i2c as intended.
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: Icfa9c0c75df1d047768ba2057767e9736c65eeed
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2810426
Reviewed-by: Andrew McRae <amcrae@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit ac08c9d1dbc9f587df3ee6b15d58c0203f7e356e.
Reason for revert: Breaks public build
Original change's description:
> fpsensor: Support building firmware that works for both sensors
>
> This is a refactoring to allow building FPMCU firmware that works for
> one FPC sensor and one ELAN sensor.
>
> 1. When both drivers implement our common functions, e.g. fp_sensor_init(),
> rename them to fp_sensor_init_fpc() and fp_sensor_init_elan().
> 2. There are a few functions implemented not in FPC driver but in FPC
> private library, e.g. fp_sensor_finger_status(). I kept this as-is for
> FPC but renamed the one in ELAN driver to fp_sensor_finger_status_elan()
> 3. If building for ELAN, need to hardcode elan=1 in hatch_fp/board.c
> because the sensor type GPIO always says FPC.
>
> BRANCH=none
> BUG=b:175158241
> TEST=make run-fpsensor; make run-fpsensor_status;
> make run-fpsensor_crypto
> TEST=make -j BOARD=dartmonkey
> TEST=add CONFIG_FP_SENSOR_ELAN515 to board/hatch_fp/board.h;
> make -j BOARD=bloonchipper
> Firmware binary fully works on Dragonair (FPC) and Voema (ELAN)
> TEST=run device tests with http://crrev/c/2750547 and
> http://crrev/i/3654297 on Dragonclaw, all pass
>
> Change-Id: I789090dbdfe35ac6aefd6a629fa4c7bde89dc437
> Signed-off-by: Yicheng Li <yichengli@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2727971
> Reviewed-by: Tom Hughes <tomhughes@chromium.org>
> Commit-Queue: Tom Hughes <tomhughes@chromium.org>
Bug: b:175158241, b:184616069
Change-Id: I2a02a6eefc316e7e13aa188f1ae16672dce2babd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2809521
Auto-Submit: Tom Hughes <tomhughes@chromium.org>
Tested-by: Tom Hughes <tomhughes@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: caveh jalali <caveh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:181838424
TEST=1) EC console prints "found batt:LGC KT0030G020"
2) cutoff works
BRANCH=main
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I903d0140e75a7877fa8ae6a8f04997f44989755b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2807249
Tested-by: Ting Shen <phoenixshen@chromium.org>
Tested-by: Parker Lin <parkerlin@google.com>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL enables SYV682C for hayato revision > 2.
BUG=b:160548079
TEST=1. hayato meets tVconnOff
2. hayato meets tVBUSDischarge
BRANCH=asurada
Change-Id: I424b7785ba877b7cfdc413b8b253457a759b98d3
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2738507
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|