| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the interest of making long-term branch maintenance incur as little
technical debt on us as possible, we should not maintain any files on
the branch we are not actually using.
This has the added effect of making it extremely clear when merging CLs
from the main branch when changes have the possibility to affect us.
The follow-on CL adds a convenience script to actually pull updates from
the main branch and generate a CL for the update.
BUG=b:204206272
BRANCH=ish
TEST=make BOARD=arcada_ish && make BOARD=drallion_ish
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I17e4694c38219b5a0823e0a3e55a28d1348f4b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3262038
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use codeset 1 e01b(make)/ e09b(break) for MICMUTE.
Use codeset 1 e01e(make)/ e09e(break) for KBBL toggle.
BUG=b:194146863
BRANCH=none
TEST=make -j BOARD=gimble
Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Change-Id: Ide0873c32236ead87d661e36b5f9b20cfd78144b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3060242
Reviewed-by: Boris Mittelberg <bmbm@google.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recently some platform reported Search key and Power key stopped
working after enabling vivaldi. I suspect that this is because some of
the platforms are using the (row,col) reserved for T11-T15 keys for
non-top-row keys (e.g. Power, Search etc). Lets not disable any
unused vivaldi keys explicitly.
Signed-off-by: Rajat Jain <rajatja@google.com>
BUG=b:155852339,b:156201575,b:155941390
BRANCH=None
TEST=Tested search key on Jinlon (this was failing)
Change-Id: I3df3f57f4700e37b228951890b1621440031d6dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2194163
Reviewed-by: Jett Rink <jettrink@chromium.org>
Commit-Queue: Rajat Jain <rajatja@google.com>
Tested-by: Rajat Jain <rajatja@google.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable vivaldi for all boards with a default layout which is the
standard chromeos layout. THe default layout means the following keys
(in this order) in the top row:
BACK,
FORWARD,
REFRESH,
FULLSCREEN,
OVERVIEW,
BRIGHTNESS_DOWN,
BRIGHTNESS_UP,
MUTE,
VOL_DOWN,
VOL_UP
It also means no "Fn" key and screenlock key is present. Note that
if a board does not have the screenlock key physically, the omission of
screenlock key is now needed to comply with kernel requirement that only
those keys to be provided which are actually present on the keyboard. So
Any boards that actually do not have the screenlock key need to provide
set_vivaldi_keybd_config() function.
Also, any keyboards that have chosen to use the config for keyboard
customization have been left alone.
[Note: For this to work, a kernel with 3 atkbd patches ending at this
patchset is needed:
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2174387
These have been currently backported to 4.19 and 5.4 kernels]
BUG=b:146501925
TEST=Build
BRANCH=firmware-hatch-12672.B
Signed-off-by: Rajat Jain <rajatja@google.com>
Change-Id: I3c3596bd0eaf5241288473c27bcf61ba7da39593
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2142536
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the VolUp button location can vary now, take that into account.
Signed-off-by: Rajat Jain <rajatja@google.com>
BUG=b:146501925,b:154167876
TEST=TEst Alt + VolUp + r on Jinlon
BRANCH=firmware-hatch-12672.B
Change-Id: I4dbc8692f6418fd786e5d33053e8c368cc5529ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2151854
Commit-Queue: Rajat Jain <rajatja@google.com>
Tested-by: Rajat Jain <rajatja@google.com>
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Vivaldi is a new keyboard that allows individual boards to have
additional or different top row keys and/or to reorder those keys.
The primary agenda of vivaldi is to allow customization of the top
row keys. However, as a secondary objective, it also allows coreboot
to send a keymap to the kernel, for only the keys that are actually
present on the keyboard.
As part of enabling vivaldi, another feature that get enabled
is to start sending action codes instead of function codes for the top
row of the keyboard.
go/vivaldi-prd
go/vivaldi-design
go/vivaldi-fw-design
With this patch, things remain unchanged for any boards that do not provide
board_set_vivaldi_keybd_config(). For boards that do provide it:
* EC begins to send action scancodes instead of function scancodes for the
top row when top row keys are pressed.
* EC responds to an EC command from the coreboot, that asks for the
layout for the keyboard. Coreboot uses this to expose corresponding
keycodes to the kernel.
BUG=b:146501925
TEST=Check on Jinlon the (new) expected scancodes are output from EC.
BRANCH=firmware-hatch-12672.B
Signed-off-by: Rajat Jain <rajatja@google.com>
Change-Id: I1f45ce6eee138a984f8d4caef1ec76c9538dd30b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2135566
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts the current vivaldi code in favor of the soon-to-be-merged
new vivaldi framework. The current code is enabled on demand as it hides
behind CONFIG_VIVALDI. In its new form, vivaldi shall always be
enabled for all boards, as explained in go/vivaldi-fw-design.
Planning to land new code for Vivaldi in EC, so might be better to
start with clean slate.
BUG=b:146501925
TEST=Build
BRANCH=firmware-hatch-12672.B
Signed-off-by: Rajat Jain <rajatja@google.com>
Change-Id: I1b88d069a265ce59c2c36cf534b740a852745b67
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2133823
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove trailing "\n" from some debugs
* Rename 2 keys to make it more clear / reader friendly.
* Add a print for keyboard config for top keys on boot.
Signed-off-by: Rajat Jain <rajatja@google.com>
BRANCH=cros/firmware-hatch-12672.B
BUG=b:146589270
TEST=Test on Jinlon
Change-Id: I27691c697bbc26ad9cd5d3516e257110fe163df6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2124013
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
|
|
|
Vivaldi is a new keyboard that allows individual boards to have
additional or different top row keys and/or to reorder those keys.
go/vivaldi-prd
go/vivaldi-design
Add code to provide an API that individual boards that use the vivaldi
keyboard, that lets them define their board keyboard top row layout.
Some scan codes have been taken from
https://wiki.osdev.org/PS/2_Keyboard#Key_Codes.2C_Key_States_and_Key_Mappings
and ones that did not exist, have been allotted from (seemingly) free
holes in there.
BUG=b:146501925
TEST=Check on Jinlon the (new) expected scancodes are output from EC.
BRANCH=firmware-hatch-12672.B
Signed-off-by: Rajat Jain <rajatja@google.com>
Change-Id: Id6b854337958d99898175e7be7a9972938e32399
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2080603
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
|
