summaryrefslogtreecommitdiff
path: root/common/system.c
Commit message (Collapse)AuthorAgeFilesLines
* Revert "hostcmd: Remove EC_CMD_VBNV_CONTEXT handler for most boards"Mary Ruthven2021-11-181-3/+7
| | | | | | | | | | | | This reverts commit 6ba124a81bd6d5af1edae5f30add22e81b8b7de7. BUG=b:200823466 TEST=make buildall -j Change-Id: I4038924250569e3bb8b491ded4eef1a61f98a4bb Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273470 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system: Add support for emulated sysrq"Mary Ruthven2021-11-181-17/+0
| | | | | | | | | | | | This reverts commit 871bf8da2cf5fa9bcfe8771b96af4b55c2503616. BUG=b:200823466 TEST=make buildall -j Change-Id: I126176dcf85d4850213308f77eefb554454f50d0 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273469 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system: Fixups in emulated sysrq code"Mary Ruthven2021-11-181-1/+1
| | | | | | | | | | | | This reverts commit e3f5e6bf6ad2d1e2c283a75cf08e17155633e0a5. BUG=b:200823466 TEST=make buildall -j Change-Id: I60dbc01a5345a28fe759975f62a8d9216dcef7fe Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273468 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "Add system_can_boot_ap API"Mary Ruthven2021-11-181-6/+0
| | | | | | | | | | | | This reverts commit cdaca7c97eaefe93ab3a0148a954b2f139f5caad. BUG=b:200823466 TEST=make buildall -j Change-Id: I860b04167c3ab7335de63f561d31cf073cb5e897 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273461 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system: Allow sysjump command to jump to RW_B"Mary Ruthven2021-11-181-7/+1
| | | | | | | | | | | | This reverts commit d33618ce9f9a6b95632d0de3ebed1eca196cd982. BUG=b:200823466 TEST=make buildall -j Change-Id: Ib0424b6f13086771f4cddfc293dd7163bafbff71 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273458 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "vboot: Jump to RW early"Mary Ruthven2021-11-181-2/+6
| | | | | | | | | | | | This reverts commit 921e9b71258c318f364457d97a94d3fb9e1bbbfc. BUG=b:200823466 TEST=make buildall -j Change-Id: Ic168ce083509437ff729f41dc43784bd15913c55 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273457 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "Add OTP support"Mary Ruthven2021-11-181-32/+0
| | | | | | | | | | | | This reverts commit 1b25735b732e7766aceb3f060e4ca205aba6d358. BUG=b:200823466 TEST=make buildall -j Change-Id: I2e29902d7026c63f23871af0141a3ee7d319852d Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273456 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "coral: Add host command to fetch SKU ID"Mary Ruthven2021-11-181-16/+0
| | | | | | | | | | | | | | This reverts commit f747f70816ca825a4ff4f9c6234f97e93611dbaa. Nothing uses CONFIG_HOSTCMD_SKUID. Remove support. BUG=b:200823466 TEST=make buildall -j Change-Id: Iea545047659ab265025878c50986b74d1b3654b1 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273455 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "Treat SYSTEM_IMAGE_RW_B also as RW copy"Mary Ruthven2021-11-181-12/+2
| | | | | | | | | | | | This reverts commit 5da63f4ea2c93e6b059d8c50ff01dbe53a13dec2. BUG=b:200823466 TEST=make buildall -j Change-Id: Id035f3e4a107c00407c16cc878bd88da63f9de7f Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273451 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "common: add host command to push AP SKU ID to ec"Mary Ruthven2021-11-181-57/+1
| | | | | | | | | | | | This reverts commit a52cfbc80c060d9883aee9de4e764e0b250d184a. BUG=b:200823466 TEST=make buildall -j Change-Id: Ie3b003dcc8d7073b8ba3475d5a2651e5ffb2fd8b Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273450 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "EFS: Add support for early firmware selection"Mary Ruthven2021-11-181-35/+6
| | | | | | | | | | | | This reverts commit 4dcee1c545c31d288b23221d8e07bc452214ce7b. BUG=b:200823466 TEST=make buildall -j Change-Id: I5226e749decc26e1af05172353327a368610def3 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273449 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "EFS: Switch active slot when current slot is invalid"Mary Ruthven2021-11-181-38/+26
| | | | | | | | | | | | This reverts commit 729a4ba2bdc20675e24ed9e7d0a98d19934d72f8. BUG=b:200823466 TEST=make buildall -j Change-Id: I850e674c9bc347520effd97611878ea3e3153a56 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273448 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "EFS: Allow EC to switch slot on reboot"Mary Ruthven2021-11-181-11/+1
| | | | | | | | | | | | This reverts commit 220c75bd1626c656234d6121af8068c42ff182f8. BUG=b:200823466 TEST=make buildall -j Change-Id: I0f71ee2478cf4900b87e62101e7fb2ed2adba6cc Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273447 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "EFS: Sysjump to active copy"Mary Ruthven2021-11-181-1/+1
| | | | | | | | | | | | This reverts commit 20c94b726e548c47a5237d60ac78c6f1e166e97b. BUG=b:200823466 TEST=make buildall -j Change-Id: Ifd4e5c252c0b7d7475360d67a492866f6c88b33c Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273446 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "cortex-m: mpu: Support unaligned regions and protect code RAM"Mary Ruthven2021-11-181-23/+11
| | | | | | | | | | | | This reverts commit b6991dd96d8bf6cb86a39b3da590ccd8b4e1e036. BUG=b:200823466 TEST=make buildall -j Change-Id: Iad57119388644c5b3f3b667d92dbcb3f33efe7ab Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273443 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system: Add wait-ext option to ec reboot command"Mary Ruthven2021-11-181-27/+2
| | | | | | | | | | | | This reverts commit 071142fe688c05ef1ffd54057409995f12504c1d. BUG=b:200823466 TEST=make buildall -j Change-Id: Ic264ef02dfad13dafc437b6063d4d3dddf4d2b5c Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273442 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system: Allow hibernate to clear AP_OFF flag"Mary Ruthven2021-11-181-8/+0
| | | | | | | | | | | | This reverts commit 23149261dc4a9429a1c98aa829e02d4a3ec5103a. BUG=b:200823466 TEST=make buildall -j Change-Id: Ie27d454c485e9f2341bac9320b3ad629b96efe50 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273440 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system: Log PC and task id on watchdog"Mary Ruthven2021-11-181-12/+5
| | | | | | | | | | | | | | This reverts commit 0037fb8dfcd7136d40e608ad9973331bd82d9a80. Merge conflict RESET_FLAG_WATCHDOG renamed to EC_RESET_FLAG_WATCHDOG BUG=b:200823466 TEST=make buildall -j Change-Id: Icf366b474e54c66a01ed68b6650b60d234a14064 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273439 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system: update board version to return an error if encountered"Mary Ruthven2021-11-181-39/+16
| | | | | | | | | | | | This reverts commit ff9248fbaabef72761728140c2e65d0aa02dc17c. BUG=b:200823466 TEST=make buildall -j Change-Id: I22ffe8ff8bc88e88c21c285ed0cc3bed432d6463 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273428 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system: Enable/Disable low power idle in run time"Mary Ruthven2021-11-181-5/+0
| | | | | | | | | | | | This reverts commit 0de5b8ed695a420728ec7b606b218284b0241006. BUG=b:200823466 TEST=make buildall -j Change-Id: I2e7db1159403f56f9373dd51382921048be76560 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273422 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "ec/google: Add command to fetch keyboard ID from EC"Mary Ruthven2021-11-181-17/+0
| | | | | | | | | | | | This reverts commit 5d825c5c9b9b805b2677b13a891a7edce0802e69. BUG=b:200823466 TEST=make buildall -j Change-Id: I856c5ad66101815a0e180f5c6ca716563032e8c7 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273417 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system: Make hibernate console command invoke chipset task if ↵Mary Ruthven2021-11-181-21/+2
| | | | | | | | | | | | | | chipset is on" This reverts commit d5e08f7f0db8738b9e802b7029ece3410d22b943. BUG=b:200823466 TEST=make buildall -j Change-Id: I392e22d0325534a3c9ef62a15621c3d75d90b550 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273411 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* system: remove support for ap-watchdog resetMary Ruthven2021-11-181-1/+1
| | | | | | | | | | | | | | | | | This removes support for remembering if reset was due to AP watchdog triggering. It was originally added in 51a6070f845ed670c5a198a7045af3d3bb3bbdd4. RESET_FLAG_AP_WATCHDOG was renamed to EC_RESET_FLAG_AP_WATCHDOG and moved to ec_commands.h. This removes the flag. BUG=b:200823466 TEST=make buildall -j Change-Id: If6340bc7df0a2e06f85bd8ff11dd058e5547e784 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273408 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* i2c_controller: remove Protect TCPC I2C tunnels as part of ↵Mary Ruthven2021-11-181-32/+0
| | | | | | | | | | | | | | EC_REBOOT_DISABLE_JUMP This removes the support added in 9e4474e561ec165cf24e8aa249c2aeeed8e7f1ef. BUG=b:200823466 TEST=make buildall -j Change-Id: I81745d55783e69a345a41c55b126f196b20d952a Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273401 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "clock: define the function clock_enable_module to all EC chips"Mary Ruthven2021-11-181-10/+0
| | | | | | | | | | | | This reverts commit e7edd0ebedf85c13a1c97deb302c44655f4ca2d9. BUG=b:200823466 TEST=make buildall -j Change-Id: I0c7faf63415280788d88675ee216782888303ad0 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273396 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "USB PD: Re-discover port partner when a contract was in place"Mary Ruthven2021-11-181-5/+0
| | | | | | | | | | | | This reverts commit f8206fabf1cefaccd4e4393588ae2e3613bfb97d. BUG=b:200823466 TEST=make buildall -j Change-Id: I72b92488a38f65d73e76746e88f4efbc700ad5a5 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273389 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "util/ectool, common/system: Share sysmbol reset_flag_desc."Mary Ruthven2021-11-181-10/+10
| | | | | | | | | | | | This reverts commit 2b452718a0b2e08fad8e0a830b443db862bf806c. BUG=b:200823466 TEST=make buildall -j Change-Id: I968c8f0a2845f5a9baf2e2aa55e8efea6f637c4b Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273388 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "kukui_scp: Enable MPU to protect code RAM and data RAM in RW image."Mary Ruthven2021-11-181-1/+1
| | | | | | | | | | | | This reverts commit 4ffa4bb861612f9debffc9088bac72a1ac611ff5. BUG=b:200823466 TEST=make buildall -j Change-Id: Iff9ff470dfad735e37f0827843a84f389f49d44f Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273386 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "USB-PD: Consolidate tcpc_config declarations in usb_pd_tcpm.h"Mary Ruthven2021-11-181-0/+1
| | | | | | | | | | | | This reverts commit e69840b434035ae581e31a29efc1a333d0b390da. BUG=b:200823466 TEST=make buildall -j Change-Id: Id49158d639c7a8ee7be70efabe68a54341f19b99 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273380 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* i2c_controller: remove subcommand to protect all TCPC portsMary Ruthven2021-11-181-0/+31
| | | | | | | | | | | | This removes the support added in c23cced7340ba977e9aacb9af02b86ac5df7d347. BUG=b:200823466 TEST=make buildall -j Change-Id: I4a835d2be14453463ca85dd6332d53a83a1ea923 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273378 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "common: board_[read/write]_serial weak reference cleanup"Mary Ruthven2021-11-181-16/+22
| | | | | | | | | | | | This reverts commit 9e9c24307deb302ed969b268e97cebfa4061c79c. BUG=b:200823466 TEST=make buildall -j Change-Id: I434218b51404a831ce88c97c76e0e6d3a6d02bf2 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273377 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "common/system: refactor some confusing ifdefs"Mary Ruthven2021-11-181-20/+25
| | | | | | | | | | | | This reverts commit 3e1c72ea23fe3c37f5a4e4e8bceea38c0322ba31. BUG=b:200823466 TEST=make buildall -j Change-Id: I172b5fd55529754d913f4d18258beccac0bade58 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273364 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "cleanup: use STATIC_IF for hibernate variables"Mary Ruthven2021-11-181-15/+14
| | | | | | | | | | | | | | This reverts commit 7470bbfae198c0efd07ece8dceac714d8ad0a6ff. Merge conflict RESET_FLAG_AP_OFF renamed to EC_RESET_FLAG_AP_OFF BUG=b:200823466 TEST=make buildall -j Change-Id: I0230d964ea85ef8aba1de60a577cf811a11ade49 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273363 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "version: Make ver_get_num_commits work for on-flash images"Mary Ruthven2021-11-181-1/+2
| | | | | | | | | | | | This reverts commit 91d4fec4606e2145d522274c786d46d12721cf9a. BUG=b:200823466 TEST=make buildall -j Change-Id: I3859dd2069397eaeb8c6ae361c7663b32b53e01f Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273359 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system.c: move jump_data declarations into sysjump.h"Mary Ruthven2021-11-181-1/+30
| | | | | | | | | | | | This reverts commit 7b7f7b136e58429a8afd6f41ee11cd105baefeba. BUG=b:200823466 TEST=make buildall -j Change-Id: I4c59cfd7b53c2280e89e65ccac337bb92128b3a9 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273355 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system.c: reset statics for testing"Mary Ruthven2021-11-181-7/+0
| | | | | | | | | | | | This reverts commit 0038f1e0dfd6738d71e07de60a0240e449d3f787. BUG=b:200823466 TEST=make buildall -j Change-Id: Ic55769f733450c72d76533142ace06831c998b4c Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273193 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* coil: CONFIG_I2C_MASTER -> CONFIG_I2C_CONTROLLERMary Ruthven2021-01-071-1/+1
| | | | | | | | | | BUG=b:175244613 TEST=make buildall -j Change-Id: I74900cd9113c12e5e08a0770e30f3abf69816302 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2611757 Reviewed-by: Namyoon Woo <namyoon@chromium.org>
* coil: remove battery codeMary Ruthven2021-01-061-10/+0
| | | | | | | | | | | | | This code uses coil terms we're removing, but we don't use it in platform/cr50. Remove the code instead of replacing the terms. BUG=b:175244613 TEST=make buildall -j Change-Id: I15ffb2617d2dd4bedb809eeff858dcf0f6c8cf25 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2613140 Reviewed-by: Namyoon Woo <namyoon@chromium.org>
* coil: remove usbc, usb_pd, charge_manager, and tcpmMary Ruthven2021-01-061-34/+0
| | | | | | | | | | | | | This code uses coil terms we're removing, but we don't use it in platform/cr50. Remove the code instead of replacing the terms. BUG=b:175244613 TEST=make buildall -j Change-Id: Ia64e1ff4df941d2fe19e95e84dee8b743616aa88 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2613135 Reviewed-by: Namyoon Woo <namyoon@chromium.org>
* system: avoid printing one character at a timeVadim Bendebury2020-03-111-13/+35
| | | | | | | | | | | | | | | | | | | | With the upcoming transition to handling console traffic in packet mode it is very expensive to be shipping one character at a time, each character results in sending a packet of 16 or so bytes. This patch modifies print_build_string() such that it splits the long build version string into manageable substrings and prints them instead of printing one character at a time. BRANCH=cr50, cr50-mp BUG=b:149964350 TEST=built a Cr50 image, verified that build string is printed as expected. Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Change-Id: I743205932892b0f14c161ade5ea856a658fb26e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2097444 Reviewed-by: Mary Ruthven <mruthven@chromium.org>
* Add a board specific helper to return USB PD port countKarthikeyan Ramasubramanian2019-11-091-1/+1
| | | | | | | | | | | | | | | | | | | | | Certain SKUs of certain boards have less number of USB PD ports than configured in CONFIG_USB_PD_PORT_MAX_COUNT. Hence define an overrideable board specific helper to return the number of USB PD ports. This helps to avoid initiating a PD firmware update in SKUs where there are less number of USB PD ports. Also update charge manager to ensure that absent/ invalid PD ports are skipped during port initialization and management. BUG=b:140816510, b:143196487 BRANCH=octopus TEST=make -j buildall; Boot to ChromeOS in bobba(2A + 2C config) and garg(2A + 1C + 1HDMI config). Change-Id: Ie345cef470ad878ec443ddf4797e5d17cfe1f61e Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1879338 Tested-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Karthikeyan Ramasubramanian <kramasub@chromium.org>
* Rename CONFIG_USB_PD_PORT_COUNT as CONFIG_USB_PD_PORT_MAX_COUNTKarthikeyan Ramasubramanian2019-11-011-1/+2
| | | | | | | | | | | | | | | | | Certain SKUs of certain boards have lesser number of USB PD ports than defined by CONFIG_USB_PD_PORT_COUNT. Hence rename CONFIG_USB_PD_PORT_COUNT as CONFIG_USB_PD_PORT_MAX_COUNT. BUG=b:140816510, b:143196487 BRANCH=octopus TEST=make -j buildall; Boot to ChromeOS Change-Id: I7c33b27150730a1a3b5813b7b4a72fd24ab73c6a Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1879337 Tested-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Jett Rink <jettrink@chromium.org>
* system.c: reset statics for testingCaveh Jalali2019-10-311-0/+7
| | | | | | | | | | | | | | | | | | | | this adds a function to reset the state information generated by system_common_pre_init() for testing scenarios that need to call it multiple times. on the EC, main memory (.data + .bss) is reinitialized across sysjumps, so this happens automatically, but we can't really do that from unit tests. so, add a function to reset the relevant static variables to emulate main memory getting reinitialized. BRANCH=none BUG=b:142031466 TEST=make buildall passes Change-Id: I1f65902c21ab6fc17c32388795cfef19c84d8cc8 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1855644 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* system.c: move jump_data declarations into sysjump.hCaveh Jalali2019-10-231-29/+1
| | | | | | | | | | | | | | | this moves the jump_data related declarations out of system.c into a dedicated sysjump_impl.h header file. this will make it possible to implement unit tests for sysjump. BRANCH=none BUG=b:142031466 TEST=make buildall passes Change-Id: I7df3d24e1f9c0f203656ee8dddc234b64e2dc8c3 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1855647 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* Remove uses of %lEvan Green2019-10-051-3/+3
| | | | | | | | | | | | | | | | | | | | | | | This change removes uses of %l from the EC side of the EC codebase. This is done because the semantics of %l within printf have changed, and there are concerns that new calls to printf will be cherry-picked into old firmware branches without the printf changes. So, in preparation for disallowing %l in master, remove occurrences of %l. This change was done by manually fixing up anything found under the EC directory with the following regex: %[0-9*.-]*l[^l] Remember that anything on the host machine is fine as-is, since the host printf never changed. BUG=chromium:984041 TEST=make -j buildall BRANCH=None Change-Id: I2a97433ddab5bfb8a6031ca4ff1d3905289444e2 Signed-off-by: Evan Green <evgreen@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1834603 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* printf: Fix formatting errorsEvan Green2019-10-051-2/+3
| | | | | | | | | | | | | | | | | | | This change fixes the printf formatting errors found by the compile-time prinf format checker. The errors fall into a few categories: 1. Incorrect size specifier (missing or extra l). 2. Missing or extra arguments. 3. Bad line splitting. BUG=chromium:984041 TEST=make -j buildall BRANCH=none Change-Id: I5618097a581210b9fcbfc81560dec050ae30b61c Signed-off-by: Evan Green <evgreen@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1819653 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* host_command: Change host command return value to enum ec_statusTom Hughes2019-10-021-9/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the host command handler callback function returns an int, it's easy to accidentally mix up the enum ec_error_list and enum ec_status types. The host commands always expect an enum ec_status type, so we change the return value to be of that explicit type. Compilation will then fail if you accidentally try to return an enum ec_error_list value. Ran the following commands and then manually fixed up a few remaining instances that were not caught: git grep --name-only 'static int .*(struct host_cmd_handler_args \*args)' |\ xargs sed -i 's#static int \(.*\)(struct host_cmd_handler_args \*args)#\ static enum ec_status \1(struct host_cmd_handler_args \*args)##' git grep --name-only 'int .*(struct host_cmd_handler_args \*args)' |\ xargs sed -i 's#int \(.*\)(struct host_cmd_handler_args \*args)#\ enum ec_status \1(struct host_cmd_handler_args \*args)##' BRANCH=none BUG=chromium:1004831 TEST=make buildall -j Cq-Depend: chrome-internal:1872675 Change-Id: Id93df9387ac53d016a1594dba86c6642babbfd1e Signed-off-by: Tom Hughes <tomhughes@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1816865 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* version: Make ver_get_num_commits work for on-flash imagesDaisuke Nojiri2019-09-211-2/+1
| | | | | | | | | | | | | | | | | | | | | | EFS needs to check whether a RW version on flash is equal to or newer for rollback protection before jumping to a RW copy. Currently, ver_get_numcommits works only for the running image. This makes it work for images on flash as well. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=chromium:998135 BRANCH=none TEST=Boot Nami. Verify version numbers are read from RAM and flash. Change-Id: I94475e40f89dc4c3173d83cb1d9d4ad38d6fab79 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1450816 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
* include: Move RESET_FLAG_* into ec_commands.h as EC_RESET_FLAG_*You-Cheng Syu2019-08-261-8/+9
| | | | | | | | | | | | | | | | | | | | | | | RESET_FLAGS_* are used when setting/reading the field ec_reset_flags of struct ec_response_uptime_info, which is defined in ec_commands.h. So it might be better to put those macros there. To be consistent with the other macros in the file, add "EC_" prefixes to them. BUG=b:109900671,b:118654976 BRANCH=none TEST=make buildall -j Cq-Depend: chrome-internal:1054910, chrome-internal:1054911, chrome-internal:1045539 Change-Id: If72ec25f1b34d8d46b74479fb4cd09252102aafa Signed-off-by: You-Cheng Syu <youcheng@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1520574 Tested-by: Yu-Ping Wu <yupingso@chromium.org> Commit-Ready: Yu-Ping Wu <yupingso@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Yilun Lin <yllin@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
* cleanup: use STATIC_IF for hibernate variablesJack Rosenthal2019-08-201-12/+14
| | | | | | | | | | | | | | | | This is an example usage of STATIC_IF, as a child CL of the STATIC_IF implementation. BUG=chromium:989786 BRANCH=none TEST=buildall Change-Id: I1e69bf85a3daf8aa5f5c0e0b1da9808a8a5f8649 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1731972 Reviewed-by: Raul E Rangel <rrangel@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Raul E Rangel <rrangel@chromium.org>
View Lorry Controller Status