summaryrefslogtreecommitdiff
path: root/common
Commit message (Collapse)AuthorAgeFilesLines
...
* Revert "timer: Allow disabling gettime console command"Mary Ruthven2021-11-181-2/+0
| | | | | | | | | | | | This reverts commit db24bed78d6274def74f0a764a29a9ea1e2feb71. BUG=b:200823466 TEST=make buildall -j Signed-off-by: Mary Ruthven <mruthven@chromium.org> Change-Id: I964cc91b08bfe5b909ba3a7e4410bf851dfc3e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273424 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "rsa: Further optimization of multiplications for Cortex-M0"Mary Ruthven2021-11-181-3/+3
| | | | | | | | | | | | This reverts commit ecd0d1b5767c829f4c73a79a9eb6abae343284fb. BUG=b:200823466 TEST=make buildall -j Change-Id: I1229e86f015e1a04ee8026abd2f647d6039125fd Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273423 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system: Enable/Disable low power idle in run time"Mary Ruthven2021-11-181-5/+0
| | | | | | | | | | | | This reverts commit 0de5b8ed695a420728ec7b606b218284b0241006. BUG=b:200823466 TEST=make buildall -j Change-Id: I2e7db1159403f56f9373dd51382921048be76560 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273422 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "stm32: use D-cache on STM32H7"Mary Ruthven2021-11-181-3/+2
| | | | | | | | | | | | This reverts commit eee7778fcfc5e555d119cff65caa7c045343e356. BUG=b:200823466 TEST=make buildall -j Change-Id: Ic244080354abc6da267c618b7c4d799b21b67042 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273420 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "ec/google: Add command to fetch keyboard ID from EC"Mary Ruthven2021-11-182-38/+0
| | | | | | | | | | | | This reverts commit 5d825c5c9b9b805b2677b13a891a7edce0802e69. BUG=b:200823466 TEST=make buildall -j Change-Id: I856c5ad66101815a0e180f5c6ca716563032e8c7 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273417 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "uart_buffering: expose interface to support non-host command"Mary Ruthven2021-11-181-64/+47
| | | | | | | | | | | | This reverts commit 3f19d870f81f062410e30d166848d47a2a20e5d9. BUG=b:200823466 TEST=make buildall -j Change-Id: I0c6f63c96d23959a2bd63d6a27d6e4f0efa1cc5c Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273414 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "common: add BASE_CHANGE hook"Mary Ruthven2021-11-181-1/+0
| | | | | | | | | | | | This reverts commit af908bfce225415c01d56b3f57cfc399d8485d3e. BUG=b:200823466 TEST=make buildall -j Change-Id: I36277d725500101097ad45a55173877688848797 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273413 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system: Make hibernate console command invoke chipset task if ↵Mary Ruthven2021-11-181-21/+2
| | | | | | | | | | | | | | chipset is on" This reverts commit d5e08f7f0db8738b9e802b7029ece3410d22b943. BUG=b:200823466 TEST=make buildall -j Change-Id: I392e22d0325534a3c9ef62a15621c3d75d90b550 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273411 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "tcpm:it83xx: GRL-USB-PD TDA2.1.2.2 BIST test"Mary Ruthven2021-11-181-1/+0
| | | | | | | | | | | | This reverts commit 09d4918f464b69390f0c2d12cdd8c6aeafcb2cae. BUG=b:200823466 TEST=make buildall -j Change-Id: Ia3384f0334516dd8b6b01cc78c3dac42128d5752 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273410 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* system: remove support for ap-watchdog resetMary Ruthven2021-11-181-1/+1
| | | | | | | | | | | | | | | | | This removes support for remembering if reset was due to AP watchdog triggering. It was originally added in 51a6070f845ed670c5a198a7045af3d3bb3bbdd4. RESET_FLAG_AP_WATCHDOG was renamed to EC_RESET_FLAG_AP_WATCHDOG and moved to ec_commands.h. This removes the flag. BUG=b:200823466 TEST=make buildall -j Change-Id: If6340bc7df0a2e06f85bd8ff11dd058e5547e784 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273408 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "util: add isupper() library function"Mary Ruthven2021-11-181-5/+0
| | | | | | | | | | | | This reverts commit 2a040ce6429b59ea27dd5c3d0ae9e2bf12dc2c90. BUG=b:200823466 TEST=make buildall -j Change-Id: I1500ae932d9d531c6ef81b0d2e0ff7159a6fe959 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273407 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* i2c_controller: remove Protect TCPC I2C tunnels as part of ↵Mary Ruthven2021-11-182-42/+2
| | | | | | | | | | | | | | EC_REBOOT_DISABLE_JUMP This removes the support added in 9e4474e561ec165cf24e8aa249c2aeeed8e7f1ef. BUG=b:200823466 TEST=make buildall -j Change-Id: I81745d55783e69a345a41c55b126f196b20d952a Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273401 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "UART: Add uart_put API"Mary Ruthven2021-11-181-14/+0
| | | | | | | | | | | | This reverts commit b937f5c5b2bd54323b91f38be9650c975b00618c. BUG=b:200823466 TEST=make buildall -j Change-Id: I4980727049ca282ed82c45ed674eb7900f3665a5 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273400 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "UART: Export uart_clear_input API"Mary Ruthven2021-11-181-8/+0
| | | | | | | | | | | | This reverts commit 0e23368429f931b8ead7abc1ac63aa0f96f51565. BUG=b:200823466 TEST=make buildall -j Change-Id: Iacebe12446fb4d734e987c13850c4f8afde8f56a Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273399 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "clock: define the function clock_enable_module to all EC chips"Mary Ruthven2021-11-181-10/+0
| | | | | | | | | | | | This reverts commit e7edd0ebedf85c13a1c97deb302c44655f4ca2d9. BUG=b:200823466 TEST=make buildall -j Change-Id: I0c7faf63415280788d88675ee216782888303ad0 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273396 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "USB PD: Re-discover port partner when a contract was in place"Mary Ruthven2021-11-181-5/+0
| | | | | | | | | | | | This reverts commit f8206fabf1cefaccd4e4393588ae2e3613bfb97d. BUG=b:200823466 TEST=make buildall -j Change-Id: I72b92488a38f65d73e76746e88f4efbc700ad5a5 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273389 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "util/ectool, common/system: Share sysmbol reset_flag_desc."Mary Ruthven2021-11-181-10/+10
| | | | | | | | | | | | This reverts commit 2b452718a0b2e08fad8e0a830b443db862bf806c. BUG=b:200823466 TEST=make buildall -j Change-Id: I968c8f0a2845f5a9baf2e2aa55e8efea6f637c4b Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273388 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "kukui_scp: Enable MPU to protect code RAM and data RAM in RW image."Mary Ruthven2021-11-181-1/+1
| | | | | | | | | | | | This reverts commit 4ffa4bb861612f9debffc9088bac72a1ac611ff5. BUG=b:200823466 TEST=make buildall -j Change-Id: Iff9ff470dfad735e37f0827843a84f389f49d44f Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273386 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "ish: preserve panic data across reset"Mary Ruthven2021-11-181-1/+0
| | | | | | | | | | | | This reverts commit c1b08cd1b240332abfac339823a7468f52ff843d. BUG=b:200823466 TEST=make buildall -j Change-Id: I441ac60c2767c2160ee05a5dd582a43f7bed9fc4 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273385 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "USB-PD: Add hook for PD connect event"Mary Ruthven2021-11-181-1/+0
| | | | | | | | | | | | This reverts commit 608e6a4ca4a8cb46004db986f8b71c81b99b7786. BUG=b:200823466 TEST=make buildall -j Change-Id: Ic09ce1d4e796f2a742ed6c16473c1789b6a6087d Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273384 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "Align behavior of strtoi() and strtoul() to match Linux manpage ↵Mary Ruthven2021-11-181-31/+28
| | | | | | | | | | | | | | description of strtol()." This reverts commit ac8a13329b0b321daeb87f6afb79c163beb21372. BUG=b:200823466 TEST=make buildall -j Change-Id: I379e5fc1ebd15030715561732ea71eb6fda8406d Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273383 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "queue.h: Check at compile time if queue size is power of 2"Mary Ruthven2021-11-181-0/+1
| | | | | | | | | | | | This reverts commit 932e8400412f5c9d0cbad467c3f486036727620b. BUG=b:200823466 TEST=make buildall -j Change-Id: I90863bd8910090e8ee90356ae7b0344f10c1d321 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273382 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "USB-PD: Consolidate tcpc_config declarations in usb_pd_tcpm.h"Mary Ruthven2021-11-181-0/+1
| | | | | | | | | | | | This reverts commit e69840b434035ae581e31a29efc1a333d0b390da. BUG=b:200823466 TEST=make buildall -j Change-Id: Id49158d639c7a8ee7be70efabe68a54341f19b99 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273380 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* i2c_controller: remove subcommand to protect all TCPC portsMary Ruthven2021-11-182-9/+32
| | | | | | | | | | | | This removes the support added in c23cced7340ba977e9aacb9af02b86ac5df7d347. BUG=b:200823466 TEST=make buildall -j Change-Id: I4a835d2be14453463ca85dd6332d53a83a1ea923 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273378 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "common: board_[read/write]_serial weak reference cleanup"Mary Ruthven2021-11-181-16/+22
| | | | | | | | | | | | This reverts commit 9e9c24307deb302ed969b268e97cebfa4061c79c. BUG=b:200823466 TEST=make buildall -j Change-Id: I434218b51404a831ce88c97c76e0e6d3a6d02bf2 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273377 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "common: queue: Update chunk struct and get read/write logic"Mary Ruthven2021-11-181-15/+9
| | | | | | | | | | | | This reverts commit b4f1c3ca375f6e3c50edae12c1713236a0bcd2cc. BUG=b:200823466 TEST=make buildall -j Change-Id: Ida5142d256633e24ca9c59fcd82dfc37bf207b96 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273376 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "common: Add EC_CMD_LOCATE_CHIP"Mary Ruthven2021-11-183-45/+29
| | | | | | | | | | | | | | This reverts commit 1cb4329139b988153f8c20e69c23ba8214257c79. Merge conflict in include/ec_commands.h BUG=b:200823466 TEST=make buildall -j Change-Id: Ib6ce3ce8c892ce16268565eaeba784c385c020e8 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273375 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "minute-ia: ish software panic"Mary Ruthven2021-11-181-26/+0
| | | | | | | | | | | | This reverts commit c89e3557f808c504d8feece4d28a96450089b05f. BUG=b:200823466 TEST=make buildall -j Change-Id: I8c014d8163cc3b12e09d31aafe09cd0699027860 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273374 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "mt_scp: Add support to store some code in DRAM"Mary Ruthven2021-11-182-17/+0
| | | | | | | | | | | | This reverts commit d7579bd4589d08eeabf7c01f055b925acb7aed67. BUG=b:200823466 TEST=make buildall -j Change-Id: I442a932753e8a4745ac5002c165cf9309cb770ff Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273369 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "core: Allow .bss and .data sections in DRAM"Mary Ruthven2021-11-181-10/+0
| | | | | | | | | | | | This reverts commit 0528c46598c8c89f04b7129722de50e178b62aa2. BUG=b:200823466 TEST=make buildall -j Change-Id: I7777cf51e2fee18975ae8267df9af4d2ac266de8 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273368 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "common: provide config option for 64-bit hwtimer"Mary Ruthven2021-11-181-68/+27
| | | | | | | | | | | | This reverts commit c6aa7a384d179128339068531f79baed3a42ceef. BUG=b:200823466 TEST=make buildall -j Change-Id: Ibc096077dec6d2f454dab91a2db545d6c5325903 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273367 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "uart_buffering: add tx_buffer_full() API"Mary Ruthven2021-11-181-5/+0
| | | | | | | | | | | | This reverts commit 88f6aafde91413eebca7d9c856fcca194b92f873. BUG=b:200823466 TEST=make buildall -j Change-Id: If48f26e3e3466db4ce566e6eaa04e763a0664530 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273366 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "rollback: Add rollback support for chips with varying flash bank sizes"Mary Ruthven2021-11-181-51/+4
| | | | | | | | | | | | This reverts commit bd3ae0748e7dd84c5c0b3fa2387062a4ba4ea3a3. BUG=b:200823466 TEST=make buildall -j Change-Id: Id075da3dfe4973458a4de55cabf8c8988c8ba4fa Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273365 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "common/system: refactor some confusing ifdefs"Mary Ruthven2021-11-181-20/+25
| | | | | | | | | | | | This reverts commit 3e1c72ea23fe3c37f5a4e4e8bceea38c0322ba31. BUG=b:200823466 TEST=make buildall -j Change-Id: I172b5fd55529754d913f4d18258beccac0bade58 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273364 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "cleanup: use STATIC_IF for hibernate variables"Mary Ruthven2021-11-181-15/+14
| | | | | | | | | | | | | | This reverts commit 7470bbfae198c0efd07ece8dceac714d8ad0a6ff. Merge conflict RESET_FLAG_AP_OFF renamed to EC_RESET_FLAG_AP_OFF BUG=b:200823466 TEST=make buildall -j Change-Id: I0230d964ea85ef8aba1de60a577cf811a11ade49 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273363 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "common: change clksrc_high to use STATIC_IF_NOT"Mary Ruthven2021-11-181-2/+10
| | | | | | | | | | | | This reverts commit 7451ab9eb90b8042d01ca0b68f5a0fef63a7e96c. BUG=b:200823466 TEST=make buildall -j Change-Id: Ib87cd7aa135304567070b3f3b2a19441affa126f Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273362 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "log: Preserve Kukui EC reset logs across every EC reboot on SRAM."Mary Ruthven2021-11-183-73/+5
| | | | | | | | | | | | This reverts commit 2fb1836646a1f4edcea1f22408535872b833d14e. BUG=b:200823466 TEST=make buildall -j Change-Id: Ibdbc83a51863b02937f3c9ba1db4b4adce9db4f7 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273361 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "version: Make ver_get_num_commits work for on-flash images"Mary Ruthven2021-11-182-29/+17
| | | | | | | | | | | | This reverts commit 91d4fec4606e2145d522274c786d46d12721cf9a. BUG=b:200823466 TEST=make buildall -j Change-Id: I3859dd2069397eaeb8c6ae361c7663b32b53e01f Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273359 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "utils: Add strstr"Mary Ruthven2021-11-181-25/+0
| | | | | | | | | | | | This reverts commit 620b7164dddf12df27d5380d647c921853c036dc. BUG=b:200823466 TEST=make buildall -j Change-Id: Ifdd8baeff50d7be572826057ad6419038f17bd61 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273358 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "kukui_scp: support CONFIG_PRESERVE_LOGS"Mary Ruthven2021-11-181-2/+1
| | | | | | | | | | | | This reverts commit 99d0d6e76c6c9e566a664bdb76f2e3c6db221cbd. BUG=b:200823466 TEST=make buildall -j Change-Id: Ia431f76fbd5c2fbc648803105d0d801084843349 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273356 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system.c: move jump_data declarations into sysjump.h"Mary Ruthven2021-11-181-1/+30
| | | | | | | | | | | | This reverts commit 7b7f7b136e58429a8afd6f41ee11cd105baefeba. BUG=b:200823466 TEST=make buildall -j Change-Id: I4c59cfd7b53c2280e89e65ccac337bb92128b3a9 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273355 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "system.c: reset statics for testing"Mary Ruthven2021-11-181-7/+0
| | | | | | | | | | | | This reverts commit 0038f1e0dfd6738d71e07de60a0240e449d3f787. BUG=b:200823466 TEST=make buildall -j Change-Id: Ic55769f733450c72d76533142ace06831c998b4c Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273193 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "Cleanup: Correct GPIO alternate function parameter"Mary Ruthven2021-11-182-6/+5
| | | | | | | | | | | | This reverts commit 3b390264a415ce121a8c6f8db9fa9c42c647aaec. BUG=b:200823466 TEST=make buildall -j Change-Id: If339cc98bd345a8bb5994bf2b541ff3ee2420be6 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273192 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "Rename CONFIG_USB_PD_PORT_COUNT as CONFIG_USB_PD_PORT_MAX_COUNT"Mary Ruthven2021-11-182-3/+3
| | | | | | | | | | | | This reverts commit 9577704f30c7e824c0590264df22d95a2c706575. BUG=b:200823466 TEST=make buildall -j Change-Id: I0784c57d1bde04cb4df97993429aa9a92844d35c Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273191 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* Revert "Add a board specific helper to return USB PD port count"Mary Ruthven2021-11-182-3/+3
| | | | | | | | | | | | This reverts commit 27db31e6d02a54d5706d8cb4d1b5db6ff757f659. BUG=b:200823466 TEST=make buildall -j Change-Id: Ief51c2d7625d3f0cb8f6ca016db5cc645af97672 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273188 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* remove rollbackMary Ruthven2021-11-102-530/+0
| | | | | | | | | | | | Cr5* boards don't use it. Remove it. BUG=b:200823466 TEST=make buildall -j Change-Id: I64192bbfc51c5f6945a1b4b6dcca4e3b77142741 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3273181 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
* ap_ro_verification: do not fail if verification is not supportedstabilize-14312.B-cr50_stabVadim Bendebury2021-10-251-58/+109
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The decision of when to refuse to boot the device needs to be refined. We should never allow booting a device which ever passed a V2 verification. To reliably keep track of successful V2 validations in the past let's allocate a word in the INFO space which is write only, once written to 0 it will never change, value of 0 will be the indication of previous V2 verification success. The below table describes when booting should be allowed or blocked. Cache GSCVD Verification | version present Info result | Block boot --------- --------- ------ --------------|------------------ none no 0 n/a | yes none no 1 n/a | no none yes n/a fail | yes none yes n/a pass | no, update cache, info v1 n/a n/a pass | no v1 n/a n/a fail | check v2 v2 n/a n/a fail | yes v2 yes n/a pass | no This patch implements the above table, fixing the case where Cr50 was refusing to boot if neither local cache nor AP flash structures were present. BUG=b:203212461, b:141191727 TEST=tried running AP RO verification on a device without local cache and RO_GSCVD not in AP flash. The device booted successfully. Verified that both V1 and V2 validation works as expected, and fallback from V1 to V2 happens if V1 fails and RO_GSCVD is found in AP flash. Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Change-Id: I1f64123a3631932d142662a76deaf6ef6fee47fa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3229981 Reviewed-by: Andrey Pronin <apronin@chromium.org>
* ap_ro_integrity_check: add a ccd capability for the ap ro check vcMary Ruthven2021-10-211-7/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use a ccd capability to restrict the VENDOR_CC_AP_RO_VALIDATE vendor command from the AP. The AP should not be able to trigger the AP RO check in normal mode. Restrict the command, so it's only available when cr50 is in factory mode or the ccd capability is available. This doesn't restrict VENDOR_CC_AP_RO_VALIDATE when it's called from the ALT_IF interface. The button combo uses the ALT_IF interface, so it always needs to be available. If the command is from usb, it's still rejected in extension.c BUG=b:141191727 TEST=manual trigger from usb verify extension.c rejects the command [3364.881973 extension_route_command: ignore 58: usb] trigger with the button combo. Verify it's allowed even when the ccd capability is not enabled. Lock ccd. Verify the command from the AP is rejected Error 7 trigger ap ro validate Open ccd. Verify the command from the AP works Change-Id: I3f644698deed38779e5fee82156e5077290c7d4f Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3237200 Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
* ap_ro_verification: do not stop on failing FMAPsVadim Bendebury2021-10-191-101/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To prevent denial of service attack when a fake FMAP structure is placed somewhere in the AP flash, then detected by the GSC and rejected as corrupted, do not stop after finding an FMAP which includes a pointer to a GVD which fails to verify. This means the entire flash needs to be scanned, so this patch eliminates the approach where the flash is scanned at decreasing intervals until an FMAP section is found. Check all locations at 4K aligned addresses instead and keep looking until a valid GVD is located or the entire flash is scanned. Also fixed some comments and simplified code: there is no need for looking for the FMAP area entry in the FMAP, the offset of FMAP is already known. BUG=b:141191727 TEST=created a fake FMAP entry placed into the RW_A space of a guybrush image, with a corrupted GVD, programmed the modified image on a guybrush and attempted AP RO verification. Observed the GSC report the inconsistent GVD contents and then find the proper GVD structure in a different FMAP structure, and successfully validate the GVD structure. Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Change-Id: Ic8a930af63e1b90343d8cae6a86e65b06decebfb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3224810 Reviewed-by: Andrey Pronin <apronin@chromium.org>
* ap_ro_verification: rework to match the new GVD layoutVadim Bendebury2021-10-191-145/+140
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As a result of further discussion GVD layout has been changed to include signature and root key headers in the GVD header. This patch makes modification to accommodate the new header structure. BUG=b:141191727 TEST=A guybrush RO image created in vboot reference tree as follows: build/futility/futility vbutil_keyblock --pack ~/tmp/packed \ --datapubkey tests/devkeys/firmware_data_key.vbpubk \ --signprivate tests/devkeys/kernel_subkey.vbprivk build/futility/futility gscvd --outfile ~/tmp/guybrush-signed \ -R 818100:10000,f00000:100,f80000:2000,f8c000:1000 \ -k ~/tmp/packed -p tests/devkeys/firmware_data_key.vbprivk \ -b 5a5a4352 -r tests/devkeys/kernel_subkey.vbpubk \ ~/tmp/image-guybrush.serial.bin A guybrush device was programmed with ~/tmp/guybrush-signed, and AP RO verification was attempted by pressing the appropriate button combination, GVD verification succeeded. Generate a signed image again, using an incorrect Board ID value, try verification, observe failure due to incorrect Board ID. Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Change-Id: I4da753649eef6e10353619e0f7af19d2f6846b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3224808 Reviewed-by: Andrey Pronin <apronin@chromium.org> Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
View Lorry Controller Status