summaryrefslogtreecommitdiff
path: root/docs/code_reviews.md
Commit message (Collapse)AuthorAgeFilesLines
* ish: Trim down the release branchstabilize-wristpin-14469.59.B-ishstabilize-voshyr-14637.B-ishstabilize-quickfix-14695.187.B-ishstabilize-quickfix-14695.124.B-ishstabilize-quickfix-14526.91.B-ishstabilize-14695.85.B-ishstabilize-14695.107.B-ishstabilize-14682.B-ishstabilize-14633.B-ishstabilize-14616.B-ishstabilize-14589.B-ishstabilize-14588.98.B-ishstabilize-14588.14.B-ishstabilize-14588.123.B-ishstabilize-14536.B-ishstabilize-14532.B-ishstabilize-14528.B-ishstabilize-14526.89.B-ishstabilize-14526.84.B-ishstabilize-14526.73.B-ishstabilize-14526.67.B-ishstabilize-14526.57.B-ishstabilize-14498.B-ishstabilize-14496.B-ishstabilize-14477.B-ishstabilize-14469.9.B-ishstabilize-14469.8.B-ishstabilize-14469.58.B-ishstabilize-14469.41.B-ishstabilize-14442.B-ishstabilize-14438.B-ishstabilize-14411.B-ishstabilize-14396.B-ishstabilize-14395.B-ishstabilize-14388.62.B-ishstabilize-14388.61.B-ishstabilize-14388.52.B-ishstabilize-14385.B-ishstabilize-14345.B-ishstabilize-14336.B-ishstabilize-14333.B-ishrelease-R99-14469.B-ishrelease-R98-14388.B-ishrelease-R102-14695.B-ishrelease-R101-14588.B-ishrelease-R100-14526.B-ishfirmware-cherry-14454.B-ishfirmware-brya-14505.B-ishfirmware-brya-14505.71.B-ishfactory-kukui-14374.B-ishfactory-guybrush-14600.B-ishfactory-cherry-14455.B-ishfactory-brya-14517.B-ishJack Rosenthal2021-11-051-54/+0
| | | | | | | | | | | | | | | | | | | | | | In the interest of making long-term branch maintenance incur as little technical debt on us as possible, we should not maintain any files on the branch we are not actually using. This has the added effect of making it extremely clear when merging CLs from the main branch when changes have the possibility to affect us. The follow-on CL adds a convenience script to actually pull updates from the main branch and generate a CL for the update. BUG=b:204206272 BRANCH=ish TEST=make BOARD=arcada_ish && make BOARD=drallion_ish Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I17e4694c38219b5a0823e0a3e55a28d1348f4b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3262038 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* docs: replace "master" with "HEAD" in URLsTom Hughes2021-09-281-1/+1
| | | | | | | | | | | | | | find . -name '*.md' | xargs sed -i 's#refs/heads/master#HEAD#g' find . -name '*.md' | xargs sed -i 's#+/master#+/HEAD#g' BRANCH=none BUG=none TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Iaac99ddc3463c8c7bb08038214e3eb22951db6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3188552 Reviewed-by: Diana Z <dzigterman@chromium.org>
* docs: Run mdformat on all .md filesTom Hughes2021-01-281-3/+3
| | | | | | | | | | | BRANCH=none BUG=b:178648877 TEST=view in gitiles Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I0ac5581ba7bc512234d40dbf34222422afa9c725 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2650551 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* docs: Remove firmware code review guidelinesAbe Levkoy2020-04-271-102/+7
| | | | | | | | | | | | | | They have moved to the top-level docs directory. BUG=none TEST=Viewed rendered Markdown BRANCH=none Cq-Depend: chromium:2145046 Change-Id: Ibd140549b4b008448589abcb83b6120dca4ef642 Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2145080 Reviewed-by: Jett Rink <jettrink@chromium.org>
* code_reviews: Add an example of CLs linked by topicAbe Levkoy2020-03-201-1/+3
| | | | | | | | | | | | BUG=none TEST=View rendered Markdown BRANCH=none Change-Id: Icabde60da7758d89ab11abe11d5870f25fda4209 Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2108862 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* docs: Update code review guidelines with feedbackAbe Levkoy2020-03-101-4/+9
| | | | | | | | | | | | | | | Remove optional ways to indicate WIP to avoid confusion. Add a 1-business-day response SLO for reviewers. BUG=none TEST=Viewed rendered Markdown BRANCH=none Change-Id: I74411cebf6d51886f845122886fa56c8732336e6 Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2095749 Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Jett Rink <jettrink@chromium.org>
* code_review: add 's' to --no-email optionJett Rink2020-03-101-2/+2
| | | | | | | | | | | | | According to `repo help upload`, the option should be --no-emails instead of --no-email. BRANCH=none BUG=none TEST=`repo upload --no-emails` works Signed-off-by: Jett Rink <jettrink@chromium.org> Change-Id: I72b6d2b01e75864ea3223763fd2c8d463f2b5919 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2095948
* docs: Add code-review guidelinesAbe Levkoy2020-02-271-0/+108
| | | | | | | | | | | | | | | | | These should help code reviews go more smoothly. They are the consensus position of an out-of-band discussion among EC developers. BUG=none TEST=Observed rendered MD BRANCH=none Change-Id: I3b5e31a00481cc43732f5399c80a1ec82fec05b4 Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2062761 Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Jett Rink <jettrink@chromium.org>
* docs: Minor formatting fixesAbe Levkoy2020-02-251-5/+6
| | | | | | | | | | | | BUG=none TEST=Observed rendered MD BRANCH=none Change-Id: Iab52f7759028dae68b592ec59b7712a0b04344c7 Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2062990 Reviewed-by: Jett Rink <jettrink@chromium.org> Commit-Queue: Jett Rink <jettrink@chromium.org>
* doc: add doc for code review rotationJett Rink2019-12-191-0/+33
We will use cros-ec-reviewers@google.com account to trigger the round-robin code reviewer assignment for CLs. If you are the R line of this CL, then you are on the initial list :) BRANCH=none BUG=b:142125160 TEST=builds Change-Id: I121a8acc984b6b99bb9c1f3638ef431822080f0a Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1972607 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Scott Collyer <scollyer@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
View Lorry Controller Status