| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chunk_len is int, payload_size and trasnfer_size are size_t. This
results in a wanrning when comparing with MIN. Fix by casting chunk_len
to size_t before comparing.
BUG=None
BRANCH=None
TEST=Build
Change-Id: I5f0114654b3f23fef88e755576bcd8971d223682
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4311236
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the .isort.cfg from platform/ec and use the one from chromite
instead. This should be compatible with cros format.
BRANCH=None
BUG=b:267757300
TEST=Ran firmware_builder.py
Change-Id: Ice4955b6995bd1f9380e97f58e89efb7c1e8aeb1
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4221928
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like the current llvm release changes the clang-format output for
few files, which is currently breaking CI and blocking any merging.
Rerun clang-format -i on the affected files.
BRANCH=none
BUG=b:265098403
TEST=./util/check_clang_format.py
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Change-Id: Ife808c4f24d9c2469d2addda8af209c695cee1e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4154893
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Alexander Hartl <alexanderhartl@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sort all includes in extra with the clang-format rules used by the
zephyr project.
BRANCH=None
BUG=b:247100970
TEST=zmake build -a
TEST=./twister --clobber -v -i
TEST=make -j$(nproc) buildall_only runtests
TEST=zmake compare-builds
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I407b20fbc45280c7593fe46e6014f7944068cb85
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4047097
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Commit-Queue: Simon Glass <sjg@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The EC_CMD_READ_TEST expected "response_size" to be explicitly set by
the host as greater than zero. This is not how the host commands are
used and there is not a single other host command that behaves in this
way. This expectation resulted in a return value of EC_RES_ERROR every
time the host command was invoked. It's been broken in this way for
about 4 years, which indicates the host command is not used.
Remove the EC_CMD_READ_TEST to gain a bit of flash space back.
BRANCH=none
BUG=b:254534089
TEST=zmake build herobrine image report
TEST=ectool without removal of host command
TEST=CQ
Signed-off-by: Aaron Massey <aaronmassey@google.com>
Change-Id: I2a6cfd4352fb9da1890463a7fadfd0e08c1fb989
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3967307
Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was trying to pass the optional "langid" arg to usb.util.get_string(),
but was doing so as a positional argument, in the wrong position.
This bug was papered over by a blanket "except:" clause that would fall
back on not specifying langid. With older PyUSB versions an exception from
the incorrect args would be triggered, thus the fallback was always used.
PyUSB now returns garbage for the serial number from the incorrect args, so
the serial number comparisons stopped working.
The langid being specified was 256 / 0x100, which is in a reserved block,
not specific to any real language. The get_string() invocation returns
the correct serial number with or without that langid specified (using
the args correctly), and servod never specifies langid in these lookups,
so this removes use of langid entirely to match servod behavior and remove
need for the try/except fallback.
This also fixes another blanket "except:" to specify the exception it's
actually intending to catch (IndexError).
Finally, this adds printing of default option values in the command line
help output, so that it's clear --device has a default value and will
usually need to be specified too when using --serialno. (We should
change or remove the default and make --device optional when using
--serialno, but I'll leave that for another patch.)
BRANCH=none
BUG=b:243562728
TEST=With multiple servos plugged in, including multiple servo_v4p1,
tested opening consoles via --serialno by itself, --device by itself,
and the two options in conjunction.
Signed-off-by: Matthew Blecker <matthewb@chromium.org>
Change-Id: Idd731ce76c9ed9a2e067bca11ede42b782a94669
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3902449
Reviewed-by: Ziting Shen <zitingshen@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This supplements Documentation.txt, which is plain text as used by
documentation in old Linux kernel versions, with Documentation.rst,
which is reStructuredText as used in the latest versions of Linux.
The plain text Documentation.txt remains and will be maintained as
long as backport patches are maintained.
Since Chromium OS source code browsing websites such as Gitiles and
Code Search can render Markdown, but not reStructuredText,
Documentation.md is included as well, generated using rst2md from
nb2plots (https://github.com/matthew-brett/nb2plots) which uses
Sphinx (https://www.sphinx-doc.org/).
BRANCH=none
BUG=b:129565355
TEST=viewed the markdown doc in Gitiles using Chrome
Change-Id: I332ba9098a1379b2f56efbaab84ed5498ef43d34
Signed-off-by: Matthew Blecker <matthewb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3900487
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Normally we don't do this, but enough changes have accumulated that
we're doing a tree-wide one-off update of the name & style.
BRANCH=none
BUG=chromium:1098010
TEST=`repo upload` works
Change-Id: Icd3a1723c20595356af83d190b2c6a9078b3013b
Signed-off-by: Mike Frysinger <vapier@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891203
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of commit 9bfe90b111b030419871c5035b4dc0063e2f8221
It had nothing to do with b/245028043 (wrong branch, doesn't affect
gsctool)
Original change's description:
> ec: Fix DEBUG "variable" in usb_updater Makefile
>
> DEBUG is not the way to refer to a variable in a Makefile expression;
> $(DEBUG) is.
>
> Also, make extra/rma_reset/Makefile consistent.
>
> Drop the EOF blank line to satisfy linter.
>
> BUG=none
> TEST=build
> BRANCH=none
>
> Change-Id: Ic71be497ca83041dfdedf63c10e7c74b38c05bc8
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872546
> Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
> Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Bug: b:245028043
Change-Id: I2dfdf5f1ac3b20c4fafe323f5f63585f809e9dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3873805
Commit-Queue: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 9bfe90b111b030419871c5035b4dc0063e2f8221.
Reason for revert: This breaks build of chromeos-cr50-dev: b/245028043
Bug: b/245028043
Original change's description:
> ec: Fix DEBUG "variable" in usb_updater Makefile
>
> DEBUG is not the way to refer to a variable in a Makefile expression;
> $(DEBUG) is.
>
> Also, make extra/rma_reset/Makefile consistent.
>
> Drop the EOF blank line to satisfy linter.
>
> BUG=none
> TEST=build
> BRANCH=none
>
> Change-Id: Ic71be497ca83041dfdedf63c10e7c74b38c05bc8
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872546
> Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
> Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Bug: none
Change-Id: I3695637fb72be8f6ead03b609b4ba0dba7e83452
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872413
Reviewed-by: Jim Pollock <jmpollock@chromium.org>
Tested-by: Jim Pollock <jmpollock@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DEBUG is not the way to refer to a variable in a Makefile expression;
$(DEBUG) is.
Also, make extra/rma_reset/Makefile consistent.
Drop the EOF blank line to satisfy linter.
BUG=none
TEST=build
BRANCH=none
Change-Id: Ic71be497ca83041dfdedf63c10e7c74b38c05bc8
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872546
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add pyproject.toml config file to set black to 80 columns.
Remove column length overrides from other config files.
Reformat python files to 80 cols.
BRANCH=None
BUG=b:238434058
TEST=presubmit/CQ
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I870a68f1bb751f4bad97024045f6e3075489e80f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3764071
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The black formatting revealed some odd formatting.
Fixed all errors from cros lint.
find . \( -path ./private -prune \) -o -name '*.py' -print | \
xargs cros lint -v |& grep ": E"
BRANCH=None
BUG=b:238434058
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: Ia1d2e9cfb0cd2b7000d15b3b918d24881987673e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3749249
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
find . \( -path ./private -prune \) -o -name '*.py' -print | xargs black
find . \( -path ./private -prune \) -o -name '*.py' -print | xargs ~/chromiumos/chromite/scripts/isort --settings-file=.isort.cfg
BRANCH=None
BUG=b:238434058
TEST=None
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Change-Id: I63462d6f15d1eaf3db84eb20d1404ee976be8382
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3749242
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The declaration for rand conflicts with the standard library declaration
so rename it from "rand" to "trng_rand". This has the benefit of making
it obvious when we're using the true random number generator.
For consistency, this also renames init_trng/exit_trng to
trng_init/trng_exit.
This is a reland of commit a6b0b3554f59cc9b0c4aae9bff7dff075f2089a9.
BRANCH=none
BUG=b:234181908, b:237344361
TEST=./util/compare_build.sh -b all -j 120
=> MATCH
TEST=emerge-hatch ec-utils-test
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Ic26890572cb9865275c866b65b0532c5ab029865
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3738978
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Bobby Casey <bobbycasey@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Tricium: disable
Change-Id: Idbf9e30205e384c290cef42d8cd9bf45f7cda89d
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730178
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Change-Id: I00976ca4b072d2b63fc123b9aa28859caa6412b3
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730188
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Change-Id: Ibb3b2bf57de9fa67b68c13d1111caa9ba2d7cb60
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730184
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Change-Id: I545833c2b5c8c25b0f34da5277375729c9836a43
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730180
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Change-Id: Iec0464940c67062c7ac8f2df08ef7e5b2e058e8b
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730185
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Change-Id: I725be1b8c902f477705d1dc3663121c115716fdd
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730182
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Change-Id: I85737cb5b016e830d8b96b962b82ec4a276dc03e
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730190
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Change-Id: I350401a185e27bc976cfbf4d3c1d8e53cdc55927
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730179
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Change-Id: Icb5b66f4000902a76ebd4209af3008b2c83ca53f
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730189
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Change-Id: I0545f6f73077099ebe5d7a777561772ef3ccfddb
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730183
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Change-Id: I08be6faa208b3cf6c62feaf9b4342c2e360943eb
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730191
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Change-Id: I1c49fd1d51d8ea32d570ad51149116ad7e512d73
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730181
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Change-Id: Ie427e3ee7843883b0b4c9337980ad1074da2a630
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730186
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:236386294
BRANCH=none
TEST=none
Change-Id: Idfbb6dea2a0516fd93b74a7b4bc038dfe84561ec
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3730187
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All devices using EC to store VBNV (Vboot nvdata) have reached their
AUE. Remove all VBNV-related code.
BUG=b:178689388
TEST=make build_cros_ec_commands
BRANCH=none
Cq-Depend: chromium:3725376
Change-Id: I85851b1404e3b6279ed4588e19db21738ad2f07c
Signed-off-by: Yu-Ping Wu <yupingso@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3724971
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix serial number detect
new python3.9 incompatibilities.
cros lint to the extent possible
BUG=b:216199797
TEST=./tigertest.py -c 10; servo_updater -b servo_v4
BRANCH=none
Signed-off-by: Nick Sanders <nsanders@chromium.org>
Change-Id: I2ec628389f63711a540223fc9004c9fff7155c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3615478
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A workaround for the remaining character in the USB buffer.
BRANCH=None
BUG=b:232156962
TEST=servo_updater -b servo_micro
Signed-off-by: Yi Chou <yich@google.com>
Change-Id: I0334172c0bc10d16201ff9c4d54d66c02ea283f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3688769
Reviewed-by: Brian Nemec <bnemec@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No implementation does nothing other than return 0 on task_set_event(),
change the return type to void so that the API is clear.
BRANCH=none
BUG=none
TEST=cq dry run
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Change-Id: I88b20f53aa6dffa291ce78f4776888b21985f57f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3683769
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To string has been an alias for tobytes since python 3.2, in later
version of python ( 3.9 and beyond ) this alias is removed. https://bugs.python.org/issue38916
This is a save change as all of chrome dev is on 3.6 or better.
The error goes away but when using usb_console inside of a container
I get device busy errors as the servod is running.
BUG=b:234176994
TEST=built a servod with python 3.10 and tested usb_console.
Change-Id: I1b00b0dd96413490936e20aa28067324c9d8e9a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3674943
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Auto-Submit: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux 5.15 moved stdarg.h to linux/stdarg.h, and removed the old
stdarg.h in commit c0891ac15f0428ffa81b2e818d416bdf3cb74ab6. Update
the i2c-pseudo module to build on these newer kernels.
BUG=none
TEST=now builds on Linux 5.16.18
BRANCH=none
Change-Id: I331cfc3c2bb7300b5f2c19d595214bfb1e9a8622
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3650292
Reviewed-by: Shou-Chieh Hsu <shouchieh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix command truncation issue and change reboot detection mechanism.
Fix lint.
BUG=b:216199797
TEST=./tigertest.py -c 10
BRANCH=none
Signed-off-by: Nick Sanders <nsanders@chromium.org>
Change-Id: I2a3f962c2bcc1d87a2c3e8ac7da89e99997f3b40
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3419581
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes find_interface use bInterfaceNumber explicitly instead
of the i iterator, which could be different from the discovered
interface number if there is no interface at index 0.
BUG=b:229012657
BRANCH=None
TEST=Run 'usb_updater2 -f' on Vell.
Change-Id: I7e156eefad6729b5d568fb0e0308b93cdb78a2ea
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3584693
Reviewed-by: Parth Malkan <parthmalkan@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without sudo powerlog failed with
"Access denied (insufficient permissions)".
BRANCH=None
BUG=None
TEST=None
Signed-off-by: Michael Pishchagin <mblsha@chromium.org>
Change-Id: I1aeaf20f13179f49814a6b74074dcf9dd1103c45
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3400760
Tested-by: Michael Pishchagin <mblsha@google.com>
Auto-Submit: Michael Pishchagin <mblsha@google.com>
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Commit-Queue: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In current state after firmware is updated we perform reboot and check
if servo is in RO. Due to this check we need to reinitialize uart
connection. This procedure takes resources from kernel driver and makes
it impossible to use servo console from OS just after servo_updater.
This patch adds additional reboot, it allows kernel driver to reconnect
to servo console and use it.
BRANCH=None
BUG=b:196021317
TEST=run servo_updater.py, after the tool finishes job check if we can
access servo EC via serial terminal using e.g. picocom /dev/ttyUSB0.
Signed-off-by: Lukasz Hajec <lha@semihalf.com>
Change-Id: Icebb1a2faa8803d13736ea241b894adaf146b433
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3111367
Reviewed-by: Matthew Blecker <matthewb@chromium.org>
Commit-Queue: Matthew Blecker <matthewb@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This requests that cros lint (and repo upload hook) use the new
Chromium OS 4 space indent policy.
Since legacy python scripts still use 2 space, I added pylint ignore
statements to the individual files to disable indentation checking.
Note: There are still valid pylint errors in some of these legacy scripts.
BRANCH=none
BUG=none
TEST=cros lint util/*.py
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I439f5a87bc50f1f43a4996e574bbc0626922a88e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3064761
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the related stack instructions analysis for Risc-v
architecture to calculate stack frame sizes of functions
and find the maximum calling path with maximum stack usage
in stack analyzer tool.
BUG=b:181291750
BRANCH=none
TEST=make BOARD=icarus analyzestack
Signed-off-by: tim <tim2.lin@ite.corp-partner.google.com>
Change-Id: Ieb1ccc3c1631f990adf7dd556f3e876b1a142a71
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2731176
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting with Glibc 2.32:
* The deprecated arrays sys_siglist, _sys_siglist, and
sys_sigabbrev are no longer available to newly linked binaries,
and their declarations have been removed from <string.h>. They
are exported solely as compatibility symbols to support old
binaries. All programs should use strsignal instead.
https://sourceware.org/pipermail/libc-announce/2020/000029.html
BUG=chromium:1171287
BRANCH=none
TEST=Local builds on x86_64 / eve and arm / kevin. Sent SIGINT
to iteflash and verified output.
Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Change-Id: I8b4deaf8743c806a9610863648b345be3b35e1b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2698188
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces -p/--print to servo_updater. Rather than
performing an update, it will print for the chosen board/channel what
firmware is available. See TEST below for output.
BRANCH=None
BUG=b:179310743
TEST=servo_updater -b servo_micro -c alpha -p
board: servo_micro
channel: alpha
firmware: servo_micro_v2.4.35-f1113c92b
// showing py2 compatibility
TEST=python2 /usr/lib64/python2.7/site-packages/servo_updater.py -b \
servo_micro --print -c alpha
board: servo_micro
channel: alpha
firmware: servo_micro_v2.4.0-dc38d9bbb
Change-Id: I9899e1cacc0496a46a41e94cc9355438a5abe491
Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2674381
Reviewed-by: Brian Nemec <bnemec@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces the ability of using servo_updater as a library
to check whether a firmware string (e.g. the one currently read out from
the servo device) belongs to a known channel. If so, the channel will be
returned. If not, None is returned to indicate this is an unknown
firmware string. This can then be used to warn the user to update, or
inform them what channel they are currently running.
BRANCH=None
BUG=b:179310743
// This is performed with the CL that uses this: chromium:2661015
TEST=sudo servod -b soraka
dut-control servo_micro_firmware_channel
servo_micro_firmware_channel:stable
Change-Id: I49e920c7c7977b7c05828f8464af973f538f7aeb
Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2661021
Reviewed-by: Brian Nemec <bnemec@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commonly the users of servo_updater (as a script, or a file) care about
the firmware version string in addition to knowing what the filename is,
and the configuration is. These are used to print informational
messages, or check whether an update is needed among other things.
This change consolidates that logic by making sure that the version
string is always extracted when possible.
BRANCH=None
BUG=b:179310743
TEST=sudo servod -b soraka
// observe logs print the servo firmware version information
TEST=sudo servo_updater --board servo_micro
// observe no errors
Change-Id: Id7cb8f53e5fc3e1f557d74445d49fcafbda851ad
Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2661020
Reviewed-by: Brian Nemec <bnemec@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces the ability to pull an update from a specific
channel (i.e. a specific file). See the bug for details on this project,
but basically the `servo-firmware` package now bundles multiple firmware
in the system, all of which are tagged to belong to a 'channel'. The
name of those files is then [board_name].[channel].bin. The updater then
now supports the notion of requesting a specific channel to update, if
the default (stable) is not desired.
Like the previous CL it also leverages choices for argparse to ensure no
unknown channels are requested.
BRANCH=None
BUG=b:179310743
TEST=servo_updater --help | grep channel
-c {alpha,dev,prev,stable}, --channel {alpha,dev,prev,stable}
TEST=sudo servo_updater --board servo_micro -c alpha
Current servo_micro version is servo_micro_v2.4.35-f1113c92b
Available servo_micro version is servo_micro_v2.4.35-f1113c92b
No version update needed
Cq-Depend: chromium:2674405
Change-Id: I88c301cc4ff0ac246cbfda6498c27a1fd23f722f
Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2661019
Reviewed-by: Brian Nemec <bnemec@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change has some minor cleanup and introduces the usage of 'choices'
to the board argument, to stop errors on argument parsing already.
BRANCH=None
BUG=b:179310743
TEST=servo_updater --help | grep board
-b {c2d2,servo_micro,servo_v4,servo_v4p1,sweetberry}, --board [...]
Change-Id: I676a5250d4721a309eec4a50a585a5ed719095b6
Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2661018
Reviewed-by: Brian Nemec <bnemec@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=b:178648877
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I0ac5581ba7bc512234d40dbf34222422afa9c725
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2650551
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add verifying if jump to region was successful by executing sysinfo
after every jump.
Add retries if no response to command from servo was received.
BUG=b:177673664
BRANCH=main
TEST=Prepare a few firmware builds from different commits, to be able
to verify if they were successfully flashed.
Flash firmware using modified script from extra/usb_updater:
sudo ./servo_updater.py -b servo_v4p1 -f <fw>
Run servod to connect to servo console and execute command: version
Check if both RO and RW sections have the same FW version.
TEST=To check error handling, run servod in one terminal, and in
another one try flashing firmware.
There should be retries due to no response received.
After 2-3 retries, close servod and flashing should
automatically continue without errors.
Signed-off-by: Michał Barnaś <mb@semihalf.com>
Change-Id: Ic73e50592fdc5f0f8e2cd9cd2ab4f034ef17e4ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2633993
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Commit-Queue: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Minor formatting fix to make sure that .md files are \n terminated.
Also a small change in the way we name the logger so that it derives
the name directly from the class.
BUG=b:174800621
BRANCH=None
TEST=sudo servod -c kohaku_rev2_loc0.xml
dut-power -t 3
// normal output
Change-Id: I3e49068a7b0f3e8908fbcce6a13e083ce8e9216a
Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2594689
Reviewed-by: Mengqi Guo <mqg@chromium.org>
|