| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update both the scripts used to verify that ad-hoc CONFIG options have a
Kconfig option to use the same search criteria.
The list of Kconfigs is now all option that start with the config or
menuconfig keyword. The full Kconfig list is transformed to replace
CONFIG_PLATFORM_EC_ with CONFIG_, to match the Chromium EC namespace.
BUG=b:184037201
BRANCH=none
TEST=make buildall
TEST=zmake testall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I5edeeddd4e935b4bbf2ce7321a19249a543d916e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2860985
Reviewed-by: Simon Glass <sjg@chromium.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the tmp file cleanup logic. We use "mktemp -d" to create a
temporary directory, but then use this name as the basename for tmp
files instead of path prefix. So, use '/' instead of '.' to compose tmp
file paths.
BRANCH=none
BUG=none
TEST=/tmp is no longer polluted with stale tmp files
Change-Id: I585c39065d71a39edc6d333b34f157fe27d2b511
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2771742
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This currently looks for CONFIG options in the Kconfig files, but
these all have a PLATFORM_EC prefix. Fix this.
Also while we are here, combine the two sed expressions for config and
menuconfig and don't allow trailing spaces, since these should not be
present.
BUG=b:181253613
BRANCH=none
TEST=cherry-pick Rob's CL http://crrev.com/c/2659282
make BOARD=volteer -j30
See that it doesn't warn about CCD_USBC_PORT_NUMBER anymore
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: Iddcd4aa7884a9f10a5260aa8e71b4131ba550389
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2749761
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
|
|
|
Add a script to help deal with new ad-hoc CONFIG options being added
to ECOS.
This works by maintaining a list of allowed ad-hoc CONFIG options and
refusing to allow a build to succeed if it adds new ones.
This is easier to implement than a pre-submit and more useful, since
we can check the actual CONFIG file produced by a board. For example,
adding a new CONFIG to board/volteer/board.h will cause the volteer
build to break, but not kukui. That seems important to avoid
frustration.
Add the base list of allowed ad-hoc CONFIGs, which should never grow.
As new Kconfig options are added for existing CONFIG options, or
obsolete CONFIG options are removed, the list should eventually shrink
to zero.
BUG=b:181253613
BRANCH=none
TEST=manually test that adding a new '#define CONFIG' causes an error
to be generated, and adding a new Kconfig option with the same name
causes the error to go away.
Also check that the script suggests updating the list when a Kconfig is
added for an existing CONFIG option.
Finally, manually check that ALLOW_CONFIG=1 does as intended.
(that's quite a few manual tests; possibly it is worth automating
them)
Change-Id: Id11b8d859fd07c2db73324cbb9e425182710ab3d
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2718533
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Yuval Peress <peress@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
|
