| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At present when I 'repo upload' it opens meld and shows me all the
changes I have made, sometimes many times.
Add the --no-ext-diff flag to two up the pre-submit scripts to fix
this.
BUG=none
BRANCH=none
TEST=repo upload... see that meld does not run
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: Id48cc1654f681e19052298c1ab98911883c19318
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2665297
Reviewed-by: Mike Frysinger <vapier@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was added to the presubmit back in the days of the legacy commit
queue, to avoid blowing up the CQ when unit tests had not been run.
This is unnecessary now with Parallel CQ, these tests are run as a
part of CL-specific commit queues.
BUG=none
BRANCH=none
TEST=presubmit
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Change-Id: I57837755e37cc46f80ad5bd7c61082d2c7077aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2436379
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The presubmit message that checks for 'make buildall' having been run
suggests using 'make buildall -j', which can cause an unbounded number
of processes to be started, especially as the number of EC targets have
increased. Suggest a more reasonable value.
BUG=none
TEST=Check presubmit output.
BRANCH=none
Change-Id: Ie35a545dc1c4d58a3ad9d0ed0233c62ab5a92464
Signed-off-by: Andrew McRae <amcrae@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2366324
Reviewed-by: Andrew McRae <amcrae@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Andrew McRae <amcrae@chromium.org>
Tested-by: Andrew McRae <amcrae@chromium.org>
Auto-Submit: Andrew McRae <amcrae@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files aren't used by "make buildall", so it shouldn't cause a
developer to run "make buildall" before submitting a change to the file.
BUG=None
BRANCH=None
TEST=Modify navbar.md. Try to upload and verify that the presubmit check
does not flag it.
Change-Id: Ia4eaa7009aa52b7a096171e66e6541694ef73032
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1758539
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Markdown docs don't affect the build. Make presubmit slightly nicer.
BUG=none
BRANCH=none
TEST=run util/presubmit_check.sh after committing docs/ only changes
Change-Id: I273dd071e3cf5e859a0a4f0f97e9011cc4391f0d
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1706613
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uart stress tester runs a 'chargen' UART command on EC and/or AP, and
checks if any characters are lost from UART output.
BUG=b:131340067
BRANCH=None
TEST=ran on Bob and Octopus (Fleex)
$ ./util/uart_stress_tester.py -h
usage: uart_stress_tester.py [-h] [-c] [-d] [-t TIME] [port [port ...]]
uart_stress_tester.py repeats sending a uart console command
to each UART device for a given time, and check if output
has any missing characters.
Examples:
uart_stress_tester.py /dev/ttyUSB2 --time 3600
uart_stress_tester.py /dev/ttyUSB1 /dev/ttyUSB2 --debug
uart_stress_tester.py /dev/ttyUSB1 /dev/ttyUSB2 --cr50
positional arguments:
port UART device path to test
optional arguments:
-h, --help show this help message and exit
-c, --cr50 generate TPM workload on cr50
-d, --debug enable debug messages
-t TIME, --time TIME Test duration in second
$ ./util/uart_stress_tester.py /dev/ttyUSB1 /dev/ttyUSB2 -t 120
INFO | UartSerial| EC | 0 char lost / 1382400 (0.0 %)
INFO | UartSerial| AP | 0 char lost / 1382400 (0.0 %)
INFO | ChargenTest | PASS: lost 0 character(s) from the test
$ ./util/uart_stress_tester.py /dev/ttyUSB1 /dev/ttyUSB2 -t 120 --cr50
INFO | UartSerial| EC | 0 char lost / 1382400 (0.0 %)
INFO | UartSerial| AP | 0 char lost / 1382400 (0.0 %)
INFO | ChargenTest | PASS: lost 0 character(s) from the test
Change-Id: I713fb0180db3ca5904bd7aae0dd26a4633733d2e
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1683011
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There should be no newlines in string parameters of the CPRINTS()
macro, it adds a newline unconditionally.
BRANCH=none
BUG=none
TEST=created a failing patch and observed expected error message:
. $ ./util/presubmit_check.sh
. +++ b/chip/g/usb-stream.c
. + CPRINTS("this is a bad, bad, string\n", yes);
. error: CPRINTS strings should not include newline characters
Change-Id: I9b6338743d2493aa731dd49ae35f9de043fd860b
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1665449
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The OWNERS file isn't used by `make buildall`, so it shouldn't cause a
developer to run `make buildall` before submitting a change to the file.
This commit simply filters out changes to the OWNERS file from the
presubmit_check script.
BUG=None
BRANCH=None
TEST=Modify OWNERS. Try to upload and verify that the presubmit check
does not flag it.
Change-Id: I71452ac0a751335f815c707b554a2578c532b476
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1666754
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ran the following command:
git grep -l 'Copyright (c)' | \
xargs sed -i 's/Copyright (c)/Copyright/g'
BRANCH=none
BUG=none
TEST=make buildall -j
Change-Id: I6cc4a0f7e8b30d5b5f97d53c031c299f3e164ca7
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1663262
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This script repeats a console command on target UARTs, and collects the
output. It checks whether there are any lost characters or patterns are
corrupted.
BUG=b:131340067
BRANCH=None
TEST=manually ran this script on scarlet with suzy-Q.
$ ./util/uart_stress_tester.sh -h
usage: uart_stress_tester.sh [flags]
example:
uart_stress_tester.sh --pty /dev/ttyUSB0 --min_char 100000
uart_stress_tester.sh --pty="/dev/ttyUSB0 /dev/ttyUSB2"
flags:
--pty: List of UART device path(s) to test (default: '')
--min_char: Minimum number of characters to generate. \
(default: 40000)
-h,--[no]help: show this help (default: false)
$ echo 'chan save' > /dev/ttyUSB0
$ echo 'chan save' > /dev/ttyUSB2
$ echo 'chan 0' > /dev/ttyUSB0
$ echo 'chan 0' > /dev/ttyUSB2
$ ./util/uart_stress_tester.sh --pty="/dev/ttyUSB0 /dev/tty/USB1 \
/dev/ttyUSB2"
INFO : ChromeOS UART stress test starts.
INFO : UART devices: /dev/ttyUSB0 /dev/ttyUSB2 /dev/ttyUSB1
.....
INFO : /dev/ttyUSB0: 0 lost / 48785 : 0 %
ERROR : /dev/ttyUSB2: 19444 lost / 41965 : 46.3 %
ERROR : /dev/ttyUSB1: 16768 lost / 40425 : 41.4 %
INFO : Test files are in /tmp/uart_stress_tester.sh_latest
ERROR : FAIL
Change-Id: Iedd8c9a62e089fde8894ee93329ee9f4a31bb3e7
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1586581
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=none
TEST=util/presubmit_check.sh
Change-Id: I6078377603719de1d633660c69ad3a40b29ffadf
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/640191
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Che-yu Wu <cheyuw@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One of the items that the presubmit check checks is that if any source
file has been modified, the unit tests are run again. However, flash_ec
is included in the list of files. This commit removes flash_ec from the
candidates because it's not run in any unit tests anyways and it's a
shell script that is not compiled.
Additionally, ignore changes to the presubmit_check.sh itself.
BUG=None
BRANCH=None
TEST=modify flash_ec, verify that presubmit check doesn't complain about
not running make buildall.
Change-Id: I473f269c7f0bba9be3216fcec39f266d896fb908
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/598505
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a user had already run util/ec3po/run_tests.sh, and then never
modified any ec3po files, the presubmit check would list every file in
the EC repo that was newer since the the last run. This included
files such as build artifacts.
BUG=chromium:575032
BRANCH=None
TEST=Run ./util/ec3po/run_tests.sh once. Run make -j buildall, try to
upload and verify that no nag message to run ec3po tests is presented.
TEST=Touch an ec3po file, try to upload, verify that nag message about
running ec3po unit tests is presented.
Change-Id: I4f09bb76dcd85b570b57030197f4887bed85f1a7
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/321134
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The presubmit check would nag at the user to run the EC-3PO unit
tests, even if they hadn't modified any EC-3PO files. This was not my
intention. This commit fixes the presubmit check to only check for
unit test success if a EC-3PO file is modified.
BUG=chromium:575032
BRANCH=None
TEST=Remove util/ec3po/.tests-passed; Modify a non-ec3po file, commit,
and try to upload. Verify that no nag message is presented.
TEST=Remove util/ec3po/.tests-passed; Modify a ec3po file, commit, and
try to upload. Verify that a nag message to run unit tests is
presented.
Change-Id: I86e9f325329b7ad1a4c7c5971b7851e9024e7750
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/320831
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added presubmit check to make sure that when any ec3po files are
modified, the unit tests should be run as well.
BUG=None
BRANCH=None
TEST=Touched a unit test file, tried repo upload and received an error
about running unit tests. Ran run_tests.sh and all tests passed. Tried
to repo upload again and this time it succeeded.
TEST=Created a failure in one unit test, ran run_tests.sh and verified
that the failure was caught and the CL wouldn't pass the presubmit
check.
Change-Id: I4df4a0fd1107292f693749188491f6286360f557
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/319211
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
|
|
This enforces that "make buildall" runs at least once after the last
file change.
TEST=Try to upload without running "make buildall"
TEST=Change a file without re-running "make buildall", and try to
upload.
BUG=None
BRANCH=None
Change-Id: Ia4abb3c0e17cf4d559975574f398d74c7986c89f
Signed-off-by: Vic (Chun-Ju) Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/185116
Reviewed-by: Dave Parker <dparker@chromium.org>
|