| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To save G3 power as suggested in b:228574354
BUG=b:228574354
TEST=measure G3 power
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I4862a10c025289ce75471bb105a68819d4147374
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3583742
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Coding style fix according to review comment in
https://crrev.com/c/3580113/2.
Ref:
https://docs.zephyrproject.org/latest/contribute/guidelines.html
BUG=none
TEST=1) code compilable:
zmake build {krabby,kingler}
2) make sure not missing anything:
ag '(if|for|while) \(.*[^{]$'
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I277d00f34d61ea8a6a43a2482bb152d3835e2ae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3582434
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move rt9490 interrupt handler from c code to device tree.
BUG=b:220814055
TEST=C1 BC1.2 works on krabby
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: Ide64449e1c3dd23ecd2b06021ee39d746cb9b938
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3580113
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert the krabby board LED code to use the Zephyr PWM APIs. This
cannot use the generic cros-ec,pwm-leds right now, but this at least
gets rid of the named-pwms node.
BRANCH=none
BUG=b:217741090
TEST=zmake build krabby
Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Change-Id: Ied8f2efc2d54a7a92b6be286dc2c1a0b3b6fdc89
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3569765
Reviewed-by: Parth Malkan <parthmalkan@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 020d5f25e593847ec16142d77795d94a73f1ea87.
Reason for revert: b:227661993: EFS2 broken after SYS_INIT changes
Note, not a clean revert due to CL:3555429
Original change's description:
> corsola: convert HOOK_INIT to SYS_INIT
>
> Convert all HOOK_INIT calls to the equivalent SYS_INIT.
>
> BUG=b:226434387
> BRANCH=none
> TEST=zmake testall
>
> Signed-off-by: Keith Short <keithshort@chromium.org>
> Change-Id: Ib63d32bf88bbbcc74f1dc417c9e4b7ebd5ac5027
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3553843
> Reviewed-by: Al Semjonovs <asemjonovs@google.com>
Bug: b:226434387
Change-Id: Id8ec261fdec2b9a7654d4e51db146dc14ff44d5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3564809
Tested-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Al Semjonovs <asemjonovs@google.com>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit c20a1a6b579c4bf632716e3a633656f6532295b3.
Reason for revert: b:227661993: EFS2 broken after SYS_INIT changes
Original change's description:
> zephyr: map legacy hook priorities to Zephyr priorities
>
> Map the HOOK_PRIO_PRE_DEFAULT, HOOK_PRIO_DEFAULT, and
> HOOK_PRIO_POST_DEFAULT to the Zephyr equivalents.
>
> BUG=b:226434387
> BRANCH=none
> TEST=zmake testall
>
> Signed-off-by: Keith Short <keithshort@chromium.org>
> Change-Id: Icf7332bb8341adff185754ef159a83d1b4a8a824
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3553850
> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Bug: b:226434387
Change-Id: I5d3cd460c262be94f377d79efafead69dc7d6292
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3564801
Tested-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Commit-Queue: Keith Short <keithshort@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RT9490 enables HS mode I2C (3.4MHz) by default, and this IP is apparently
not fully backward compatible with lower speed.
This will be fixed in newer version, but we still need this workaround to
lock the speed at 400Khz for early build.
BUG=b:214880220
TEST=manually
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: Ia567f782345f0b261c289431ce8b5de574b3ba57
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3555429
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Map the HOOK_PRIO_PRE_DEFAULT, HOOK_PRIO_DEFAULT, and
HOOK_PRIO_POST_DEFAULT to the Zephyr equivalents.
BUG=b:226434387
BRANCH=none
TEST=zmake testall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: Icf7332bb8341adff185754ef159a83d1b4a8a824
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3553850
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert all HOOK_INIT calls to the equivalent SYS_INIT.
BUG=b:226434387
BRANCH=none
TEST=zmake testall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: Ib63d32bf88bbbcc74f1dc417c9e4b7ebd5ac5027
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3553843
Reviewed-by: Al Semjonovs <asemjonovs@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the HOOK_PRIO_POST_DEFAULT alias for
(HOOK_PRIO_DEFAULT+1). This more clearly identifies the intent
of this priority level.
BUG=none
BRANCH=none
TEST=compare_build.sh
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I58debd5545386a0ca01ebe59a431a2cfa997a32a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3553677
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the HOOK_PRIO_POST_I2C alias for (HOOK_PRIO_INIT_I2C+1). This
more clearly identifies the intent of this priority level.
Applied only to common code and to Zephyr boards.
BUG=none
BRANCH=none
TEST=compare_build.sh
TEST=zmake testall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: Ia5b8c594e1f06ae1a982770f75b63bb4ba44191f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3553669
Reviewed-by: Wai-Hong Tam <waihong@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is workaround for i2c enhance channels will block chip
to enter low power if clock and data pins aren't both at high
level.
BRANCH=none
BUG=b:220647142
TEST=power number is reduced in G3 on krabby.
i2c3 works in S0
Signed-off-by: Dino Li <Dino.Li@ite.com.tw>
Change-Id: I00590791c36885a58e868a6cc4bbd40545b2403f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3544756
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:220814055
TEST=manually checked the array content
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I92540572d5c1b05495ae8f45464d1f3a6dbfa704
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3487363
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented the IBUS ADC workaround for krabby rev0.
The code is provided from vendor in b/194967754#comment5.
BUG=b:194967754
TEST=none
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I4ea98aa91a0d35b8b8665c08db413c0503f7baef
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3415389
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds addr_flags and cmd_id (AKA offset) to
board_allow_i2c_passthru().
This CL is a kind-of-cherrypick of this other CL:
https://crrev.com/c/1588492
BRANCH=none
BUG=b:135642493
TEST=make buildall passes
tested in Madoo where I manually added a board_allow_i2c_passthru()
function that was blocking port 5 (battery) and did:
With EC unlocked:
dut # ectool i2cread 8 0x05 22 1
Read from I2C port 5 at 0x16 offset 0x1 = 0x67
With EC locked:
dut # ectool i2cread 8 0x05 22 1
EC result 4 (ACCESS_DENIED)
Change-Id: Ifba59f21f63f99345b81dd250296214a5cd29eba
Signed-off-by: Ricardo Quesada <ricardoq@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3466422
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Ricardo Quesada <ricardoq@chromium.org>
Auto-Submit: Ricardo Quesada <ricardoq@chromium.org>
Commit-Queue: Ricardo Quesada <ricardoq@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert HOOK_CHIPSET_ hooks to AP power callback handling.
BUG=b:223800037
TEST=zmake testall
BRANCH=none
Signed-off-by: Andrew McRae <amcrae@google.com>
Change-Id: I1a9574cacd5746467494facf9133f360a31cc3d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3518465
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the Zephyr driver GPIO include for Zephyr shim code instead of the
legacy EC GPIO header.
BUG=b:218856245
BRANCH=none
TEST=zmake testall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I80f9cbf012a9bd49b80f2b0fad1f0663da2e34b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489246
Reviewed-by: Tristan Honscheid <honscheid@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the type-c related components for krabby.
Since the device tree support for most components are not ready yet,
this CL still uses lagacy pattern.
Will migrate to device tree in upcoming CLs.
BUG=b:218982792
TEST=Manually verify usb function works, mostly verified in driver
implementation CLs.
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I2b608044882e39d2ef35dbbf5562112fca7fc7d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3357552
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable these configs for dynamic daughter board detection
BUG=b:216021294
TEST=zmake configure -b krabby
BRANCH=none
Change-Id: I2e2ff7eb998d30a635f0753875a9757d1f75a96a
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3487368
Tested-by: Eric Yilun Lin <yllin@google.com>
Auto-Submit: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Migrate the GPIO access to use the Zephyr API.
Also consolidate the GPIO naming so that remapping of
GPIO names is done through DTS.
BUG=b:216466985
TEST=zmake configure -b {krabby,kingler}
BRANCH=none
Signed-off-by: Andrew McRae <amcrae@google.com>
Change-Id: I914a1659fb4cc25e513e0aff1c3460855cd9f76d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3427097
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Migrate the corsola projects {kingler, krabby} to
the new interrupt config framework.
BUG=b:215258549
TEST=zmake configure -b {kingler,krabby}
BRANCH=none
Signed-off-by: Andrew McRae <amcrae@google.com>
Change-Id: I11fd96022199a56768c12a81ee813177f5bfa0bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3413593
Reviewed-by: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add basic LED implementation for Krabby.
BUG=none
TEST=ectool led (power|battery) <color>
manually verify
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I6117e44b404c21ab81126b8e0c317f07f4814e79
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3389068
Tested-by: Ting Shen <phoenixshen@chromium.org>
Auto-Submit: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL configures USB-C and charger drivers:
- TCPC C0: RT1718S, C1: ANX3447
- PPC C0/C1: NX20P3483
- Charger ISL9238C
- ChargeManager
BUG=b:203739613
TEST=Battery can be charged. C0/C1 can act as SNK and SRC.
BRANCH=none
Change-Id: I83c87c0059fbe3d9880fdd2a9d214782cfa12a31
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3306759
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@google.com>
Tested-by: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this file is unused
BUG=none
TEST=zmake configure -b krabby
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I0976c1bf75078fbf10fc015f9b5afcf53a8dce4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3354665
Reviewed-by: Rong Chang <rongchang@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Auto-Submit: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Configure ADC channels correctly, and also remove the unused isl9238c
code to make this CL compilable.
BUG=b:210754899
TEST=run `adc` command, verify vbus value looks reasonable
BRANCH=main
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: If29ffce4f626e11062cc406322480e1f34aed6f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3341474
Reviewed-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
|int_signal| was used to check interrupt signal to
protect from interrupt coming while processing FIFO.
Instead, use loop until all FIFO samples are processed,
as used in linux kernel sensor fifo routine.
[See for example see st_lsm6dsx_handler_thread() in
driver/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c].
BUG=b:207055975,b:129159505
BRANCH="asurada atlas chameleon dedede drallion endeavour fpmcu grunt
hatch icarus kalista keeby kukui mistral nami nocturne octopus poppy
puff quiche rammus sarien trogdor volteer zork"
TEST=testall, both cros_ec and zephyr.
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Change-Id: I3cfd63c73a7361522ddf42a686dcffdac38d8741
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3328808
Reviewed-by: Diana Z <dzigterman@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move corsola/usb_pd_policy to krabby folder. Kingler
hasn't configured USBC yet, and kingler/krabby use very
different USB-C components.
BUG=b:206553789 b:203739613
TEST=zmake testall
BRANCH=none
Change-Id: I2d0568e73135b81290c73d0af5f1d8ff73431ffd
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3306758
Tested-by: Eric Yilun Lin <yllin@google.com>
Auto-Submit: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move non-share code into krabby/usbc_config.c:
1. charger configs
2. bc12 configs
3. ppc configs
4. tcpc configs
5. VBUS ADC getter
BUG=b:207802869
TEST=zmake testall
BRANCH=none
Change-Id: I134c843826dcce536d5fa8b1d52e41ff786175a7
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3303264
Tested-by: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
move the daughterboard detection out of the usbc_config.c
BUG=b:207802869
TEST=zmake test all
BRANCH=none
Change-Id: Ie23915d116cfbfd161f640eeea342e18d2647216
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3303262
Auto-Submit: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Eric Yilun Lin <yllin@google.com>
Tested-by: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MT6360 is not used in krabby, so drop it off.
BUG=b:202808130
TEST=zmake testall
BRANCH=none
Change-Id: I22349799bca92d80e16eda5a712c8014fff85124
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3303261
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Eric Yilun Lin <yllin@google.com>
Tested-by: Eric Yilun Lin <yllin@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move corsola baseboard files and krabby files under
zephyr/projects/corsola.
Also, drop kingler cros-ec board since we are not using it yet,
all the development is under zephyr.
BUG=b:206553789
TEST=zmake testall
BRANCH=main
Change-Id: I7b0b56e4598ec049c0a1fecb8920d9134e0b3ae1
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3289582
Commit-Queue: Eric Yilun Lin <yllin@google.com>
Tested-by: Eric Yilun Lin <yllin@google.com>
Auto-Submit: Eric Yilun Lin <yllin@google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
To follow the guidelines in go/zephyr-variant.
next steps:
- restructure kingler layout
- move common configs into prj.conf
- move source files from cros-ec/krabby to zephyr
BUG=b:206553789
TEST=zmake -b krabby; zmake -b kingler
BRANCH=main
Change-Id: I145fcb90cca360f733ecad41d0fcc82283563634
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3289581
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Eric Yilun Lin <yllin@google.com>
Auto-Submit: Eric Yilun Lin <yllin@google.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
|