summaryrefslogtreecommitdiff
path: root/zephyr/projects/trogdor
Commit message (Collapse)AuthorAgeFilesLines
...
* zephyr: move usb-a configuration to DTSDawid Niedzwiecki2022-04-062-5/+6
| | | | | | | | | | | | | | | | | | Lazor and Brya define the usb_port_enable array in the board-specific code. Add the "cros-ec,usba-port-enable-pins" node to device-tree which generates the array automatically. This shouldn't affect the output binary. BUG=b:227472576 TEST=zmake testall && make buildall BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: Ib11e45fc41ec5b33bbe2d792802395d9cba1a80c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3569771 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: Lazor: Configure LEDs to use PWMParth Malkan2022-04-052-1/+52
| | | | | | | | | | | | | | Configure Lazor LEDs as PWMs BUG=b:227755022, b:194430340 TEST=zmake build lazor, manual LED test on Lazor BRANCH=none Signed-off-by: Parth Malkan <parthmalkan@google.com> Cq-Depend: chromium:3567463 Change-Id: I8f04718ec5538a7d4caf6f885bc4bedd65ffe88c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3564077 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* zephyr: LED: Move gpio-led-pins nodeParth Malkan2022-04-053-88/+91
| | | | | | | | | | | | | | | | This patch moves gpio_led_pins node into a separate gpio_led.dts file. It creates a way to support pwm_leds and gpio_leds for the same board just by changing the dts file in BUILD.py BUG=b:227755022, b:194430340 TEST=zmake build -lazor BRANCH=none Signed-off-by: Parth Malkan <parthmalkan@google.com> Cq-Depend: chromium:3569987 Change-Id: Iedfb4949e11c57fe093ec0a9b6e5a5de377c9ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3569986 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* zephyr: lazor: move UBC-C configuration into the devicetreeDawid Niedzwiecki2022-04-043-65/+48
| | | | | | | | | | | | | | | | | | Some of the USB-C related Lazor arrays are declared in a board-specific file. Fill the usbc node in dts which causes defining these arrays automatically. It reduces the board-specific code. The change shouldn't affect an output binary. BUG=b:227359762 TEST=zmake testall && make sure usbc works on Lazor BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: Id70f6785fc25ba89e08bf285b2a0c3be5c71c19c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3563140 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Dawid Niedzwiecki <dawidn@google.com>
* zephyr: LED: Split GPIO implementationParth Malkan2022-04-021-4/+4
| | | | | | | | | | | | | | | Currently, policy logic and setting GPIO pins are in the same file. This patch splits setting GPIO pins logic into a separate implementation. Also, the nodes common to both PWM and GPIO are renamed. BUG=b:227706373, b:194430340 TEST=zmake build -a, manual LED test on Lazor BRANCH=none Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I2bf38153b9f5db9113670d9c76f5667ed4d8725c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3566211 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* Revert "lazor: convert HOOK_INIT to SYS_INIT"Keith Short2022-04-013-25/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e105fe224b19c9210092672f477b09b90c6d9f64. Reason for revert: b:227661993: EFS2 broken after SYS_INIT changes Original change's description: > lazor: convert HOOK_INIT to SYS_INIT > > Convert all HOOK_INIT calls to the equivalent SYS_INIT. > > BUG=b:226434387 > BRANCH=none > TEST=zmake testall > > Signed-off-by: Keith Short <keithshort@chromium.org> > Change-Id: Ibab4047ffcba70606eea81d863e6d9db6219eb7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3553848 > Reviewed-by: Denis Brockus <dbrockus@chromium.org> Bug: b:226434387 Change-Id: Ib619ce036aeadf92dcb960783c81cc5379fb873c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3564804 Tested-by: Keith Short <keithshort@chromium.org> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: remove PLATFORM_EC_USB_PD_PORT_MAX_COUNT configDawid Niedzwiecki2022-04-011-1/+0
| | | | | | | | | | | | | | | | The PLATFORM_EC_USB_PD_PORT_MAX_COUNT config can be get based on dts. PLATFORM_EC_USB_PD_PORT_MAX_COUNT equals a number of instances with "named-usbc-port" compatible. BUG=b:176237074 TEST=zmake testall && make buildall BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: If66ef429f4b9070e95b9631247423392c811f916 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3539940 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: add "named-usbc-port" nodesDawid Niedzwiecki2022-04-012-0/+25
| | | | | | | | | | | | | | | | Add "named-usbc-port" nodes for all boards, even if they are empty. The change should allow counting ports based on "named-usbc-port" nodes number. BUG=b:176237074 TEST=zmake testall BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: I91fadc68dcd2a2e8c3ee288859292a9c5e46d965 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3557850 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: eliminate use of node path for battery supportDawid Niedzwiecki2022-03-291-5/+5
| | | | | | | | | | | | | | | | | | Creating the array board_battery_info bases on DT_PATH(batteries) call. Change it to use a compatible string that is more consistent and doesn't depend on a node name. Use "battery-smart" for that purpose. The commit shouldn't change the output binaries. BUG=b:226404277 TEST=zmake testall BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: I0c6ab3a02eb21c78c2b89480880a0d2ae8af3abb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3548917 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* lazor: convert HOOK_INIT to SYS_INITKeith Short2022-03-293-7/+25
| | | | | | | | | | | | | Convert all HOOK_INIT calls to the equivalent SYS_INIT. BUG=b:226434387 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Ibab4047ffcba70606eea81d863e6d9db6219eb7e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3553848 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* hooks: add HOOK_PRIO_POST_I2CKeith Short2022-03-292-2/+2
| | | | | | | | | | | | | | | | | Add the HOOK_PRIO_POST_I2C alias for (HOOK_PRIO_INIT_I2C+1). This more clearly identifies the intent of this priority level. Applied only to common code and to Zephyr boards. BUG=none BRANCH=none TEST=compare_build.sh TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Ia5b8c594e1f06ae1a982770f75b63bb4ba44191f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3553669 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* zephyr: remove prompt for wakeup-mask KconfigsMichał Barnaś2022-03-291-4/+0
| | | | | | | | | | | | | | | | This commit removes the Kconfig prompt for event and host event wakeup masks and enables them automatically based on device-tree nodes. If nodes that specify the masks exist, then the Kconfig will be enabled. BRANCH=main BUG=b:222689734 TEST=zmake testall, grep for WAKEUP Kconfigs in .config Change-Id: I6d85d7118e74c668120129879c32ade93169e761 Signed-off-by: Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3525177 Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* zephyr: Add common led implementation to shim dirParth Malkan2022-03-223-364/+1
| | | | | | | | | | | | | | | | | | Current implementation supports gpio based leds. It has been tested on lazor board and can be expanded to other boards. Kconfig.led_dt will eventually be replaced by Kconfig.led once the shim layer supports PWM based LEDs as well and each board has added led.dts policy file BRANCH=None BUG=b:226019522, b:194430340 TEST=manual led test on lazor Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I761d5d52bf91a9a44bb70d421c54634f5cbb795a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3540926 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* zephyr: change config that enables LED PWM in CMakeListsMichał Barnaś2022-03-221-1/+1
| | | | | | | | | | | | | | This commit fixes the misleading comment in lazor led implementation and changes the config option that adds the led_pwm.c to compilation. BRANCH=main BUG=b:222684744 TEST=zmake testall Change-Id: Ied2ae753b2a2e32243d07697b8fb05d4a06d1f53 Signed-off-by: Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3528407 Reviewed-by: Aaron Massey <aaronmassey@google.com>
* zephyr: Set gpio pin nodes and update set color fnParth Malkan2022-03-213-28/+91
| | | | | | | | | | | | | | Convert led_set_color fn to make use of devicetree to set gpio pins instead of using hard-coded GPIO pin enums BRANCH=None BUG=b:225917471, b:194430340 TEST=manual led test on lazor Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I08f0b82d7db00370dc9ebe6e016d822645fea1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3383912 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* i2c: Add addr_flags and cmd to board_allow_i2c_passthru()Ricardo Quesada2022-03-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL adds addr_flags and cmd_id (AKA offset) to board_allow_i2c_passthru(). This CL is a kind-of-cherrypick of this other CL: https://crrev.com/c/1588492 BRANCH=none BUG=b:135642493 TEST=make buildall passes tested in Madoo where I manually added a board_allow_i2c_passthru() function that was blocking port 5 (battery) and did: With EC unlocked: dut # ectool i2cread 8 0x05 22 1 Read from I2C port 5 at 0x16 offset 0x1 = 0x67 With EC locked: dut # ectool i2cread 8 0x05 22 1 EC result 4 (ACCESS_DENIED) Change-Id: Ifba59f21f63f99345b81dd250296214a5cd29eba Signed-off-by: Ricardo Quesada <ricardoq@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3466422 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Ricardo Quesada <ricardoq@chromium.org> Auto-Submit: Ricardo Quesada <ricardoq@chromium.org> Commit-Queue: Ricardo Quesada <ricardoq@chromium.org>
* zephyr: Remove use of GPIO_OUT_HIGH/LOW from dts filesKeith Short2022-03-161-17/+17
| | | | | | | | | | | | | | | | The correct Zephyr GPIO flags are GPIO_OUTPUT_HIGH and GPIO_OUTPUT_LOW. Use these flags in place of GPIO_OUT_HIGH and GPIO_OUT_LOW in all devicetree files. BUG=b:224821728 BRANCH=none TEST=zmake testall TEST=verify Herobrine boots the AP Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I3b21920a7da21973467dfcf04de5bed7a2bdb2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3526269 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: support smart USB-A port controlPeter Marheine2022-03-151-0/+1
| | | | | | | | | | | | | | | | | | | | | This enables support for "smart" USB-A ports in addition to the existing "dumb" support, allowing one of them to be selected as well as implementing kconfig support for most of the other options for "smart" ports. For existing boards that enabled USB-A support with the default "dumb" support, their configuration is changed to specifically select that mode because the new choice option cannot have a default. BUG=b:223937974 TEST="smart" port control can be turned on for Nereid BRANCH=none Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: If5b0fb393451d31a937c73be2aa3b9623c69307f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3517929 Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr: Convert HOOK_CHIPSET calls to AP power callbacksAndrew McRae2022-03-151-18/+37
| | | | | | | | | | | | | Convert HOOK_CHIPSET_ hooks to AP power callback handling. BUG=b:223800037 TEST=zmake testall BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I1a9574cacd5746467494facf9133f360a31cc3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3518465 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: shim: drop empty pwm.dts overlaysFabio Baltieri2022-03-152-11/+0
| | | | | | | | | | | | | | | Make the PWM shim compile with no named-pwms node defined and drop all empty pwm.dts files. This also drops the one adlrvp_npcx, that currently defines an fan PWM but no matching named-fan. BRANCH=none BUG=b:217741090 TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ib2d4e3a12ed688ba38fb6bbba9afb11f9d900ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3521941 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: UTIL_LISTIFY deprecated, use LISTIFY insteadAl Semjonovs2022-03-081-1/+1
| | | | | | | | | | | | | | | Following upstream change, rename UTIL_LISTIFY to LISTIFY BUG=none BRANCH=none TEST=zmake testall Cq-Depend: chromium:3509655 Signed-off-by: Al Semjonovs <asemjonovs@google.com> Change-Id: I24db1ca4cd9bb63379b144b91cc3b25f9dd30e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3508829 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: shim: set generic-pwm-channel on herobrine or trogdorFabio Baltieri2022-03-082-0/+2
| | | | | | | | | | | | | | | | | | | | | Set the generic-pwm-channel label on ARM platforms so that they work correctly with the current AP firmware. It should restore the order in which they were declared before: 66fa9b729c zephyr: replace the ecos kblight driver for a deshimmed one BRANCH=none BUG=b:217741090, b:222516095 TEST=zmake testall TEST=run on lazor Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Reported-by: Michał Barnaś <mb@semihalf.com> Tested-by: Michał Barnaś <mb@semihalf.com> Change-Id: I09ce1bf3ba1aa6617fbcd3631727a5a5d942aead Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3503648 Reviewed-by: Michał Barnaś <mb@semihalf.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: add a new displight Zephyr driverFabio Baltieri2022-03-083-10/+17
| | | | | | | | | | | | | | | | | Add a new Zephyr driver for controlling the display backlight, very similar to the keyboard backlight one, using a devicetree node and Zephyr PWM APIs. This is used by the host through the PWM HC functions. BRANCH=none BUG=b:217741090 TEST=zmake testall Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ibd48aaa750eed9fb7a85568cfdbd166a41498021 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3500629 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: fix leds behavior on lazorMichał Barnaś2022-03-041-2/+2
| | | | | | | | | | | | | | | | This commit fixes the handling of leds definitions in device tree and changes the led tick to be 1s instead of default 200ms. Only the first node of led was set properly, other ones were causing the read outside of an array. BUG=b:222684744 BRANCH=main TEST=flash and check if leds are blinking as they should Change-Id: Id890261e38b7a61dff4827e0a6f192ad10b6ab32 Signed-off-by: Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3500522 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* zephyr: shim: replace few pwm flags with PWM_POLARITY_NORMALFabio Baltieri2022-02-252-2/+2
| | | | | | | | | | | | | | | | | Zephyr PWM flag is commonly either PWM_POLARITY_NORMAL or PWM_POLARITY_INVERTED. Replacing few instances of flag being set to "0" for PWM_POLARITY_NORMAL to match how this is commonly done in Zephyr upstream. BRANCH=none BUG=b:217741090 TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I7c36989696824e2bf2401cc5695978a71197b668 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3488368 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: Fix GPIO includes for trogdorKeith Short2022-02-257-27/+9
| | | | | | | | | | | | | | Use the Zephyr driver GPIO include for Zephyr shim code instead of the legacy EC GPIO header. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I0db2fc70e2d918c4c2a8b28e8e9f70f095fc6bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489251 Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: split legacy and shimmed codes into librariesKeith Short2022-02-251-1/+1
| | | | | | | | | | | | | | | Split the legacy EC code and shimmed code into separate libraries. This allows for declaring different compiler definitions to the legacy and shim code. BUG=b:218856245 BRANCH=none TEST=zmake testall Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: Ice25c21409d33594e7d465092ad5066be7336dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3489101 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zephyr: keyboard: set active low flag for column 2Keith Short2022-02-251-1/+1
| | | | | | | | | | | | | | | | | Explicitly set the active low flag for the column 2 output pin. Modify cros_kb_raw_set_col2() to drive the logic level instead of the physical state of the pin when CONFIG_PLATFORM_EC_KEYBOARD_COL2_INVERTED is enabled. BUG=b:218904113 BRANCH=none TEST=Verify all keypresses on herobrine using "ksstat on" Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: If6098226d5551c2a3aa8374f7b17e2fad396c006 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3488786 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr: update keyboard drivers to use Zephyr GPIOsKeith Short2022-02-241-2/+2
| | | | | | | | | | | | | | | Add alias node gpio-kbd-kso2 to replace the legacy GPIO_KBD_KSO2 signal. BUG=b:218904113 BRANCH=none TEST=On herobrine, verify all keypresses Signed-off-by: Keith Short <keithshort@chromium.org> Change-Id: I834cc7af68e721597e7509187266c509a50fab12 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3485956 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Reviewed-by: Andrew McRae <amcrae@google.com> Commit-Queue: Andrew McRae <amcrae@google.com>
* zephyr: config: drop a bunch of CONFIG_PLATFORM_EC_PWM=yFabio Baltieri2022-02-241-1/+0
| | | | | | | | | | | | | | | Drop all CONFIG_PLATFORM_EC_PWM=y, this is now default if CONFIG_PWM=y so the platform config is now redundant. Add explicit CONFIG_PWM=y for npcx_evb configs. BRANCH=none BUG=b:217926701 TEST=zmake configure -b volteer Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ia785d37929bd550f46f05d5c84b11d9e1de5339a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3488367 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* zephyr: replace the ecos kblight driver for a deshimmed oneFabio Baltieri2022-02-182-9/+10
| | | | | | | | | | | | | | | | | | | | | | | Replace the ECOS pwm_kblight driver with one using the Zephyr APIs for pwm and devicetree. BRANCH=none BUG=b:217741090 TEST=build and run on volteer, play with the keyboard backlight TEST=zmake configure -b brya TEST=zmake configure -b herobrine TEST=zmake configure -b skyrim TEST=zmake configure -b lazor TEST=zmake configure -b npcx9 TEST=zmake configure -b npcx7 TEST=zmake configure -b nivviks TEST=zmake configure -b nereid Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Idb58f6bbecad4337148fd6a279ef0625247df6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3468505 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* Reland "zephyr: Remove unused enum-name entries"Andrew McRae2022-02-161-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0f6242e8bd99e0b1fe4d2f15e95bf48eb7daa516. Someone added a new reference to one of the removed enums. Reason for revert: Fixed build. BUG=b:216466985 TEST=zmake testall BRANCH=none Original change's description: > Revert "zephyr: Remove unused enum-name entries" > > This reverts commit 112bc3616b55421af4ae5003c542e9a425128650. > > Reason for revert: suspected at fault for postsubmit failures > https://ci.chromium.org/p/chromeos/builders/postsubmit/firmware-zephyr-postsubmit/14846 > > Original change's description: > > zephyr: Remove unused enum-name entries > > > > After removal of the unsupported projects, > > take another run through the enum-names to > > remove the unused entries. > > > > BUG=b:216466985 > > TEST=zmake testall > > BRANCH=none > > > > Signed-off-by: Andrew McRae <amcrae@google.com> > > Change-Id: Id652c4fda7dd64a59b3776bb52640413a31e4e3e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3446945 > > Reviewed-by: Tristan Honscheid <honscheid@google.com> > > Reviewed-by: Keith Short <keithshort@chromium.org> > > Commit-Queue: Keith Short <keithshort@chromium.org> > > Bug: b:216466985 > Change-Id: I97e4ba659b15a8860d408ec46a6629a8d292b05e > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3465516 > Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> > Tested-by: Jack Rosenthal <jrosenth@chromium.org> > Auto-Submit: Jack Rosenthal <jrosenth@chromium.org> > Reviewed-by: Keith Short <keithshort@chromium.org> > Commit-Queue: Keith Short <keithshort@chromium.org> Bug: b:216466985 Change-Id: I51284582ad8e17ab2016b65f8a31944702d70579 Signed-off-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3466674 Reviewed-by: Dawid Niedzwiecki <dawidn@google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* Revert "zephyr: Remove unused enum-name entries"Jack Rosenthal2022-02-151-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 112bc3616b55421af4ae5003c542e9a425128650. Reason for revert: suspected at fault for postsubmit failures https://ci.chromium.org/p/chromeos/builders/postsubmit/firmware-zephyr-postsubmit/14846 Original change's description: > zephyr: Remove unused enum-name entries > > After removal of the unsupported projects, > take another run through the enum-names to > remove the unused entries. > > BUG=b:216466985 > TEST=zmake testall > BRANCH=none > > Signed-off-by: Andrew McRae <amcrae@google.com> > Change-Id: Id652c4fda7dd64a59b3776bb52640413a31e4e3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3446945 > Reviewed-by: Tristan Honscheid <honscheid@google.com> > Reviewed-by: Keith Short <keithshort@chromium.org> > Commit-Queue: Keith Short <keithshort@chromium.org> Bug: b:216466985 Change-Id: I97e4ba659b15a8860d408ec46a6629a8d292b05e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3465516 Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Tested-by: Jack Rosenthal <jrosenth@chromium.org> Auto-Submit: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* zephyr: Remove unused enum-name entriesAndrew McRae2022-02-151-16/+0
| | | | | | | | | | | | | | | | | After removal of the unsupported projects, take another run through the enum-names to remove the unused entries. BUG=b:216466985 TEST=zmake testall BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Id652c4fda7dd64a59b3776bb52640413a31e4e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3446945 Reviewed-by: Tristan Honscheid <honscheid@google.com> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* lazor: Adjust Zephyr stack sizes (from taskinfo).Andrew McRae2022-02-121-1/+2
| | | | | | | | | | | | | | | Update the stack sizes according to patch from Nuvoton. Enable the taskinfo cmd to view stack sizes, and define SOC_SERIES_NPCX7 so that new stack sizes are picked up. BUG=b:218820985 TEST=zmake configure -b lazor; flash & run BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I9305d460fd688ccaa7b6d8124fa18989268b87c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3454926 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* zephyr: Create Kconfig.usbaSam Hurst2022-02-111-0/+1
| | | | | | | | | | | | | | | Split USBA Kconfig options from Kconfig.usbc and place in separate file named Kconfig.usba. BUG=b:208437225 TEST=Verified Kconfig options with menuconfig zmake configure -b herobrine_npcx9 BRANCH=main Signed-off-by: Sam Hurst <shurst@google.com> Change-Id: Ifaac7cd4e44390b0c216fc3bf5588c8bdf851d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3444582 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* write protect: extract checking write protectDawid Niedzwiecki2022-02-112-1/+8
| | | | | | | | | | | | | | | | | | | | | | The write-protect state can be checked on 2 pins GPIO_WP or GPIO_WP_L. The CONFIG_WP_ACTIVE_HIGH config is used to distinguish these two cases. Move the checking the config and pin state to a separate header file. For Zephyr, start using the gpio_get_level function that takes into account the GPIO_ACTIVE_LOW flag. Also, use 'gpio-wp' alias to the WP pin instead of the legacy enum-name property and 'int-wp' alias to the WP GPIO interrupt. BUG=b:211779766 TEST=zmake testall & make sure WP works BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: I70bfbcd5e539fcc8cd157f2feae1a6c8e25083a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3447404 Reviewed-by: Andrew McRae <amcrae@google.com> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
* TCPM: Change the PS8xxx I2C flags name to match the driverSam Hurst2022-02-101-2/+2
| | | | | | | | | | | | | | | | Change the PS8xxx I2C flags name from PS8751_I2C_ADDR to PS8XXX_I2C_ADDR. BRANCH=main BUG=b:194432779 TEST=make -j buildall Signed-off-by: Sam Hurst <shurst@google.org> Change-Id: Ie8ac1c922c46bb425b7e7b1a39173872d48f6353 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3449669 Tested-by: Sam Hurst <shurst@google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Sam Hurst <shurst@google.com>
* switchcap: Migrate legacy GPIO API to Zephyr APIAndrew McRae2022-02-103-17/+17
| | | | | | | | | | | | | Migrate switchcap shim code to use Zephyr API for GPIO access. BUG=b:216466985 TEST=zmake testall BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Ie0ca2f7d5f0ca73c15a6c438783f5965a40d7c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3446420 Reviewed-by: Keith Short <keithshort@chromium.org>
* zephyr: update definition of WP pinDawid Niedzwiecki2022-02-091-1/+1
| | | | | | | | | | | | | | | | | | The WP pin for most boards is logically high when the pin is low - WP is active when the pin is low. Add GPIO_ACTIVE_LOW flag to the WP_L pins. It allows using Zephyr GPIO API to get the logical state without checking CONFIG_WP_ACTIVE_HIGH define. BUG=b:211779766 TEST=zmake testall BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: I48594c5c7bc4deb452d6922d0b07f57055240d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3437445 Reviewed-by: Keith Short <keithshort@chromium.org> Reviewed-by: Andrew McRae <amcrae@google.com> Commit-Queue: Dawid Niedzwiecki <dawidn@google.com>
* lazor: Use npcx7m7fc instead of npcx7m6fcAndrew McRae2022-02-091-1/+8
| | | | | | | | | | | | | | | | | | In spite of the fact that lazor has a npcx7m6fc EC, force it to use npcx7m7fc so that the extra code RAM is accessible. These parts are the same die, just binned separately, and the extra RAM is not tested. However enabling the options required for zephyr requires the extra space. BUG=b:218401333 TEST=zmake configure -b lazor BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Ia24415d8521da4ed894f3feaf6568410526e2f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3445706 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* lazor: Build lazor on ZephyrAndrew McRae2022-02-072-58/+5
| | | | | | | | | | | | | | Fix NPCX config so that lazor Zephyr image builds and runs. Still has a problem with jumping to RW image. BUG=none TEST=build and run BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Ia61a091c243c80d6d742d67d7c2024656d10b677 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3443520 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* lazor: Use Zephyr APIs for migrated codeAndrew McRae2022-02-0310-69/+302
| | | | | | | | | | | | | Use the zephyr APIs for lazor board-specific code. BUG=b:217460464 TEST=zmake configure -b lazor BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Ica1fbccab29d7d2c05ced32815099329735ac42e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3431606 Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
* lazor: Copy board level code to lazor zephyr projectAndrew McRae2022-02-0310-14/+1004
| | | | | | | | | | | | | | Copy board level code for lazor to lazor zephyr project. Minimal changes to code. BUG=b:217460464 TEST=zmake configure -b lazor BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Ic806eecd7ed8ebd0b3dcf022a231cebaf29b7b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3431605 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* trogdor: Remove trogdor from Zephyr projectsAndrew McRae2022-02-029-814/+0
| | | | | | | | | | | | | Clean up old unsupported Zephyr projects (trogdor/trogdor) BUG=b:217456306 TEST=zmake testall BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: Id90a9ab9e57c3c5c4b34dc4c72c80eb04c072f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3430643 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
* zephyr: Remove enum-names that are not used by common codeAndrew McRae2022-02-022-6/+0
| | | | | | | | | | | | | | | | Clean up the named-gpios enum-names to remove names that are not referenced in common code or shimmed in baseboard code. BUG=b:216466985 TEST=zmake testall BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Cq-Depend: chromium:3426250, chromium:3427097 Change-Id: Ifb65c76ef17afec7df1e0b857f666c600d60e6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3428601 Reviewed-by: Aaron Massey <aaronmassey@google.com>
* zephyr: Fix named-gpios et al to drop #gpio-cellsAndrew McRae2022-02-012-46/+0
| | | | | | | | | | | | | | | | | | | | | The #gpio-cells property is only required when the referenced node is a GPIO controller. named-gpios is not a GPIO controller, and cannot be used as a GPIO reference. DTS and code can refer to named-gpios directly, and then retrieve the GPIO from the named-gpio gpios property. Also rename irq-gpio to irq-pin so that DTS does not complain about missing #gpio-cells. BUG=b:216402316 TEST=zmake testall BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Cq-Depend: chromium:3418800, chromium:3418799, chromium:3423294 Change-Id: Ifdea8662647c092950962d3b6b0f32acda23aa5a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3412626 Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* zephyr: Convert wake-pins to use interrupt configAndrew McRae2022-02-014-10/+20
| | | | | | | | | | | | | | Convert the hibernate wake-pins to use the new interrupt config. BUG=b:214608987,b:216869126 TEST=zmake testall BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Cq-Depend: chromium:3423294,chromium:3423295 Change-Id: Iaaf03da88ead8bce7b2b428c265434a5a17b4ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3422856 Reviewed-by: Wai-Hong Tam <waihong@google.com>
* lazor: Migrate GPIO access to Zephyr APIAndrew McRae2022-01-312-4/+4
| | | | | | | | | | | | | Migrate the GPIO access to use the Zephyr GPIO API. BUG=b:216466985 TEST=zmake configure -b lazor BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I4a7b516977aa2d9ba193b6c1ab48d32134bc4da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3426252 Reviewed-by: Aaron Massey <aaronmassey@google.com>
* zephyr: Rename irq-gpio to irq-pinAndrew McRae2022-01-282-44/+44
| | | | | | | | | | | | | | Avoid the need for #gpio-cells by renaming irq-gpio to irq-pin BUG=b:216402316 TEST=zmake testall BRANCH=none Signed-off-by: Andrew McRae <amcrae@google.com> Change-Id: I3c489e7835c487e45ef86b838fab96f55336e061 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3419357 Reviewed-by: Denis Brockus <dbrockus@chromium.org>
View Lorry Controller Status