summaryrefslogtreecommitdiff
path: root/zephyr
Commit message (Collapse)AuthorAgeFilesLines
* console: Optionally drop output from ISRsstabilize-15317.B-mainAndrew McRae2023-01-173-3/+23
| | | | | | | | | | | | | | | | Optionally drop console output originating from interrupt level, to avoid printk locking up the EC for any length of time. BUG=b:265594963 TEST=Verify that logs from ISRs are not printed. BRANCH=none Change-Id: Ib6241d66bb3ec518439b46860804d928fd3fcfdf Signed-off-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4165986 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* flash: allow zero num_banks_desc in flash_info requestTing Shen2023-01-162-3/+26
| | | | | | | | | | | | | | | | | | | | | | | Some external tools (e.g. flashrom) sends EC_CMD_FLASH_INFO with num_banks_desc=0 to get the total number of banks. EC should allow this type of request. Also add a test to cover this use case. BUG=b:265472751 TEST=1) `flashrom -p ec -w <ec.bin>` on tentacruel 2) ./twister -T zephyr/test/drivers/ \ --sub-test drivers.flash.page_layout 3) ./twister -T zephyr/test/drivers/ --sub-test drivers.flash BRANCH=none Change-Id: Iab97ac754bac87067f949cf9435156be91b07ebc Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4167539 Tested-by: Chen-Tsung Hsieh <chentsung@chromium.org> Reviewed-by: Patryk Duda <patrykd@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Patryk Duda <patrykd@google.com>
* Revert "markarth: Modify GPIO config"firmware-ti50-prepvt-15315.B-mainLeilaCY Lin2023-01-162-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2366c6f0c8d71b107aa02fe43168f77c190ebc16. Reason for revert: <Keep original design> Original change's description: > markarth: Modify GPIO config > > Add markarth-specific GPIO_LID_SW for lid switch. > > LOW_COVERAGE_REASON=no unit tests for Markarth yet, b/247151116 > BUG=b:264208874 > BRANCH=none > TEST=zmake build Markarth success > > Change-Id: I2559ec953a6047622b1f923ad6e1e38836709165 > Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4135919 > Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> > Reviewed-by: Chao Gui <chaogui@google.com> > Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> > Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> > Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Bug: b:264208874 Change-Id: Ied6f1576f4546b233f956b86ef61241247ac3210 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4159632 Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com> Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com>
* Winterhold: Add fw_config to support two base sensorsjohnwc_yeh2023-01-162-1/+37
| | | | | | | | | | | | | | | | Use fw_config to separate LIS2DW12 and BMI323. LOW_COVERAGE_REASON=Skyrim board tests not created yet: b/247151116 BRANCH=None BUG=b:262321157 TEST=zmake build winterhold Change-Id: I71d78f232867a54c46a003308590521fd687d94b Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4135921 Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Robert Zieba <robertzieba@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* ap_power: Reduce power signal debug name storageAndrew McRae2023-01-162-0/+15
| | | | | | | | | | | | | | | | | Use shortened power signal debug names by default, unless the BRINGUP config option is set. This reduces flash space usage by around 520 bytes. BUG=none TEST=Verify on craask BRANCH=none Change-Id: I69bdb74e7b272b9f5b842b888052e04e3e659c01 Signed-off-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4165982 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* zephyr: make the test emulator's PD revision configurableJameson Thies2023-01-134-6/+14
| | | | | | | | | | | | | | | | This CL updates the tcpci partner emulator to have an internal variable define how it responds to Get_Revision, instead of hardcoding it's RMDO to 0x31000000 (USBPD 3.1). BUG=b:236868370 BRANCH=None TEST=./twister -p native_posix -p unit_testing Signed-off-by: Jameson Thies <jthies@google.com> Change-Id: Ib212383ce2a29c87f7284a971b2ad96cce6b68c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4159990 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: Test all ports for correct pd informationJason Yuan2023-01-132-4/+7
| | | | | | | | | | | | | | | | | pd_chip_info is tested for all ports instead of just port 0. BUG=b:261874683 TEST=twister BRANCH=none Change-Id: I338af9781539cd1fe325410d085593832f776120 Signed-off-by: Jason Yuan <jasonyuan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4159971 Auto-Submit: zhi cheng yuan <jasonyuan@chromium.org> Tested-by: zhi cheng yuan <jasonyuan@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com>
* skyrim : Remove EC variant for MorthalChao Gui2023-01-1311-689/+0
| | | | | | | | | | | | | LOW_COVERAGE_REASON= cancelled device specific configuration BUG=none BRANCH=none TEST=zmake compare-builds skyrim Change-Id: I2f806322dea1a7c3629311e6c4f49cb61c22c444 Signed-off-by: Chao Gui <chaogui@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4163824 Reviewed-by: Diana Z <dzigterman@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* geralt: remove rt9490-bc12 dt nodeTing Shen2023-01-132-9/+3
| | | | | | | | | | | | | | | | | RT9490's charger and bc12 nodes are merged in CL:4010984. update Geralt dts to reflect this change. BUG=b:264841530 TEST=USB_CHG task doesn't crash BRANCH=none Change-Id: I9b5d057d713ca563095a55e8d2b25a7da9b3d4c4 Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4159978 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Simon Zhou <zhouguohui@huaqin.corp-partner.google.com>
* syv682x: cached force discharge configEric Yilun Lin2023-01-131-2/+10
| | | | | | | | | | | | | | | | | | | | syv682x vbus discharge function is getting called from ppc_dev_is_connected to reset the discharge config many times. We cached the force discharge config to reduce the i2c traffics on IT81202 i2c ports. BUG=none TEST=i2c traffic reduces. FRS is working. BRANCH=none Change-Id: Iebae413d8f6621b8c99dc28c744220f54d420062 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4160813 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Auto-Submit: Eric Yilun Lin <yllin@google.com> Tested-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
* Default charger current derating to 5%Peter Marheine2023-01-122-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Not derating seems like a common pitfall that can cause problems with some chargers, so set a reasonably conservative default. 5% is chosen as the most common derating factor used among boards today (counting occurrences in source code, so this may undercount 5% occurrences because several projects set 5% at the project rather than board-level): 1. 38 x 5% 2. 23 x 4% 3. 6 x 10% 3. 2 x 3% 4. 1 x 2% Boards that currently configure this setting are modified only to continue building without warnings regardless of whether they use the new default value in order to signal that they were explicitly configured. BUG=b:260774380 TEST=make buildall / zmake build -a BRANCH=none Change-Id: I017849d38572fbc48090ae1fa2c539b808e426f9 Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4109651 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* dts: Remove upstream SHI driver in favor of our ownTristan Honscheid2023-01-124-32/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The upstream commit 3ae105e76b1a47c013d6982a79b3f2fa36b19963 introduces an upstream driver that is conflicting with what we have locally in our device tree by merging in some properties (buffer-rx-size) that we don't have declared in our YAML yet. It also creates a naming conflict with our own `struct shi_reg`. This is blocking downstreaming so delete the device tree nodes introduced by the upstream code for now. Rename our structure to `struct cros_shi_reg`. BUG=None BRANCH=None TEST=Built several boards against Zephyr ToT TEST=./twister -T zephyr/test/drivers/ Signed-off-by: Tristan Honscheid <honscheid@google.com> Cq-Depend: chromium:4155744 Cq-Depend: chromium:4155745 Cq-Depend: chromium:4155746 Change-Id: I3c4b44eaf9692fd0411ef7eee411c1fa0eb1f58e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4158571 Tested-by: Tristan Honscheid <honscheid@google.com> Commit-Queue: Tristan Honscheid <honscheid@google.com> Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: npcx9m7f: Add 360 kB padding to output imageScott Collyer2023-01-121-1/+8
| | | | | | | | | | | | | | | | | | | | This CL adds required padding to the output binary so that the image size will match the npcx9m7f reported image size which will allow flashrom to work properly. BUG=b:260549463 BRANCH=none TEST=ec.bin for rex is now 1MB -rw-r--r-- 1 scollyer primarygroup 1048576 Jan 4 14:38 ec.bin Change-Id: I73ec9e7169a5cf53ee876c8eb028377bde0d249e Signed-off-by: Scott Collyer <scollyer@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4137151 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Madhu 🌱 <mparuchuri@google.com> Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org>
* zephyr: enable Kconfig based on the devicetree - motionsenseMichał Barnaś2023-01-1212-11/+5
| | | | | | | | | | | | | | | This commit adds automatic selection of required Kconfig options based on the device tree nodes for module: motionsense BUG=b:251812799 BRANCH=main TEST=run twister and zcompare script Change-Id: Icbe3f6b503d803a8d75e17c5eb73993d6be8501c Signed-off-by: Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3982648 Reviewed-by: Wai-Hong Tam <waihong@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: enable Kconfig based on the devicetree - keyboardMichał Barnaś2023-01-123-3/+7
| | | | | | | | | | | | | | | This commit adds automatic selection of required Kconfig options based on the device tree nodes for module: keyboard BUG=b:251812799 BRANCH=main TEST=run twister and zcompare script Change-Id: I7efb4ed68b475b62d5a399d0f68d2b9e0f1c1bf4 Signed-off-by: Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3982647 Reviewed-by: Yuval Peress <peress@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* shim/bc12_rt9490: fix compatibleDino Li2023-01-121-2/+2
| | | | | | | | | | | | | | | Correct shim code since both yaml and dtsi compatibility are "richtek,rt9490". BRANCH=none BUG=none TEST=The rt9490_interrupt isr is registered correctly. Change-Id: Idb1e3d19060852514ba98a513f2f5f34cbda5bc3 Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4154450 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* battery: extend BATTERY_GET_STATIC hostcmd for 32-byte stringsPeter Marheine2023-01-121-0/+31
| | | | | | | | | | | | | | | | | | | | | | | The Smart Battery Specification defines a string as up to 31 characters, and nissa project has encountered some batteries where the existing 11-character strings for v1 of BATTERY_GET_STATIC are insufficient to differentiate some batteries that can be used on a given device. This change adds a new version of this host command that extends the strings fields to each accommodate up to 31 characters of data, which should be enough to support all smart batteries compliant with the latest version of the specification. BUG=b:263920422 TEST=`ectool battery` with updated ectool works on Nereid and uses the new hostcmd version. If EC support for v2 or v1 is disabled, older command versions are used. BRANCH=nissa Change-Id: Ia6a3a917051d5e641e7d38ef6936ec7174cb8aab Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4150669 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* craask: add Fw_config structure for thermal solution controlben chen2023-01-126-14/+287
| | | | | | | | | | | | | | | | | | | | | | support thermal solution flag of cbi fw_config, decided 6w/15w thermal solution by FW_THERMAL flag. FW_THERMAL flag address bit10 size 3 of cbi fw_config: 0 :FW_THERMAL_6W 1 :FW_THERMAL_6W 2 :FW_THERMAL_15W BUG=b:264701585 BRANCH=none TEST=check with thermal table workable. Change-Id: Iaa70a86ffc08d175422ededc479479bbfed52d30 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4085594 Code-Coverage: Andrew McRae <amcrae@google.com> Reviewed-by: Andrew McRae <amcrae@google.com> Commit-Queue: Andrew McRae <amcrae@google.com>
* Markarth : Disable chg_alt function.Logan_Liao2023-01-124-54/+5
| | | | | | | | | | | | | | | | | | | | | Markarth just have one charger-ISL9241, so disable chg_alt function. LOW_COVERAGE_REASON=no unit tests for Markarth yet, b/247151116 BUG=none BRANCH=none TEST=zmake build Markarth success. Change-Id: Ic7724248e8ed9d1909082ee7d10d5e9d6d05dbe2 Signed-off-by: Logan_Liao <Logan_Liao@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4145100 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Chao Gui <chaogui@google.com> Tested-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Commit-Queue: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Robert Zieba <robertzieba@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* nissa: add a board for Nereid with IT81302 CXPeter Marheine2023-01-124-1/+34
| | | | | | | | | | | | | | | | | Some devices have been reworked to the use the newer CX EC; add a target to build firmware targeting that chip. Existing firmwares should work on the CX chip, but a new target is required to take advantage of some of the new chip's improvements. BUG=b:240485526 TEST=zmake build nereid_cx; flash on reworked board BRANCH=none Change-Id: I5a282c6990f44adfcf792e2889da008688a4d079 Signed-off-by: Peter Marheine <pmarheine@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4159451 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr/test/drivers/flash: Add flash bank API testsPatryk Duda2023-01-112-0/+106
| | | | | | | | | | | | | | | | | | | | | | Introduce unit tests for functions that implement basic API for operating on information about flash sectors. Tests are run only when CONFIG_PLATFORM_EC_USE_ZEPHYR_FLASH_PAGE_LAYOUT is enabled. BUG=b:239712345 BRANCH=none TEST=./twister -v -i -T zephyr/test/drivers/ --test external/platform/\ ec/zephyr/test/drivers/drivers.flash.page_layout Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: I6e1a37e7137b49983fc3447ebdc9fff73df43458 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4110952 Reviewed-by: Edward Hill <ecgh@chromium.org> Reviewed-by: Bobby Casey <bobbycasey@google.com> Tested-by: Patryk Duda <patrykd@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Patryk Duda <patrykd@google.com>
* zephyr/test/drivers: Add flash page layout test variantPatryk Duda2023-01-112-20/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | Introduce drivers.flash test variant with CONFIG_PLATFORM_EC_USE_ZEPHYR_FLASH_PAGE_LAYOUT enabled. If the option is enabled, we use Zephyr's flash page API to get information about flash sectors, sizes, etc. instead of providing these information in EC. Since the API provides flash sector description, we only support flash info version 2 host command. Also output from "flashinfo" command is slightly different. BUG=b:239712345 BRANCH=none TEST=./twister -v -i -T zephyr/test/drivers/ --test external/platform/\ ec/zephyr/test/drivers/drivers.flash.page_layout Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: I1f459232f6bc1c786e8c16bf2537f68229b90862 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4118762 Reviewed-by: Bobby Casey <bobbycasey@google.com> Commit-Queue: Patryk Duda <patrykd@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Patryk Duda <patrykd@google.com>
* shim/src/flash: Add functions for providing flash sectors infoPatryk Duda2023-01-113-0/+195
| | | | | | | | | | | | | | | | | | | | | Introduce Zephyr counterparts of functions that provide information about flash sectors, total number of sectors, size of array to describe sector types, etc. These functions use Zephyr flash pages API. To use functions, enable PLATFORM_EC_USE_ZEPHYR_FLASH_PAGE_LAYOUT config. BUG=b:239712345 BRANCH=none TEST=zmake build -a --clobber Signed-off-by: Patryk Duda <pdk@semihalf.com> Change-Id: I9ee9a8f36401e4643adfa150c745ba502b72c36a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4030378 Tested-by: Patryk Duda <patrykd@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Patryk Duda <patrykd@google.com>
* zephyr: it8xxx2: Include the separated dtsi fileTim Lin2023-01-105-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Some device nodes have been separated from it8xxx2.dtsi to it81xx2.dtsi, so these boards need to include the separated dtsi file. Depend: https://github.com/zephyrproject-rtos/zephyr/pull/53512 Cq-Depend: chromium:4147373 BRANCH=none BUG=none TEST=zmake build it8xxx2_evb --clobber TEST=Change zephyr_board(project/it8xxx2_evb/BUILD.py) to the following chip version: zephyr_board="it81202bx" zephyr_board="it81302bx" zephyr_board="it81202cx" zephyr_board="it81302cx" Change-Id: I60756e07373b16c9aeb6740913ea323137161cd9 Signed-off-by: Tim Lin <tim2.lin@ite.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3936234 Reviewed-by: Tristan Honscheid <honscheid@google.com> Tested-by: Tristan Honscheid <honscheid@google.com> Reviewed-by: Keith Short <keithshort@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Tristan Honscheid <honscheid@google.com>
* markarth: Modify GPIO configLeila Lin2023-01-102-0/+5
| | | | | | | | | | | | | | | | | | Add markarth-specific GPIO_LID_SW for lid switch. LOW_COVERAGE_REASON=no unit tests for Markarth yet, b/247151116 BUG=b:264208874 BRANCH=none TEST=zmake build Markarth success Change-Id: I2559ec953a6047622b1f923ad6e1e38836709165 Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4135919 Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Reviewed-by: Chao Gui <chaogui@google.com> Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
* nissa: remove charger minimum current limitPeter Marheine2023-01-101-1/+0
| | | | | | | | | | | | | | | | | | | This will prevent standby power exceeding USB-PD limits during voltage transitions, removing the incorrect behavior inherited from most older boards. BUG=b:163093572 TEST=Verified charging continues to work on craask, and observed current limits dropping to 125 mA when VBUS changes to or from 20V (then returning to negotiated limits after the transition). BRANCH=nissa Signed-off-by: Peter Marheine <pmarheine@chromium.org> Change-Id: Ia904962c42d252697d0ea0192a214d08a8b8dd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4032447 Commit-Queue: Andrew McRae <amcrae@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr: fwid: Move RW FWID to end of the flashKeith Short2023-01-105-11/+48
| | | | | | | | | | | | | | | | | | | | | | Force the RW_FWID to always reside in the last 32 bytes of the flash. This ensures that the RW_FW and RW_FWID sections never move within the full EC binary. The FMAP is only stored in RO, so this ensures future compatibility with RW firmware image size changes. BUG=b:264229880 BRANCH=none TEST=Run "futility dump_fmap ec.bin" and verify RW_FWID is located in last 32-bytes. TEST=On Herobrine, validate EC sync and validate FMAP manifest when the RO and RW images are different versions. Change-Id: I2d96d602f37ca9fafe4d01cbf1a578e20861abaa Signed-off-by: Keith Short <keithshort@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4143799 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
* SBS: Make battery_get_params clear flags selectivelyDaisuke Nojiri2023-01-101-0/+17
| | | | | | | | | | | | | | | | | | | | | | | Currently, battery_get_params clear all flags in batt.flags. This patch makes the function clear only the flags which are explicitly set or unset by battery_get_params. With this change, the charger task can add a flag to batt.flags. There isn't yet functionality change by this patch. BUG=b:263921114 BRANCH=None TEST=run-battery_get_params_smart run-sbs_charging_v2 TEST=./twister -i --toolchain host -s \ external/platform/ec/zephyr/test/drivers/drivers.default Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Change-Id: I5708ab6de81bc0a7c28961b13960fd89460b2e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4136966 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> Commit-Queue: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-by: Bob Moragues <moragues@chromium.org>
* zephyr: Reset battfake after every testDaisuke Nojiri2023-01-091-1/+7
| | | | | | | | | | | | | | | | This patch makes smart battery tests disable battfake after each test. BUG=None BRANCH=None TEST=./twister -i --toolchain host -s \ external/platform/ec/zephyr/test/drivers/drivers.default Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Change-Id: I1869fa848fcd52d1ea8731d256fb3b72e741e51f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4143800 Commit-Queue: Tristan Honscheid <honscheid@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Tristan Honscheid <honscheid@google.com>
* zephyr: Cmake finds clang/gcov outside chrootAaron Massey2023-01-091-3/+9
| | | | | | | | | | | | | | | | | | | | CMake for clang was hardcoding the c/cpp/gcov binary paths due to the preconfigured chroot environment. Have CMake look for the aforementioned tooling when not compiling within the chroot. BRANCH=none BUG=b:259306777 TEST=fwsdk: run build herobrine prototype TEST=chroot: zmake build herobrine TEST=CQ Change-Id: I08464f40b950e450b18e1330c76d3c03a5739241 Signed-off-by: Aaron Massey <aaronmassey@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4145013 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* markarth: Remove BC1.2 functionLeila Lin2023-01-073-0/+35
| | | | | | | | | | | | | | | | | | | | | Depend on design, remove BC1.2 function. 1.keep bc12 gpio and change to GPI 2.remove pi3usb9201 config 3.disable bc12 config LOW_COVERAGE_REASON=no unit tests for Markarth yet, b/247151116 BUG=b:262409559 BRANCH=none TEST=zmake build Markarth success Change-Id: I668ee4a719c39d3b175d93369218dd27da6119b3 Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4135922 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Reviewed-by: Chao Gui <chaogui@google.com> Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com>
* geralt: fix gpio name typoTing Shen2023-01-071-1/+1
| | | | | | | | | | | | | | | | | s4 -> s5, see comments in CL:4042170. BUG=none TEST=zmake build geralt BRANCH=none Change-Id: Ia526f495d5d0eb4bc7954885dd28e7bee4f2c39a Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4141361 Reviewed-by: Eric Yilun Lin <yllin@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Auto-Submit: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org>
* zmake: Fix cmake_defs for build and compare-builds subcommandsJack Rosenthal2023-01-061-0/+4
| | | | | | | | | | | | | | | | | | This was implemented for the configure subcommand, but since the keyword arguments were missing for the build and compare_builds methods for cmake_defs, these flags were not being applied. BUG=b:259306777 BRANCH=i don't care TEST=zmake -D build minimal-posix -DSOMETHING=ANOTHER ~> the cmake command shows the variable passed Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Change-Id: I538549e01a157b8f4c9ac4e687e4eb88c2c00c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4143808 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com> Commit-Queue: Aaron Massey <aaronmassey@google.com>
* ec: Change get_keycap_label return to unsignedJeremy Bettis2023-01-061-3/+3
| | | | | | | | | | | | | | | | | | | | | | This causes compiler failures with some compiler flags. Change all references to get_keycap_label to use uint8_t instead of char. BRANCH=NONE BUG=b:264434836,b:257393779 TEST=make clobber && make V=1 TEST_ASAN=y TEST_FLAG=TEST_HOSTTEST=y \ test-list-host=kb_8042 run-kb_8042 LOW_COVERAGE_REASON=Refactor of types only. Change-Id: I95db81e8adc2bc082df8fae26d33aad78adbd1cf Signed-off-by: Jeremy Bettis <jbettis@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4136957 Tested-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com> Code-Coverage: Eric Yilun Lin <yllin@google.com>
* zephyr: Kconfig: Add CONFIG_FLASH for npcxKnox Chiou2023-01-061-0/+5
| | | | | | | | | | | | | | Add missing CONFIG_FLASH to npcx. BRANCH=none BUG=none TEST=flashread <offset> size Change-Id: Iedb23b786f674804be72f1610f515ba9f9767eec Signed-off-by: Knox Chiou <knoxchiou@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4137872 Reviewed-by: Eric Yilun Lin <yllin@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr/test/drivers: add it8xxx2_hw_sha256 testDino Li2023-01-066-0/+67
| | | | | | | | | | | | | | | | Verify that the hardware sha256 registers are configured as we want. BRANCH=none BUG=b:263259072 TEST=./twister -v -T zephyr/test/drivers/ \ --test external/platform/ec/zephyr/test/drivers/drivers.it8xxx2_hw_sha256 ./twister -v -i -T zephyr/test/drivers Signed-off-by: Dino Li <Dino.Li@ite.com.tw> Change-Id: Ie0c92f0fbdf709c1d1776a0fefe27bc6756d64d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4127644 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Jeremy Bettis <jbettis@chromium.org>
* zephyr: enable Kconfig based on the devicetree - RT9490 chargerMichał Barnaś2023-01-051-1/+0
| | | | | | | | | | | | | | | This commit adds automatic selection of required Kconfig options based on the device tree nodes for module: RT9490 charger chip BUG=b:251812799 BRANCH=main TEST=run twister and zcompare script Change-Id: I2c43ec9e67770ffc276c690aa776bdbd6bf9ffbb Signed-off-by: Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3982645 Reviewed-by: Aaron Massey <aaronmassey@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* zephyr: enable Kconfig based on the devicetree - BC12 PI3USBMichał Barnaś2023-01-052-4/+2
| | | | | | | | | | | | | | | This commit adds automatic selection of required Kconfig options based on the device tree nodes for module: BC12 PI3USB chip BUG=b:251812799 BRANCH=main TEST=run twister and zcompare script Change-Id: Ib66496c5e5d4908de73fae877b867bdc0e36a815 Signed-off-by: Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3982644 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Sam Hurst <shurst@google.com>
* zephyr: enable Kconfig based on the devicetree - batteryMichał Barnaś2023-01-0513-18/+8
| | | | | | | | | | | | | | | This commit adds automatic selection of required Kconfig options based on the device tree nodes for module: battery BUG=b:251812799 BRANCH=main TEST=run twister and zcompare script Change-Id: I99596c96e336d342b10465c79f464945f418e75b Signed-off-by: Michał Barnaś <mb@semihalf.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3982643 Reviewed-by: Tristan Honscheid <honscheid@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* voltorb: add two properties in LED policy led-colors nodeSiyu Qin2023-01-056-13/+174
| | | | | | | | | | | | | | | | | | | According to OEM requirement, the LED color depends on battery state. Add batt-state-mask and batt-state to distinguish battery charging and discharging when AC is on. BUG=b:260546013 BRANCH=corsola TEST=1. When AC on and battery is charging, then LED is amber. 2. When AC on and battery is discharging, then LED is blue. Change-Id: I685a60f43262e4e41aa4cd5879905ac3e4ddc6ee Signed-off-by: Siyu Qin <qinsiyu@huaqin.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4078724 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Mike Lee <mike5@huaqin.corp-partner.google.com>
* Markarth : Implement battery parameter.Logan_Liao2023-01-054-4/+120
| | | | | | | | | | | | | | | | | | | | | This patch accroding to battery team that enable battery for Markarth. LOW_COVERAGE_REASON=no unit tests for Markarth yet, b/247151116 BUG=b:263692236 BRANCH=none TEST=zmake build Markarth success Change-Id: Ic09af7cf5c3222b1eb3b5b7fe53cdb97d2c5938a Signed-off-by: Logan_Liao <Logan_Liao@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4135636 Tested-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Code-Coverage: Robert Zieba <robertzieba@google.com> Commit-Queue: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: Chao Gui <chaogui@google.com> Reviewed-by: Robert Zieba <robertzieba@google.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* cbi: Check CBI WP latch as well as GSC EEPROM WPAndrew McRae2023-01-041-0/+5
| | | | | | | | | | | | | | | | If CONFIG_PLATFORM_EC_EEPROM_CBI_WP is set, check whether gp_cbi_wp has been set to verify whether EEPROM is write protected or not. BUG=b:264209013 TEST=Verify that cbi write works on Nirwen for unlocked system. BRANCH=none Change-Id: I06d587675ed2b168a38533c851d9b7a650054dbd Signed-off-by: Andrew McRae <amcrae@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4134864 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* tree: Replace "unsigned" with "unsigned int"Andrea Grandi2023-01-042-3/+3
| | | | | | | | | | | | | | | | | Fix checkpatch error: > Prefer 'unsigned int' to bare use of 'unsigned' BUG=b:262047616 TEST=./util/compare_build.sh -b all -j 120 => MATCH BRANCH=none Change-Id: Ibf82332a1e1ea0a0a03d3993336e24883e495e05 Signed-off-by: Andrea Grandi <agrandi@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4126483 Reviewed-by: Tom Hughes <tomhughes@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* evoker: Update PC-VP-BP153 disconnect registerYu-An Chen2023-01-031-3/+3
| | | | | | | | | | | | | | | Update PC-VP-BP153 disconnect register BUG=b:246879091 BRANCH=none TEST=manual check battery disconnect state correct Change-Id: I8eba6450d9f87d78a6b32bd25a0158fad702b0ac Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4127976 Reviewed-by: Sam Hurst <shurst@google.com> Commit-Queue: Sam Hurst <shurst@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* markarth : Initial EC imageChao Gui2023-01-0315-0/+865
| | | | | | | | | | | | | | | | | | | | | Create the initial Zephyr EC image for the markarth variant by copying the skyrim reference board EC files. More changes will be added later. LOW_COVERAGE_REASON=New device specific configuration BUG=b:262092858, b:262409559 BRANCH=none TEST=zmake build markarth && zmake compare-builds skyrim Signed-off-by: Chao Gui <chaogui@google.com> Change-Id: I556f841abfb8605838dcbda06d1522f9186f9965 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4130359 Code-Coverage: Robert Zieba <robertzieba@google.com> Tested-by: Chao Gui <chaogui@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Robert Zieba <robertzieba@google.com> Commit-Queue: Chao Gui <chaogui@google.com>
* zephyr: named-gpios: remove DT_PATH usagesFabio Baltieri2023-01-0319-49/+60
| | | | | | | | | | | | | | | | Replace a bunch of DT_PATH usages with some common macros to access the named-gpios node based on the DT compatible. BRANCH=none BUG=none TEST=cq dry run TEST=zmake compare-builds -a Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: Ib99820051b5a55b68915e3b29071ee5f7e45ebfb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4114286 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Tristan Honscheid <honscheid@google.com>
* zephyr: tests: bump up test timeout to 360 secondsFabio Baltieri2023-01-031-6/+6
| | | | | | | | | | | | | | | | Increase the timeout of few drivers tests to 360 seconds, give those some more time to pass in CI as they occasionally timeout right now. BRANCH=none BUG=b:263748632 TEST=cq dry run Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> Change-Id: I922a89a0a0aeef0ebbe69ee823f50e901d6c172c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4126619 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Tristan Honscheid <honscheid@google.com> Commit-Queue: Tristan Honscheid <honscheid@google.com>
* corsola: power sequence teststabilize-15300.B-mainTing Shen2022-12-3010-5/+512
| | | | | | | | | | | | | | | | | | Add a test to verify mt8186 power state machine behavior. power/mt8186.c has above 90% coverage after this CL. BUG=b:256575497 TEST=./twister -v -i --coverage -p native_posix -p unit_testing BRANCH=none Change-Id: I2f274697e83dfc50f6976b8f6d137df6c69da2b9 Signed-off-by: Ting Shen <phoenixshen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4127103 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Eric Yilun Lin <yllin@google.com> Tested-by: Ting Shen <phoenixshen@chromium.org> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
* craask: support LGC batteryben chen2022-12-291-0/+3
| | | | | | | | | | | | | | add LGC battery: AP19B8M BUG=b:230445911 BRANCH=none TEST=battery cut off test, battery detection Change-Id: I842ec0cf4d2cfa38f22d1c8f7d1d521c5bdf8d09 Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4128276 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Andrew McRae <amcrae@google.com>
* zephyr: shim: shim SHA256 API to adapot HW accelerator driverJun Lin2022-12-295-0/+180
| | | | | | | | | | | | | | | | | | | | | | | | Wrap Zephyr crypto_sha* driver APIs to meet the interface of Cros-EC SHA256 APIs. This CL has dependency on PR: https://github.com/zephyrproject-rtos/zephyr/pull/53031 BRANCH=none BUG=b:155771688 TEST=keep the same RW image; flash different RO images with/without hardware accelerator; verify the RW hash value is the same in the console message. TEST=in the test CL; move test patterns in test/sha256.c to zephyr/program/npcx_evb/npcx9/src/test_sha256.c; pass all test patterns. Signed-off-by: Jun Lin <CHLin56@nuvoton.com> Change-Id: I3979c088933d2caa09576f4aacc14d2ffb6f73f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4116105 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: CH Lin <chlin56@nuvoton.com> Commit-Queue: CH Lin <chlin56@nuvoton.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
View Lorry Controller Status