From 257dab7491ba39da5316f53cd34819c8ad937e77 Mon Sep 17 00:00:00 2001 From: Shawn Nematbakhsh Date: Fri, 1 Apr 2016 12:25:52 -0700 Subject: console: Put additional console commands behind CONFIGs Allow boards to save flash space by undef'ing CONFIGs which gate 'hcdebug' and 'md' console commands. BUG=chrome-os-partner:34489 BRANCH=None TEST=`make buildall -j` Change-Id: I583b98ff1e4d9d6a26958c6895fb0c0305dddceb Signed-off-by: Shawn Nematbakhsh Reviewed-on: https://chromium-review.googlesource.com/336813 Commit-Ready: Shawn N Tested-by: Shawn N Reviewed-by: Vincent Palatin --- common/host_command.c | 2 ++ common/memory_commands.c | 3 ++- include/config.h | 2 ++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/common/host_command.c b/common/host_command.c index 97b8cc59cc..5256861ed6 100644 --- a/common/host_command.c +++ b/common/host_command.c @@ -868,6 +868,7 @@ DECLARE_CONSOLE_COMMAND(hostcmd, command_host_command, NULL); #endif /* CONFIG_CMD_HOSTCMD */ +#ifdef CONFIG_CMD_HCDEBUG static int command_hcdebug(int argc, char **argv) { if (argc > 1) { @@ -892,3 +893,4 @@ DECLARE_CONSOLE_COMMAND(hcdebug, command_hcdebug, "hcdebug [off | normal | every | params]", "Set host command debug output mode", NULL); +#endif /* CONFIG_CMD_HCDEBUG */ diff --git a/common/memory_commands.c b/common/memory_commands.c index db22f330c8..da88c71a63 100644 --- a/common/memory_commands.c +++ b/common/memory_commands.c @@ -18,6 +18,7 @@ enum format { FMT_STRING, }; +#ifdef CONFIG_CMD_MD static void show_val(uint32_t address, uint32_t index, enum format fmt) { uint32_t val; @@ -55,7 +56,6 @@ static void show_val(uint32_t address, uint32_t index, enum format fmt) cflush(); } - static int command_mem_dump(int argc, char **argv) { uint32_t address, i, num = 1; @@ -110,6 +110,7 @@ DECLARE_CONSOLE_COMMAND(md, command_mem_dump, "[.b|.h|.s] addr [count]", "dump memory values, optionally specifying the format", NULL); +#endif /* CONFIG_CMD_MD */ static int command_read_word(int argc, char **argv) { diff --git a/include/config.h b/include/config.h index 28363da4eb..df57da65b9 100644 --- a/include/config.h +++ b/include/config.h @@ -531,6 +531,7 @@ #undef CONFIG_CMD_FORCETIME #undef CONFIG_CMD_GSV #define CONFIG_CMD_HASH +#define CONFIG_CMD_HCDEBUG #undef CONFIG_CMD_HOSTCMD #define CONFIG_CMD_I2C_SCAN #define CONFIG_CMD_I2C_XFER @@ -543,6 +544,7 @@ #undef CONFIG_CMD_JUMPTAGS #undef CONFIG_CMD_LID_ANGLE #undef CONFIG_CMD_MCDP +#define CONFIG_CMD_MD #define CONFIG_CMD_PD #undef CONFIG_CMD_PD_DEV_DUMP_INFO #undef CONFIG_CMD_PD_FLASH -- cgit v1.2.1