From 39c2407f8b9af21629e33f4da8245cc63afdba9d Mon Sep 17 00:00:00 2001 From: Sue Chen Date: Thu, 18 Jul 2019 12:03:48 +0800 Subject: Nami: Clear EC_FEATURE_PWM_KEYB for the sku not supporting keyboard backlight in Bard. If sku_id is without SKU_ID_MASK_KBLIGHT, it should clear EC_FEATURE_PWM_KEYB in feature flags0 to let the OS know that the device does not support keyboard backlight. BUG=b:137097125 BRANCH=nami TEST=Make sure that keyboard backlight brightness scale won't show up when sku id is without SKU_ID_MASK_KBLIGHT. Change-Id: Ibe482a12c5113c430b585f8ad95366f222f8f939 Signed-off-by: Sue Chen Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1709043 Reviewed-by: Daisuke Nojiri Commit-Queue: Daisuke Nojiri Tested-by: Daisuke Nojiri Auto-Submit: Daisuke Nojiri --- board/nami/board.c | 13 +++++++++++++ board/nami/board.h | 1 + 2 files changed, 14 insertions(+) diff --git a/board/nami/board.c b/board/nami/board.c index e5b5e6af44..e5c0812059 100644 --- a/board/nami/board.c +++ b/board/nami/board.c @@ -1158,3 +1158,16 @@ int board_set_min_power_mw_for_power_on(void) CPRINTS("Set AP boot threshold to %d mW", power); return power; } + +uint32_t board_override_feature_flags0(uint32_t flags0) +{ + if (!(sku & SKU_ID_MASK_KBLIGHT)) + return (flags0 & ~EC_FEATURE_MASK_0(EC_FEATURE_PWM_KEYB)); + + return flags0; +} + +uint32_t board_override_feature_flags1(uint32_t flags1) +{ + return flags1; +} diff --git a/board/nami/board.h b/board/nami/board.h index d5b6534427..9f37c6f966 100644 --- a/board/nami/board.h +++ b/board/nami/board.h @@ -62,6 +62,7 @@ #define CONFIG_SUPPRESSED_HOST_COMMANDS \ EC_CMD_CONSOLE_SNAPSHOT, EC_CMD_CONSOLE_READ, EC_CMD_PD_GET_LOG_ENTRY, \ EC_CMD_MOTION_SENSE_CMD +#define CONFIG_EC_FEATURE_BOARD_OVERRIDE /* EC console commands */ #define CONFIG_CMD_ACCELS -- cgit v1.2.1