From 4864eef4d84624a6fcc7f4fe428ae5a377a506ae Mon Sep 17 00:00:00 2001 From: Scott Collyer Date: Tue, 2 Apr 2019 17:35:02 -0700 Subject: tcpm: Refactor tcpc_config to include a flags field tcpc_config contained a field for both the alert polarity and open drain/push pull configuration. There is also a possible difference in TCPC reset polarity. Instead of adding yet another field to describe this configuration, it would be better to convert alert polairty, open drain and reset polarity into a single flags field. This CL modifies the tcpc_config struct to use a single flags field and adds defines for what existing flag options can be. BUG=b:130194031 BRANCH=none TEST=make -j buildall Change-Id: Ifb7e7604edb7021fb2d36ee279049eb52fefc99e Signed-off-by: Scott Collyer Signed-off-by: Furquan Shaikh Reviewed-on: https://chromium-review.googlesource.com/1551581 Commit-Ready: Furquan Shaikh Tested-by: Furquan Shaikh Reviewed-by: Jett Rink Reviewed-by: Paul Fagerburg Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2315960 Tested-by: Devin Lu Reviewed-by: Marco Chen Commit-Queue: Marco Chen --- baseboard/dragonegg/baseboard.c | 9 ++++++--- baseboard/grunt/baseboard.c | 7 ++++--- baseboard/kalista/baseboard.c | 4 ++-- baseboard/octopus/variant_usbc_ec_tcpcs.c | 6 ++++-- baseboard/octopus/variant_usbc_standalone_tcpcs.c | 9 ++++++--- board/atlas/board.c | 6 ++++-- board/cheza/board.c | 7 ++++--- board/coral/board.c | 6 ++++-- board/eve/board.c | 6 ++++-- board/fizz/board.c | 4 ++-- board/glkrvp/chg_usb_pd.c | 6 ++++-- board/glkrvp_ite/chg_usb_pd.c | 6 ++++-- board/nami/board.c | 6 ++++-- board/nautilus/board.c | 6 ++++-- board/nocturne/board.c | 6 ++++-- board/poppy/board.c | 6 ++++-- board/rammus/board.c | 6 ++++-- board/reef/board.c | 6 ++++-- board/reef_mchp/board.c | 6 ++++-- driver/tcpm/anx74xx.c | 9 ++++----- include/usb_pd_tcpm.h | 23 ++++++++++++----------- 21 files changed, 92 insertions(+), 58 deletions(-) diff --git a/baseboard/dragonegg/baseboard.c b/baseboard/dragonegg/baseboard.c index 542e1cad2d..08c6c30927 100644 --- a/baseboard/dragonegg/baseboard.c +++ b/baseboard/dragonegg/baseboard.c @@ -166,20 +166,23 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { [USB_PD_PORT_ITE_0] = { /* TCPC is embedded within EC so no i2c config needed */ .drv = &it83xx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, [USB_PD_PORT_ITE_1] = { /* TCPC is embedded within EC so no i2c config needed */ .drv = &it83xx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, [USB_PD_PORT_TUSB422_2] = { .i2c_host_port = I2C_PORT_USBC1C2, .i2c_slave_addr = TUSB422_I2C_ADDR, .drv = &tusb422_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/baseboard/grunt/baseboard.c b/baseboard/grunt/baseboard.c index ca034c06d1..4958ad9324 100644 --- a/baseboard/grunt/baseboard.c +++ b/baseboard/grunt/baseboard.c @@ -89,14 +89,15 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { .i2c_host_port = I2C_PORT_TCPC0, .i2c_slave_addr = ANX74XX_I2C_ADDR1, .drv = &anx74xx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, - .od = TCPC_ALERT_OPEN_DRAIN, + /* Alert is active-low, open-drain */ + .flags = TCPC_FLAGS_ALERT_OD, }, [USB_PD_PORT_PS8751] = { .i2c_host_port = I2C_PORT_TCPC1, .i2c_slave_addr = PS8751_I2C_ADDR1, .drv = &ps8xxx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/baseboard/kalista/baseboard.c b/baseboard/kalista/baseboard.c index 0b3ae6953a..c6cb842277 100644 --- a/baseboard/kalista/baseboard.c +++ b/baseboard/kalista/baseboard.c @@ -158,8 +158,8 @@ const unsigned int i2c_ports_used = ARRAY_SIZE(i2c_ports); /* TCPC mux configuration */ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { - {I2C_PORT_TCPC0, I2C_ADDR_TCPC0, &ps8xxx_tcpm_drv, - TCPC_ALERT_ACTIVE_LOW}, + /* Alert is active-low, push-pull */ + {I2C_PORT_TCPC0, I2C_ADDR_TCPC0, &ps8xxx_tcpm_drv, 0}, }; static int ps8751_tune_mux(int port) diff --git a/baseboard/octopus/variant_usbc_ec_tcpcs.c b/baseboard/octopus/variant_usbc_ec_tcpcs.c index f2e915c9e4..60e4b6b5db 100644 --- a/baseboard/octopus/variant_usbc_ec_tcpcs.c +++ b/baseboard/octopus/variant_usbc_ec_tcpcs.c @@ -31,12 +31,14 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { [USB_PD_PORT_ITE_0] = { /* TCPC is embedded within EC so no i2c config needed */ .drv = &it83xx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, [USB_PD_PORT_ITE_1] = { /* TCPC is embedded within EC so no i2c config needed */ .drv = &it83xx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/baseboard/octopus/variant_usbc_standalone_tcpcs.c b/baseboard/octopus/variant_usbc_standalone_tcpcs.c index 46043b53a7..1d47c6ff9d 100644 --- a/baseboard/octopus/variant_usbc_standalone_tcpcs.c +++ b/baseboard/octopus/variant_usbc_standalone_tcpcs.c @@ -32,18 +32,21 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { #if defined(VARIANT_OCTOPUS_TCPC_0_PS8751) .i2c_slave_addr = PS8751_I2C_ADDR1, .drv = &ps8xxx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW + /* Alert is active-low, push-pull */ + .flags = 0, #else .i2c_slave_addr = AN7447_TCPC0_I2C_ADDR, .drv = &anx7447_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, #endif }, [USB_PD_PORT_TCPC_1] = { .i2c_host_port = I2C_PORT_TCPC1, .i2c_slave_addr = PS8751_I2C_ADDR1, .drv = &ps8xxx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/board/atlas/board.c b/board/atlas/board.c index 5deb1e3d64..57951e4a81 100644 --- a/board/atlas/board.c +++ b/board/atlas/board.c @@ -174,14 +174,16 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { .i2c_host_port = I2C_PORT_TCPC0, .i2c_slave_addr = I2C_ADDR_TCPC, .drv = &ps8xxx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW + /* Alert is active-low, push-pull */ + .flags = 0, }, { /* right port */ .i2c_host_port = I2C_PORT_TCPC1, .i2c_slave_addr = I2C_ADDR_TCPC, .drv = &ps8xxx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/board/cheza/board.c b/board/cheza/board.c index 118d367b01..1966465533 100644 --- a/board/cheza/board.c +++ b/board/cheza/board.c @@ -254,10 +254,11 @@ unsigned int ppc_cnt = ARRAY_SIZE(ppc_chips); /* TCPC mux configuration */ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { + /* Alert is active-low, open-drain */ [USB_PD_PORT_ANX3429] = {I2C_PORT_TCPC0, 0x50, &anx74xx_tcpm_drv, - TCPC_ALERT_ACTIVE_LOW, TCPC_ALERT_OPEN_DRAIN}, - [USB_PD_PORT_PS8751] = {I2C_PORT_TCPC1, 0x16, &ps8xxx_tcpm_drv, - TCPC_ALERT_ACTIVE_LOW}, + TCPC_FLAGS_ALERT_OD}, + /* Alert is active-low, push-pull */ + [USB_PD_PORT_PS8751] = {I2C_PORT_TCPC1, 0x16, &ps8xxx_tcpm_drv, 0}, }; /* diff --git a/board/coral/board.c b/board/coral/board.c index b8a9f40f80..94e39c9382 100644 --- a/board/coral/board.c +++ b/board/coral/board.c @@ -245,13 +245,15 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { .i2c_host_port = NPCX_I2C_PORT0_0, .i2c_slave_addr = ANX74XX_I2C_ADDR1, .drv = &anx74xx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, [USB_PD_PORT_PS8751] = { .i2c_host_port = NPCX_I2C_PORT0_1, .i2c_slave_addr = PS8751_I2C_ADDR1, .drv = &ps8xxx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/board/eve/board.c b/board/eve/board.c index 5153858b4e..45780cd8b0 100644 --- a/board/eve/board.c +++ b/board/eve/board.c @@ -218,13 +218,15 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { .i2c_host_port = I2C_PORT_TCPC0, .i2c_slave_addr = ANX74XX_I2C_ADDR1, .drv = &anx74xx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, { .i2c_host_port = I2C_PORT_TCPC1, .i2c_slave_addr = ANX74XX_I2C_ADDR1, .drv = &anx74xx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/board/fizz/board.c b/board/fizz/board.c index 7321234fe4..8beb89fce8 100644 --- a/board/fizz/board.c +++ b/board/fizz/board.c @@ -191,8 +191,8 @@ const unsigned int i2c_ports_used = ARRAY_SIZE(i2c_ports); /* TCPC mux configuration */ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { - {NPCX_I2C_PORT0_0, I2C_ADDR_TCPC0, &ps8xxx_tcpm_drv, - TCPC_ALERT_ACTIVE_LOW}, + /* Alert is active-low, push-pull */ + {NPCX_I2C_PORT0_0, I2C_ADDR_TCPC0, &ps8xxx_tcpm_drv, 0}, }; static int ps8751_tune_mux(int port) diff --git a/board/glkrvp/chg_usb_pd.c b/board/glkrvp/chg_usb_pd.c index 6ca5006860..3e4d739d56 100644 --- a/board/glkrvp/chg_usb_pd.c +++ b/board/glkrvp/chg_usb_pd.c @@ -31,8 +31,10 @@ enum glkrvp_charge_ports { }; const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { - {NPCX_I2C_PORT7_0, 0xA0, &tcpci_tcpm_drv, TCPC_ALERT_ACTIVE_LOW}, - {NPCX_I2C_PORT7_0, 0xA4, &tcpci_tcpm_drv, TCPC_ALERT_ACTIVE_LOW}, + /* Alert is active-low, push-pull */ + {NPCX_I2C_PORT7_0, 0xA0, &tcpci_tcpm_drv, 0}, + /* Alert is active-low, push-pull */ + {NPCX_I2C_PORT7_0, 0xA4, &tcpci_tcpm_drv, 0}, }; BUILD_ASSERT(ARRAY_SIZE(tcpc_config) == CONFIG_USB_PD_PORT_MAX_COUNT); diff --git a/board/glkrvp_ite/chg_usb_pd.c b/board/glkrvp_ite/chg_usb_pd.c index 6d6111d19a..36d3acfa85 100644 --- a/board/glkrvp_ite/chg_usb_pd.c +++ b/board/glkrvp_ite/chg_usb_pd.c @@ -31,8 +31,10 @@ enum glkrvp_charge_ports { }; const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { - {IT83XX_I2C_CH_B, 0xA0, &tcpci_tcpm_drv, TCPC_ALERT_ACTIVE_LOW}, - {IT83XX_I2C_CH_B, 0xA4, &tcpci_tcpm_drv, TCPC_ALERT_ACTIVE_LOW}, + /* Alert is active-low, push-pull */ + {IT83XX_I2C_CH_B, 0xA0, &tcpci_tcpm_drv, 0}, + /* Alert is active-low, push-pull */ + {IT83XX_I2C_CH_B, 0xA4, &tcpci_tcpm_drv, 0}, }; BUILD_ASSERT(ARRAY_SIZE(tcpc_config) == CONFIG_USB_PD_PORT_MAX_COUNT); diff --git a/board/nami/board.c b/board/nami/board.c index ac413125a3..a0fdc9152d 100644 --- a/board/nami/board.c +++ b/board/nami/board.c @@ -221,13 +221,15 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { .i2c_host_port = NPCX_I2C_PORT0_0, .i2c_slave_addr = PS8751_I2C_ADDR1, .drv = &ps8xxx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, [USB_PD_PORT_ANX7447] = { .i2c_host_port = NPCX_I2C_PORT0_1, .i2c_slave_addr = AN7447_TCPC3_I2C_ADDR, /* Verified on v1.1 */ .drv = &anx7447_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/board/nautilus/board.c b/board/nautilus/board.c index d95e4171ff..ca83ec2ea0 100644 --- a/board/nautilus/board.c +++ b/board/nautilus/board.c @@ -171,13 +171,15 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { .i2c_host_port = NPCX_I2C_PORT0_0, .i2c_slave_addr = PS8751_I2C_ADDR1, .drv = &ps8xxx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, { .i2c_host_port = NPCX_I2C_PORT0_1, .i2c_slave_addr = PS8751_I2C_ADDR1, .drv = &ps8xxx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/board/nocturne/board.c b/board/nocturne/board.c index 883c1c87c2..1eac2e7c57 100644 --- a/board/nocturne/board.c +++ b/board/nocturne/board.c @@ -301,14 +301,16 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { .i2c_host_port = I2C_PORT_USB_C0, .i2c_slave_addr = PS8751_I2C_ADDR1, .drv = &tcpci_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, { .i2c_host_port = I2C_PORT_USB_C1, .i2c_slave_addr = PS8751_I2C_ADDR1, .drv = &tcpci_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/board/poppy/board.c b/board/poppy/board.c index 08870c0efa..f49a2f0823 100644 --- a/board/poppy/board.c +++ b/board/poppy/board.c @@ -213,13 +213,15 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { .i2c_host_port = NPCX_I2C_PORT0_0, .i2c_slave_addr = ANX74XX_I2C_ADDR1, .drv = &anx74xx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, { .i2c_host_port = NPCX_I2C_PORT0_0, .i2c_slave_addr = PS8751_I2C_ADDR1, .drv = &ps8xxx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/board/rammus/board.c b/board/rammus/board.c index e5b8f7ef38..d1219e4124 100644 --- a/board/rammus/board.c +++ b/board/rammus/board.c @@ -165,13 +165,15 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { .i2c_host_port = I2C_PORT_TCPC1, .i2c_slave_addr = PS8751_I2C_ADDR1, .drv = &ps8xxx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, [USB_PD_PORT_ANX7447] = { .i2c_host_port = I2C_PORT_TCPC0, .i2c_slave_addr = AN7447_TCPC3_I2C_ADDR, /* Verified on v1.1 */ .drv = &anx7447_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/board/reef/board.c b/board/reef/board.c index ba1621c430..4bfdb4c2a2 100644 --- a/board/reef/board.c +++ b/board/reef/board.c @@ -250,13 +250,15 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { .i2c_host_port = NPCX_I2C_PORT0_0, .i2c_slave_addr = ANX74XX_I2C_ADDR1, .drv = &anx74xx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, [USB_PD_PORT_PS8751] = { .i2c_host_port = NPCX_I2C_PORT0_1, .i2c_slave_addr = PS8751_I2C_ADDR1, .drv = &ps8xxx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/board/reef_mchp/board.c b/board/reef_mchp/board.c index 99b5207461..eb1db092ce 100644 --- a/board/reef_mchp/board.c +++ b/board/reef_mchp/board.c @@ -364,13 +364,15 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_MAX_COUNT] = { .i2c_host_port = MCHP_I2C_PORT0, .i2c_slave_addr = 0x50, .drv = &anx74xx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, [USB_PD_PORT_PS8751] = { .i2c_host_port = MCHP_I2C_PORT2, .i2c_slave_addr = 0x16, .drv = &ps8xxx_tcpm_drv, - .pol = TCPC_ALERT_ACTIVE_LOW, + /* Alert is active-low, push-pull */ + .flags = 0, }, }; diff --git a/driver/tcpm/anx74xx.c b/driver/tcpm/anx74xx.c index c23174206a..532a2d72f8 100644 --- a/driver/tcpm/anx74xx.c +++ b/driver/tcpm/anx74xx.c @@ -984,17 +984,16 @@ static int anx74xx_tcpm_init(int port) /* Initialize interrupt open-drain */ rv |= tcpc_read(port, ANX74XX_REG_INTP_VCONN_CTRL, ®); - if (tcpc_config[port].od == TCPC_ALERT_OPEN_DRAIN) + if (tcpc_config[port].flags & TCPC_FLAGS_ALERT_OD) reg |= ANX74XX_REG_R_INTERRUPT_OPEN_DRAIN; else reg &= ~ANX74XX_REG_R_INTERRUPT_OPEN_DRAIN; rv |= tcpc_write(port, ANX74XX_REG_INTP_VCONN_CTRL, reg); /* Initialize interrupt polarity */ - rv |= tcpc_write(port, ANX74XX_REG_IRQ_STATUS, - tcpc_config[port].pol == TCPC_ALERT_ACTIVE_LOW ? - ANX74XX_REG_IRQ_POL_LOW : - ANX74XX_REG_IRQ_POL_HIGH); + reg = tcpc_config[port].flags & TCPC_FLAGS_ALERT_ACTIVE_HIGH ? + ANX74XX_REG_IRQ_POL_HIGH : ANX74XX_REG_IRQ_POL_LOW; + rv |= tcpc_write(port, ANX74XX_REG_IRQ_STATUS, reg); /* unmask interrupts */ rv |= tcpc_read(port, ANX74XX_REG_IRQ_EXT_MASK_1, ®); diff --git a/include/usb_pd_tcpm.h b/include/usb_pd_tcpm.h index 959ea36c4e..40b16dbb43 100644 --- a/include/usb_pd_tcpm.h +++ b/include/usb_pd_tcpm.h @@ -309,22 +309,23 @@ struct tcpm_drv { #endif }; -enum tcpc_alert_polarity { - TCPC_ALERT_ACTIVE_LOW, - TCPC_ALERT_ACTIVE_HIGH, -}; - -enum tcpc_alert_open_drain { - TCPC_ALERT_PUSH_PULL = 0, - TCPC_ALERT_OPEN_DRAIN, -}; +/* + * Macros for tcpc_config_t flags field. + * + * Bit 0 --> Polarity for TCPC alert. Set to 1 if alert is active high. + * Bit 1 --> Set to 1 if TCPC alert line is open-drain instead of push-pull. + * Bit 2 --> Polarity for TCPC reset. Set to 1 if reset line is active high. + */ +#define TCPC_FLAGS_ALERT_ACTIVE_HIGH BIT(0) +#define TCPC_FLAGS_ALERT_OD BIT(1) +#define TCPC_FLAGS_RESET_ACTIVE_HIGH BIT(2) struct tcpc_config_t { int i2c_host_port; int i2c_slave_addr; const struct tcpm_drv *drv; - enum tcpc_alert_polarity pol; - enum tcpc_alert_open_drain od; + /* See TCPC_FLAGS_* above */ + uint32_t flags; }; #ifndef CONFIG_USB_PD_TCPC_RUNTIME_CONFIG -- cgit v1.2.1