From 4c3621ace087613604f6d5fb094da62434333893 Mon Sep 17 00:00:00 2001 From: Enrico Granata Date: Wed, 28 Nov 2018 14:58:14 -0800 Subject: nocturne: Change FIFO settings Overly large sensor batches lead to timestamp synchronization issues on Nocturne, causing - among others - CTS to sometimes fail the sensor batching tests. Reduce the size of the FIFO and restore the threshold to being a third of the size. This value was changed in CL:1134494 in an attempt to solve a problem which turned out to be unrelated. BUG=b:117169255, b:73551961, b:120100420, b:120098451 BRANCH=nocturne TEST=run CTS sensor test cases, observe them pass Change-Id: Ia27bfe0a4756c22d4e48ba525d585ff11ab1cb63 Signed-off-by: Enrico Granata Reviewed-on: https://chromium-review.googlesource.com/1354484 Commit-Ready: ChromeOS CL Exonerator Bot Tested-by: Gwendal Grignou Reviewed-by: Gwendal Grignou --- board/nocturne/board.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/nocturne/board.h b/board/nocturne/board.h index 63c409678b..fcd9adb5fd 100644 --- a/board/nocturne/board.h +++ b/board/nocturne/board.h @@ -92,9 +92,9 @@ #define ALS_COUNT 1 #define CONFIG_ALS_OPT3001 #define OPT3001_I2C_ADDR OPT3001_I2C_ADDR1 -#define CONFIG_ACCEL_FIFO 1024 /* Must be a power of 2 */ +#define CONFIG_ACCEL_FIFO 512 /* Must be a power of 2 */ /* Depends on how fast the AP boots and typical ODRs */ -#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 100) +#define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3) #define CONFIG_ACCEL_INTERRUPTS #define CONFIG_ACCELGYRO_BMI160 #define CONFIG_ACCELGYRO_BMI160_INT_EVENT TASK_EVENT_CUSTOM(4) -- cgit v1.2.1