From 5908f8785d80e858c4fa95bb8c660bf7254982d5 Mon Sep 17 00:00:00 2001 From: Andrew McRae Date: Wed, 16 Mar 2022 20:35:02 +1100 Subject: ap_pwrseq: Clear default debug flags. Reduce the noise by not enabling all the debug mask bits. powerindebug can be used to set the mask as desired. BUG=b:201000950 TEST=xmake build nivviks BRANCH=none Signed-off-by: Andrew McRae Change-Id: Iae56960ecbf0bbd653df9242999aa6ed2e2cc253 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3528454 Reviewed-by: Divya S Sasidharan Reviewed-by: Peter Marheine --- zephyr/subsys/ap_pwrseq/x86_non_dsx_common_pwrseq_sm_handler.c | 1 - zephyr/test/ap_power/src/signals.c | 6 ++++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/zephyr/subsys/ap_pwrseq/x86_non_dsx_common_pwrseq_sm_handler.c b/zephyr/subsys/ap_pwrseq/x86_non_dsx_common_pwrseq_sm_handler.c index d712bb008a..f980f91d52 100644 --- a/zephyr/subsys/ap_pwrseq/x86_non_dsx_common_pwrseq_sm_handler.c +++ b/zephyr/subsys/ap_pwrseq/x86_non_dsx_common_pwrseq_sm_handler.c @@ -408,7 +408,6 @@ static int pwrseq_init(const struct device *dev) power_signal_init(); /* TODO: Define initial state of power sequence */ LOG_DBG("Init pwr seq state"); - power_set_debug(0xFFFFFF); init_pwr_seq_state(); /* Create power sequence state handler core function thread */ create_pwrseq_thread(); diff --git a/zephyr/test/ap_power/src/signals.c b/zephyr/test/ap_power/src/signals.c index 8bbf88c2a9..432b28042b 100644 --- a/zephyr/test/ap_power/src/signals.c +++ b/zephyr/test/ap_power/src/signals.c @@ -299,11 +299,17 @@ ZTEST(signals, test_signal_mask) */ ZTEST(signals, test_debug_mask) { + power_signal_mask_t old; power_signal_mask_t dm = 0xDEADBEEF; + old = power_get_debug(); power_set_debug(dm); zassert_equal(dm, power_get_debug(), "Debug mask does not match set value"); + /* + * Reset back to default. + */ + power_set_debug(old); } /** -- cgit v1.2.1