From 5faf6d7c15c96f6ea0e96e60ed100e07ca38625e Mon Sep 17 00:00:00 2001 From: Vadim Bendebury Date: Wed, 19 Jun 2013 16:48:32 -0700 Subject: drop: Ignore command version for VBNV CONTEXT command The ec driver does not yet pass the command version properly from app to the EC. This causes a failure when trying to use the vbnvram context command (23). The thing is that the command version is not even important for this command, as it was never implemented differently. As a quick fix - mark the command descriptor as supporting both versions. I wonder if we should implement a "don't care" option for situations like this. BRANCH=none BUG=chromium:239197 TEST=manual . on peach_pit: localhost ~ # mosys nvram vboot read 70000000000000000000000000000020 localhost ~ # Change-Id: I16fcc0d6752d9e778a026717208d8d6487d5dc77 Signed-off-by: Vadim Bendebury Reviewed-on: https://gerrit.chromium.org/gerrit/59391 Commit-Queue: Heng-ruey Hsu Reviewed-by: Heng-ruey Hsu Tested-by: Heng-ruey Hsu --- common/system_common.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/common/system_common.c b/common/system_common.c index 03febba603..176977930e 100644 --- a/common/system_common.c +++ b/common/system_common.c @@ -840,9 +840,15 @@ int host_command_vbnvcontext(struct host_cmd_handler_args *args) return EC_RES_SUCCESS; } + +/* + * TODO(crbug.com/239197) : Adding both versions to the version mask is a + * temporary workaround for a problem in the cros_ec driver. Drop + * EC_VER_MASK(0) once cros_ec driver can send the correct version. + */ DECLARE_HOST_COMMAND(EC_CMD_VBNV_CONTEXT, host_command_vbnvcontext, - EC_VER_MASK(EC_VER_VBNV_CONTEXT)); + EC_VER_MASK(EC_VER_VBNV_CONTEXT) | EC_VER_MASK(0)); int host_command_reboot(struct host_cmd_handler_args *args) { -- cgit v1.2.1