From 619f42fb08f599f9273e396620d58fa9f1cc6525 Mon Sep 17 00:00:00 2001 From: Diana Z Date: Thu, 10 Feb 2022 10:21:10 -0700 Subject: Skyrim: Remove pull-up on 6 axis interrupt Remove this pull-up as it's causing leakage. Boards should be reworked with an external pull-up for this interrupt line to work. BRANCH=None BUG=b:218536811 TEST=verify no leakage is seen on skyrim Signed-off-by: Diana Z Change-Id: I959d0aee627d5dbef6c0283376955192734aeb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3453165 Tested-by: Charlie Costakis Reviewed-by: Rob Barnes --- zephyr/projects/skyrim/gpio.dts | 3 --- zephyr/projects/skyrim/guybrush.dts | 3 +++ zephyr/projects/skyrim/skyrim.dts | 3 +++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/zephyr/projects/skyrim/gpio.dts b/zephyr/projects/skyrim/gpio.dts index 8809a1233e..82f7665291 100644 --- a/zephyr/projects/skyrim/gpio.dts +++ b/zephyr/projects/skyrim/gpio.dts @@ -175,9 +175,6 @@ gpios = <&gpio1 7 GPIO_OUT_LOW>; enum-name = "GPIO_KBD_KSO2"; }; - 6axis_int_l { - gpios = <&gpioa 0 GPIO_INPUT_PULL_UP>; - }; tablet_mode { gpios = <&gpioc 1 GPIO_INPUT>; }; diff --git a/zephyr/projects/skyrim/guybrush.dts b/zephyr/projects/skyrim/guybrush.dts index 2ee04a09e1..9473106b4b 100644 --- a/zephyr/projects/skyrim/guybrush.dts +++ b/zephyr/projects/skyrim/guybrush.dts @@ -88,6 +88,9 @@ ec_pwm7 { gpios = <&gpio6 0 GPIO_INPUT_PULL_UP>; }; + 6axis_int_l { + gpios = <&gpioa 0 GPIO_INPUT_PULL_UP>; + }; }; def-lvol-io-list { diff --git a/zephyr/projects/skyrim/skyrim.dts b/zephyr/projects/skyrim/skyrim.dts index ca8acc7e24..b747aed6a0 100644 --- a/zephyr/projects/skyrim/skyrim.dts +++ b/zephyr/projects/skyrim/skyrim.dts @@ -82,6 +82,9 @@ ec_espi_rst_l { gpios = <&gpio5 4 GPIO_PULL_DOWN>; }; + 6axis_int_l { + gpios = <&gpioa 0 GPIO_INPUT>; + }; }; def-lvol-io-list { -- cgit v1.2.1