From 748b5bad9fb17d13c89d3e446bd6ef3a4ec55e59 Mon Sep 17 00:00:00 2001 From: Shawn Nematbakhsh Date: Sat, 20 Aug 2016 17:51:34 -0700 Subject: rk3399: Remove useless calls to wireless_set_state() rk3399 doesn't use AP-controlled wireless power state and CONFIG_WIRELESS isn't defined, so wireless_set_set() is in fact an empty useless function. BUG=None BRANCH=None TEST=Verify basic EC functionality on Kevin. Signed-off-by: Shawn Nematbakhsh Change-Id: I6e3631012ca1f356555a847793050ebdef8eee52 Reviewed-on: https://chromium-review.googlesource.com/373643 Commit-Ready: Shawn N Tested-by: Shawn N Reviewed-by: Aseda Aboagye --- power/rk3399.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/power/rk3399.c b/power/rk3399.c index 895694db7c..76b012c548 100644 --- a/power/rk3399.c +++ b/power/rk3399.c @@ -20,7 +20,6 @@ #include "timer.h" #include "usb_charge.h" #include "util.h" -#include "wireless.h" /* Console output macros */ #define CPUTS(outstr) cputs(CC_CHIPSET, outstr) @@ -78,13 +77,6 @@ enum power_state power_chipset_init(void) CPRINTS("already in S0"); return POWER_S0; } - - /* - * TODO: Remove wireless_* control, boards have no - * EC-controlled enable other than VR enable which uses - * power state-based control. - */ - wireless_set_state(WIRELESS_OFF); } else if (!(system_get_reset_flags() & RESET_FLAG_AP_OFF)) /* Auto-power on */ chipset_exit_hard_off(); @@ -223,9 +215,6 @@ enum power_state power_handle_state(enum power_state state) return POWER_S3S0; } - /* Enable wireless */ - wireless_set_state(WIRELESS_ON); - /* Call hooks now that rails are up */ hook_notify(HOOK_CHIPSET_RESUME); @@ -242,9 +231,6 @@ enum power_state power_handle_state(enum power_state state) /* Call hooks before we remove power rails */ hook_notify(HOOK_CHIPSET_SUSPEND); - /* Suspend wireless */ - wireless_set_state(WIRELESS_SUSPEND); - msleep(10); gpio_set_level(GPIO_PP1800_SENSOR_EN_L, 1); gpio_set_level(GPIO_PP1800_SIXAXIS_EN_L, 1); @@ -280,9 +266,6 @@ enum power_state power_handle_state(enum power_state state) /* Call hooks before we remove power rails */ hook_notify(HOOK_CHIPSET_SHUTDOWN); - /* Disable wireless */ - wireless_set_state(WIRELESS_OFF); - gpio_set_level(GPIO_PP1800_LID_EN_L, 1); gpio_set_level(GPIO_PP3300_TRACKPAD_EN_L, 1); gpio_set_level(GPIO_PP5000_EN, 0); -- cgit v1.2.1