From a1dbdc91ae1b3d60d307e5bad9514f5ed2d6b65f Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Tue, 11 Oct 2022 16:30:19 -0700 Subject: chip/stm32: Remove self-assignment When building with clang it warns: chip/stm32/clock-stm32l4.c:400:9: error: explicitly assigning value of variable of type 'uint32_t' (aka 'unsigned int') to itself [-Werror,-Wself-assign] val = val; ~~~ ^ ~~~ BRANCH=none BUG=b:172020503 TEST=CC=clang make BOARD=hyperdebug Signed-off-by: Tom Hughes Change-Id: Ie4fae7251747d27b96ed08c3ef166fddd5411b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3947822 Reviewed-by: Paul Fagerburg --- chip/stm32/clock-stm32l4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chip/stm32/clock-stm32l4.c b/chip/stm32/clock-stm32l4.c index 1c460c10fc..77e807c1ad 100644 --- a/chip/stm32/clock-stm32l4.c +++ b/chip/stm32/clock-stm32l4.c @@ -397,7 +397,7 @@ static void clock_set_osc(enum clock_osc osc, enum clock_osc pll_osc) val = STM32_FLASH_ACR; val &= ~STM32_FLASH_ACR_LATENCY_MASK; if (freq <= 16000000U) { - val = val; + /* nothing */ } else if (freq <= 32000000U) { val |= 1; } else if (freq <= 48000000U) { @@ -416,7 +416,7 @@ static void clock_set_osc(enum clock_osc osc, enum clock_osc pll_osc) val &= ~STM32_FLASH_ACR_LATENCY_MASK; if (freq <= 6000000U) { - val = val; + /* nothing */ } else if (freq <= 12000000U) { val |= 1; } else if (freq <= 18000000U) { -- cgit v1.2.1