From a4cbba34efffa8a97b0b67f2d2d8437457e4a21b Mon Sep 17 00:00:00 2001 From: Nicolas Boichat Date: Wed, 19 Sep 2018 18:11:01 -0700 Subject: Revert "driver/led/lm3630a: Configure 261ms startup ramp time" This reverts commit 5a09049c5cc9a30ddfbe69e11b833146d8f5f04f, which does not appear to fully work... BRANCH=nocturne BUG=b:111010124 TEST=N/A Change-Id: Ibf27ff27d8da685009377ef7a6c66ed86f279229 Signed-off-by: Nicolas Boichat Reviewed-on: https://chromium-review.googlesource.com/1234749 Reviewed-by: Aseda Aboagye --- driver/led/lm3630a.c | 4 ---- driver/led/lm3630a.h | 13 ------------- 2 files changed, 17 deletions(-) diff --git a/driver/led/lm3630a.c b/driver/led/lm3630a.c index d7e4718507..b65294c543 100644 --- a/driver/led/lm3630a.c +++ b/driver/led/lm3630a.c @@ -44,10 +44,6 @@ int lm3630a_poweron(void) /* Limit current to 24.5mA */ ret |= lm3630a_write(LM3630A_REG_A_CURRENT, 0x1a); - /* Set start-up ramp to 261ms, to prevent blip after initialization. */ - ret |= lm3630a_write(LM3630A_REG_ONOFF_RAMP, - LM3630A_RAMP_261_MS << LM3630A_RAMP_START_SHIFT); - /* Enable bank A, put in linear mode, and connect LED2 to bank A. */ ret |= lm3630a_write(LM3630A_REG_CONTROL, LM3630A_CTRL_BIT_LINEAR_A | diff --git a/driver/led/lm3630a.h b/driver/led/lm3630a.h index f01f682aab..38fc52e111 100644 --- a/driver/led/lm3630a.h +++ b/driver/led/lm3630a.h @@ -59,19 +59,6 @@ #define LM3630A_FMODE_500KHZ (0 << 0) #define LM3630A_FMODE_1000KHZ (1 << 0) -/* Ramp register settings */ -#define LM3630A_RAMP_START_SHIFT 3 -#define LM3630A_RAMP_STOP_SHIFT 3 - -#define LM3630A_RAMP_MINIMUM 0x0 -#define LM3630A_RAMP_261_MS 0x1 -#define LM3630A_RAMP_522_MS 0x2 -#define LM3630A_RAMP_1045_MS 0x3 -#define LM3630A_RAMP_2091_MS 0x4 -#define LM3630A_RAMP_4182_MS 0x5 -#define LM3630A_RAMP_8364_MS 0x6 -#define LM3630A_RAMP_16730_MS 0x7 - /* Power on and initialize LM3630A. */ int lm3630a_poweron(void); -- cgit v1.2.1