From b41d5a853cb0fd56e5fb9528d79577e21cfe49a1 Mon Sep 17 00:00:00 2001 From: Ting Shen Date: Thu, 20 Jan 2022 23:28:05 +0800 Subject: flash_ec: add error message for missing i2c-pseudo module Missing i2c-pseudo is a FAQ for people not familiar with ite devices. Add this to the error message to unblock their work. BUG=none TEST=1) Unload module, remove /lib/modules/*/extra/i2c-pseudo.ko. run flash_ec. Verify that error message is displayed. 2) Install i2c-pseudo, verify that flash_ec still works. BRANCH=asurada,cherry Signed-off-by: Ting Shen Change-Id: I936b06b1c69c7448c39b92ed40e320609589292b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3404352 Tested-by: Ting Shen Auto-Submit: Ting Shen Reviewed-by: Eric Yilun Lin Commit-Queue: Eric Yilun Lin (cherry picked from commit 5b65df181b1016bd16059c5dfa4f984f450ced75) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3405647 --- util/flash_ec | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/util/flash_ec b/util/flash_ec index a2c2a7feaf..612a389ef5 100755 --- a/util/flash_ec +++ b/util/flash_ec @@ -1243,6 +1243,14 @@ function dut_i2c_dev() { return fi + local has_i2c_pseudo="$(dut_control_get_or_die \ + "${ACTIVE_DEVICE}_i2c_pseudo_is_running")" + if [[ "${has_i2c_pseudo}" == False ]]; then + error "i2c-pseudo module is not running." + error "Please follow https://chromium.googlesource.com/chromiumos/platform/ec/+/HEAD/util/iteflash.md#i2c-pseudo" + die "to install i2c-pseudo module." + fi + local adap_num= adap_num="$(dut_control_get_or_die \ "${ACTIVE_DEVICE}_i2c_pseudo_adapter_num")" -- cgit v1.2.1