From bec640fad5741f5194a1920486a0f92aaf60b184 Mon Sep 17 00:00:00 2001 From: Todd Broch Date: Thu, 30 Apr 2015 15:40:17 -0700 Subject: samus_pd: Increase HPD IRQ pulse to 2msec. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Intel DP sees HPD pulse as 2msec < x < 100msec. While DP spec mentions pulse widths >250usec as acceptable they aren't recognized by i915 driver. CL increases the HPD_IRQ pulse width to 2msec minimum. BRANCH=samus BUG=chrome-os-partner:39717 TEST=manual samus + apple hdmi multiport dongle drivers external screen. Change-Id: I32c33f938ba1aa7a3927a0f75a1269b1278e82de Signed-off-by: Todd Broch Reviewed-on: https://chromium-review.googlesource.com/268653 Reviewed-by: Alec Berg Reviewed-by: Stéphane Marchesin --- board/samus_pd/usb_pd_policy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/samus_pd/usb_pd_policy.c b/board/samus_pd/usb_pd_policy.c index a8b1f1a4b5..3db584fbe5 100644 --- a/board/samus_pd/usb_pd_policy.c +++ b/board/samus_pd/usb_pd_policy.c @@ -362,8 +362,8 @@ static int svdm_dp_attention(int port, uint32_t *payload) if (irq & cur_lvl) { gpio_set_level(hpd, 0); - /* 250 usecs is minimum, 2msec is max */ - hook_call_deferred(PORT_TO_HPD_IRQ_DEFERRED(port), 300); + hook_call_deferred(PORT_TO_HPD_IRQ_DEFERRED(port), + HPD_DEBOUNCE_IRQ); } else if (irq & !cur_lvl) { CPRINTF("ERR:HPD:IRQ&LOW\n"); return 0; /* nak */ -- cgit v1.2.1