From c3126e7f49743606d1686163b446af3a4db15965 Mon Sep 17 00:00:00 2001 From: Mary Ruthven Date: Wed, 30 Oct 2019 18:22:37 -0700 Subject: g: bid: show type is empty instead of an error It's ok if type and type_inv are both empty. Only show an error if the board ID type isn't empty and the inversion is incorrect. BUG=none BRANCH=cr50 TEST=set whitelabel rlz and run 'bid' command. Make sure the warning isn't shown. Change-Id: I12b1e4b34559bc8b6ad482d9694c9dd143bfcd1c Signed-off-by: Mary Ruthven Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1892121 Reviewed-by: Namyoon Woo --- chip/g/board_id.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chip/g/board_id.c b/chip/g/board_id.c index d97ba31870..1c9fe81afb 100644 --- a/chip/g/board_id.c +++ b/chip/g/board_id.c @@ -225,7 +225,7 @@ static int command_board_id(int argc, char **argv) if (board_id_is_blank(&id)) return rv; /* The space is not initialized. */ - if (id.type != ~id.type_inv) + if (!board_id_type_is_blank(&id) && id.type != ~id.type_inv) ccprintf("Inv Type Mismatch (%08x instead of %08x)!\n", id.type_inv, ~id.type); } -- cgit v1.2.1