From ce704b40005c1acdffabe58f47df42c1d7da33c2 Mon Sep 17 00:00:00 2001 From: Randall Spangler Date: Mon, 5 Aug 2013 17:01:03 -0700 Subject: stm32f: Don't glitch signal when setting GPIO_PULL_UP It looks like a line of code was accidentally left in during refactoring gpio_set_flags(). That line is equivalent to gpio_set_level(signal, 0). It's so far been harmless, because it's immediately followed by gpio_set_level(signal, 1) - but it does mean the signal may glitch for a few clocks at this point. BUG=chrome-os-partner:21678 BRANCH=none (or Spring, but it seems to work fine even with this line) TEST=boot Spring Change-Id: Id7a48e2c9bd543f2aa6a0b710faa5dd2b482fd84 Signed-off-by: Randall Spangler Reviewed-on: https://gerrit.chromium.org/gerrit/64719 --- chip/stm32/gpio-stm32f.c | 1 - 1 file changed, 1 deletion(-) diff --git a/chip/stm32/gpio-stm32f.c b/chip/stm32/gpio-stm32f.c index df892705d0..5bf3e15ada 100644 --- a/chip/stm32/gpio-stm32f.c +++ b/chip/stm32/gpio-stm32f.c @@ -80,7 +80,6 @@ void gpio_set_flags(enum gpio_signal signal, int flags) */ if (flags & GPIO_PULL_UP) { mask |= 0x88888888 & cnf; - STM32_GPIO_BSRR(g->port) |= g->mask; gpio_set_level(signal, 1); } else if (flags & GPIO_PULL_DOWN) { mask |= 0x88888888 & cnf; -- cgit v1.2.1