From d9a869beb6e1778cec38dcce64f289aba353a8d5 Mon Sep 17 00:00:00 2001 From: Diana Z Date: Mon, 27 Jan 2020 15:41:19 -0700 Subject: TCPMv2: Ensure Rd is set in Debug Accessory.SNK When tcpm_init() runs (ex. during a phy layer reset), it will cache an Open state for the CC pull. This can cause Open to be presented on the CC lines during the next call to set polarity. The Attached.SNK state already ensures Rd is set by calling set_cc explicitly, and this change adds an explicit set to Rd for Debug Accessory.SNK as well. BRANCH=None BUG=b:147316570 TEST=loaded on waddledoo, ensured CC lines weren't set to Open when suzy-q was plugged in Change-Id: I17ea735632e10c666691c04d56057c57688dcbd6 Signed-off-by: Diana Z Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2023240 Reviewed-by: Aseda Aboagye Reviewed-by: Denis Brockus --- common/usbc/usb_tc_drp_acc_trysrc_sm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/usbc/usb_tc_drp_acc_trysrc_sm.c b/common/usbc/usb_tc_drp_acc_trysrc_sm.c index 5e7fd25319..25d0096dc7 100644 --- a/common/usbc/usb_tc_drp_acc_trysrc_sm.c +++ b/common/usbc/usb_tc_drp_acc_trysrc_sm.c @@ -2245,6 +2245,8 @@ static void tc_dbg_acc_snk_entry(const int port) CAP_DUALROLE : CAP_DEDICATED); } } + /* Apply Rd */ + tcpm_set_cc(port, TYPEC_CC_RD); /* Enable PD */ tc[port].pd_enable = 1; -- cgit v1.2.1