From e32de8826abf0ee3c123962df683a7a7b20cf158 Mon Sep 17 00:00:00 2001 From: "jerry2.huang" Date: Fri, 19 Mar 2021 14:46:45 +0800 Subject: lindar: modify gpio M2_SSD_PLN setting to GPIO_ODR_HIGH modify M2_SSD_PLN gpio setting from GPIO_OUT_HIGH to GPIO_ODR_HIGH BRANCH=firmware-volteer-13672.B BUG=b:183169516 TEST=make buildall -j verify DUT enter s5,M2_SSD_PLN will be low. Signed-off-by: jerry2.huang Change-Id: I63e99f91513c799b28f95049170d25adc203c5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2772412 Reviewed-by: Keith Short Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2781098 Reviewed-by: Abe Levkoy Commit-Queue: Abe Levkoy Tested-by: Abe Levkoy --- board/lindar/gpio.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/board/lindar/gpio.inc b/board/lindar/gpio.inc index c4f3123ebb..246b83cd3f 100644 --- a/board/lindar/gpio.inc +++ b/board/lindar/gpio.inc @@ -98,10 +98,10 @@ GPIO(EC_H1_PACKET_MODE, PIN(7, 5), GPIO_OUT_LOW) /* H1 Packet Mode */ GPIO(CCD_MODE_ODL, PIN(E, 5), GPIO_INPUT) /* Case Closed Debug Mode */ /* - * Determine the polarity of these SSD signals and whether - * they are open-drain. + * Despite their names, M2_SSD_PLN and M2_SSD_PLA are active-low, and M2_SSD_PLN + * is open-drain. */ -GPIO(M2_SSD_PLN, PIN(A, 0), GPIO_OUT_HIGH) /* SSD power-loss notification */ +GPIO(M2_SSD_PLN, PIN(A, 0), GPIO_ODR_HIGH) /* SSD power-loss notification */ GPIO(M2_SSD_PLA, PIN(7, 0), GPIO_INPUT) /* SSD power-loss acknoledgement */ /* -- cgit v1.2.1