From ea450db6e1cfa56a34b03141640a9bb44dcc40e7 Mon Sep 17 00:00:00 2001 From: Dino Li Date: Thu, 8 Apr 2021 16:10:14 +0800 Subject: it83xx: disable pre-defined command at default With this change, no master is able to see the slave device of pre-defined command on port 0. BUG=b:184804044 BRANCH=none TEST=run i2cscan command on icarus, verified that the slave address isn't present on port 0. Signed-off-by: Dino Li Change-Id: I6df72132d08a3be6ff97fb501eefc4a9fa8d6f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2813878 Reviewed-by: Eric Yilun Lin --- chip/it83xx/registers.h | 1 + chip/it83xx/system.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/chip/it83xx/registers.h b/chip/it83xx/registers.h index 95e8ed548f..24d8b38809 100644 --- a/chip/it83xx/registers.h +++ b/chip/it83xx/registers.h @@ -1422,6 +1422,7 @@ REG8(IT83XX_PMC_BASE + (ch > LPC_PM2 ? 5 : 8) + (ch << 4)) #define IT83XX_SMB_RESLADR2 REG8(IT83XX_SMB_BASE+0x51) #define IT83XX_SMB_ENADDR2 (1 << 7) #define IT83XX_SMB_SFFCTL REG8(IT83XX_SMB_BASE+0x55) +#define IT83XX_SMB_HSAPE BIT(1) #define IT83XX_SMB_SAFE (1 << 0) #define IT83XX_SMB_SFFSTA REG8(IT83XX_SMB_BASE+0x56) #define IT83XX_SMB_SFFFULL (1 << 6) diff --git a/chip/it83xx/system.c b/chip/it83xx/system.c index 2f6fbd504b..7281977e44 100644 --- a/chip/it83xx/system.c +++ b/chip/it83xx/system.c @@ -210,6 +210,9 @@ int system_is_reboot_warm(void) void chip_pre_init(void) { + /* bit1=0: disable pre-defined command */ + IT83XX_SMB_SFFCTL &= ~IT83XX_SMB_HSAPE; + /* bit0, EC received the special waveform from iteflash */ if (IT83XX_GCTRL_DBGROS & IT83XX_SMB_DBGR) { /* -- cgit v1.2.1