From ea4e0494b26976cd178cf252b6044d1c3822f620 Mon Sep 17 00:00:00 2001 From: Ting Shen Date: Fri, 17 Feb 2023 15:14:47 +0800 Subject: geralt: enable LED The board has only one LED with green and blue channel. Update DTS to reflect the hw implementation. BUG=b:269706760 TEST=`ectool led color (GREEN|BLUE)=1' BRANCH=none Change-Id: Ia5ee4fea2c60b055047a3572fe6662e1b3c4cfa5 Signed-off-by: Ting Shen Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4263850 Commit-Queue: Ting Shen Reviewed-by: Eric Yilun Lin Tested-by: Ting Shen --- zephyr/program/geralt/geralt/led.dtsi | 115 ++++++++-------------------------- 1 file changed, 27 insertions(+), 88 deletions(-) diff --git a/zephyr/program/geralt/geralt/led.dtsi b/zephyr/program/geralt/geralt/led.dtsi index b2c75f0c63..905d5f13dd 100644 --- a/zephyr/program/geralt/geralt/led.dtsi +++ b/zephyr/program/geralt/geralt/led.dtsi @@ -8,60 +8,6 @@ led-colors { compatible = "cros-ec,led-policy"; - bat-power-state-charge { - charge-state = "PWR_STATE_CHARGE"; - - color-0 { - led-color = <&color_battery_amber>; - }; - }; - - bat-power-state-near-full { - charge-state = "PWR_STATE_CHARGE_NEAR_FULL"; - - color-0 { - led-color = <&color_battery_white>; - }; - }; - - bat-power-state-discharge { - charge-state = "PWR_STATE_DISCHARGE"; - - color-0 { - led-color = <&color_battery_off>; - }; - }; - - bat-power-state-discharge-s0-bat-low { - charge-state = "PWR_STATE_DISCHARGE"; - chipset-state = "POWER_S0"; - batt-lvl = ; - - color-0 { - led-color = <&color_battery_amber>; - period-ms = <1000>; - }; - - color-1 { - led-color = <&color_battery_off>; - period-ms = <3000>; - }; - }; - - bat-power-state-error { - charge-state = "PWR_STATE_ERROR"; - - color-0 { - led-color = <&color_battery_amber>; - period-ms = <1000>; - }; - - color-1 { - led-color = <&color_battery_off>; - period-ms = <1000>; - }; - }; - pwr-power-state-off { color-0 { led-color = <&color_power_off>; @@ -72,7 +18,7 @@ chipset-state = "POWER_S0"; color-0 { - led-color = <&color_power_white>; + led-color = <&color_power_green>; }; }; @@ -80,7 +26,7 @@ chipset-state = "POWER_S3"; color-0 { - led-color = <&color_power_white>; + led-color = <&color_power_green>; period-ms = <1000>; }; @@ -95,19 +41,21 @@ compatible = "pwm-leds"; /* NOTE: &pwm number needs same with channel number */ - led_power_white: ec_led1_odl { + led_power_red: ec_led1_odl { pwms = <&pwm0 PWM_CHANNEL_0 PWM_HZ(324) PWM_POLARITY_INVERTED>; }; - led_battery_amber: ec_led2_odl { + + led_power_green: ec_led2_odl { pwms = <&pwm1 PWM_CHANNEL_1 PWM_HZ(324) PWM_POLARITY_INVERTED>; }; - led_battery_white: ec_led3_odl { + + led_power_blue: ec_led3_odl { pwms = <&pwm2 PWM_CHANNEL_2 PWM_HZ(324) @@ -121,44 +69,35 @@ color_power_off: color-power-off { led-color = "LED_OFF"; led-id = "EC_LED_ID_POWER_LED"; - led-pwms = <&led_power_white>; - led-values = <0>; + led-pwms = <&led_power_red &led_power_green + &led_power_blue>; + led-values = <0 0 0>; }; - color_power_white: color-power-white { - led-color = "LED_WHITE"; - br-color = "EC_LED_COLOR_WHITE"; + color_power_green: color-power-green { + led-color = "LED_GREEN"; + br-color = "EC_LED_COLOR_GREEN"; led-id = "EC_LED_ID_POWER_LED"; - led-pwms = <&led_power_white>; - led-values = <100>; + led-pwms = <&led_power_red &led_power_green + &led_power_blue>; + led-values = <0 100 0>; }; - color_battery_off: color-battery-off { - led-color = "LED_OFF"; - led-id = "EC_LED_ID_BATTERY_LED"; - led-pwms = <&led_battery_amber &led_battery_white>; - led-values = <0 0>; - }; - - color_battery_amber: color-battery-amber { - led-color = "LED_AMBER"; - br-color = "EC_LED_COLOR_AMBER"; - led-id = "EC_LED_ID_BATTERY_LED"; - led-pwms = <&led_battery_amber &led_battery_white>; - led-values = <100 0>; - }; - - color_battery_white: color-battery-white { - led-color = "LED_WHITE"; - br-color = "EC_LED_COLOR_WHITE"; - led-id = "EC_LED_ID_BATTERY_LED"; - led-pwms = <&led_battery_amber &led_battery_white>; - led-values = <0 100>; + color_power_blue: color-power-blue { + led-color = "LED_BLUE"; + br-color = "EC_LED_COLOR_BLUE"; + led-id = "EC_LED_ID_POWER_LED"; + led-pwms = <&led_power_red &led_power_green + &led_power_blue>; + led-values = <0 0 100>; }; }; }; -/* LED1 */ +/* + * LED1 + * Broken, see b/269706760#comment4 + */ &pwm0 { status = "okay"; prescaler-cx = ; -- cgit v1.2.1