From eb9f26b0f47129791a69d86deac0b17a2caace28 Mon Sep 17 00:00:00 2001 From: Mary Ruthven Date: Mon, 25 Apr 2022 13:36:13 -0500 Subject: ap_ro_integrity_check: delay sleep after deasserting AP FLASH SEL Delay sleep to give AP_FLASH_SELECT enough time to discharge. Future CLs will do more to ensure AP_FLASH_SELECT isn't asserted entering deep sleep. This CL does the bare minimum to fix AP RO verification. BUG=b:229974371 TEST=Trigger AP RO verification on Hoglin Change-Id: Iec10c51dfe8e7df2b1bb2210c4705d90c3c89c54 Signed-off-by: Mary Ruthven Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3606093 Reviewed-by: Andrey Pronin --- common/ap_ro_integrity_check.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/ap_ro_integrity_check.c b/common/ap_ro_integrity_check.c index 59ce15a25b..7724ae2585 100644 --- a/common/ap_ro_integrity_check.c +++ b/common/ap_ro_integrity_check.c @@ -1390,6 +1390,8 @@ static void release_ec_reset_override(void) { hook_call_deferred(&keep_ec_in_reset_data, -1); deassert_ec_rst(); + /* b/229974371 Give AP_FLASH_SELECT at least 500us to discharge */ + delay_sleep_by(1 * SECOND); enable_sleep(SLEEP_MASK_AP_RO_VERIFICATION); } -- cgit v1.2.1