From 97cc9112a6e986cf71848a8c4f973d42f599465f Mon Sep 17 00:00:00 2001 From: CHLin Date: Tue, 7 Apr 2020 22:58:46 -0700 Subject: Makefile: set the value to the compiler flag CHIP_FAMILY in uppercase We want to use the value of CHIP_FAMILY to define chip family code via macros. (See the child CL for details.) In convention, a macro should be defined with uppercase letters. This CL changes the lowercase value of CHIP_FAMILY to the uppercase. BUG=none BRANCH=none TEST=No error for "make buildall" TEST="grep -rw --exclude="build.mk" "CHIP_FAMILY" ./"; Make sure CHIP_FAMILY is not used in the source. So it won't have the side effect. Signed-off-by: CHLin Change-Id: I077d327c609387e87cd1ac128cf8c9974da21c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2142833 Reviewed-by: Daisuke Nojiri Commit-Queue: CH Lin Tested-by: CH Lin --- Makefile.toolchain | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Makefile.toolchain') diff --git a/Makefile.toolchain b/Makefile.toolchain index f7ae354b10..9446db84df 100644 --- a/Makefile.toolchain +++ b/Makefile.toolchain @@ -72,7 +72,7 @@ CFLAGS_COVERAGE=$(if $(TEST_COVERAGE),-fprofile-arcs -ftest-coverage \ -DTEST_COVERAGE=$(EMPTY),) CFLAGS_DEFINE=-DOUTDIR=$(out)/$(BLD) -DCHIP=$(CHIP) -DBOARD_TASKFILE=$(_tsk_lst_file) \ -DBOARD=$(BOARD) -DCORE=$(CORE) -DPROJECT=$(PROJECT) \ - -DCHIP_VARIANT=$(CHIP_VARIANT) -DCHIP_FAMILY=$(CHIP_FAMILY) \ + -DCHIP_VARIANT=$(CHIP_VARIANT) -DCHIP_FAMILY=$(UC_CHIP_FAMILY) \ -DBOARD_$(UC_BOARD)=$(EMPTY) \ -DCHIP_$(UC_CHIP)=$(EMPTY) \ -DCORE_$(UC_CORE)=$(EMPTY) \ -- cgit v1.2.1