From c1edf25f4d3000529994be1ac1af166c69df47a3 Mon Sep 17 00:00:00 2001 From: Ting Shen Date: Wed, 11 Sep 2019 22:45:22 +0000 Subject: kukui: remove virtual battery for devices with smart battery CONFIG_I2C_VIRTUAL_BATTERY/CONFIG_I2C_PASSTHRU_RESTRICTED is for devices with dumb battery to simulate smart battery interface. Remove these flags for devices with smart battery. BUG=b:140847169 TEST=ectool i2cread 8 1 0x16 , where reg = 0x00~0x03 BRANCH=master Change-Id: I6088f66596e626f62320ee4ab181e972016aa80c Signed-off-by: Ting Shen Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1799289 Reviewed-by: Xiong Huang Reviewed-by: Yilun Lin Tested-by: Xiong Huang Commit-Queue: Sean Abraham --- baseboard/kukui/baseboard.c | 2 ++ baseboard/kukui/baseboard.h | 7 +++++-- 2 files changed, 7 insertions(+), 2 deletions(-) (limited to 'baseboard/kukui') diff --git a/baseboard/kukui/baseboard.c b/baseboard/kukui/baseboard.c index 98c0348c9f..2882fe760f 100644 --- a/baseboard/kukui/baseboard.c +++ b/baseboard/kukui/baseboard.c @@ -112,7 +112,9 @@ int board_get_version(void) return version; } +#ifndef VARIANT_KUKUI_BATTERY_SMART int board_allow_i2c_passthru(int port) { return (port == I2C_PORT_VIRTUAL_BATTERY); } +#endif diff --git a/baseboard/kukui/baseboard.h b/baseboard/kukui/baseboard.h index f200c5bc52..d02ca8fc64 100644 --- a/baseboard/kukui/baseboard.h +++ b/baseboard/kukui/baseboard.h @@ -27,6 +27,11 @@ #error Must define a VARIANT_KUKUI_BATTERY #endif /* VARIANT_KUKUI_BATTERY */ +#ifndef VARIANT_KUKUI_BATTERY_SMART +#define CONFIG_I2C_VIRTUAL_BATTERY +#define CONFIG_I2C_PASSTHRU_RESTRICTED +#endif + /* * Variant charger defines, pick one: * VARIANT_KUKUI_CHARGER_MT6370 @@ -70,8 +75,6 @@ #undef CONFIG_HIBERNATE #define CONFIG_I2C #define CONFIG_I2C_MASTER -#define CONFIG_I2C_VIRTUAL_BATTERY -#define CONFIG_I2C_PASSTHRU_RESTRICTED #define CONFIG_LED_COMMON #define CONFIG_LOW_POWER_IDLE #define CONFIG_POWER_COMMON -- cgit v1.2.1