From 44f69459ded7bd93933a660c1f216f1ad0ae443e Mon Sep 17 00:00:00 2001 From: Dino Li Date: Tue, 8 Sep 2020 14:56:10 +0800 Subject: it83xx: enable selecting EC's VCC The VCC is the power source of EC's GPM0~6, will connect to 1.8v or 3.3v depended on platform design. This change was made to ensure voltage level setting of GPM0~6 matches the corresponded VCC level. So we can enable internal pull-up no matter VCC is connected to 1.8v or 3.3v BUG=b:168783892 BRANCH=none TEST=- buildall. - The level setting is correct on these boards: asurada, drawcia, and reef_it8320 Change-Id: I4eae368e569987381a0437494262d588436bb011 Signed-off-by: Dino Li Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2397931 Reviewed-by: Eric Yilun Lin --- baseboard/dedede/baseboard.h | 3 +++ baseboard/dragonegg/baseboard.h | 2 ++ baseboard/intelrvp/ite_ec.h | 1 + baseboard/ite_evb/baseboard.h | 1 + baseboard/octopus/baseboard.h | 2 ++ 5 files changed, 9 insertions(+) (limited to 'baseboard') diff --git a/baseboard/dedede/baseboard.h b/baseboard/dedede/baseboard.h index 42fad27e71..96e46ad319 100644 --- a/baseboard/dedede/baseboard.h +++ b/baseboard/dedede/baseboard.h @@ -32,6 +32,9 @@ #define CONFIG_SPI_FLASH_REGS #define CONFIG_SPI_FLASH_W25Q80 /* Internal SPI flash type. */ #elif defined(VARIANT_DEDEDE_EC_IT8320) + /* IT83XX config */ + #define CONFIG_IT83XX_VCC_1P8V + /* I2C Bus Configuration */ #define I2C_PORT_EEPROM IT83XX_I2C_CH_A #define I2C_PORT_BATTERY IT83XX_I2C_CH_B #define I2C_PORT_SENSOR IT83XX_I2C_CH_C diff --git a/baseboard/dragonegg/baseboard.h b/baseboard/dragonegg/baseboard.h index dccabccbde..5b095ce08f 100644 --- a/baseboard/dragonegg/baseboard.h +++ b/baseboard/dragonegg/baseboard.h @@ -127,6 +127,8 @@ #define PD_MAX_CURRENT_MA 3000 #define PD_MAX_VOLTAGE_MV 20000 +/* IT83XX config */ +#define CONFIG_IT83XX_VCC_1P8V /* I2C Bus Configuration */ #define CONFIG_I2C #define CONFIG_I2C_MASTER diff --git a/baseboard/intelrvp/ite_ec.h b/baseboard/intelrvp/ite_ec.h index 2857f8efdf..4c98354a62 100644 --- a/baseboard/intelrvp/ite_ec.h +++ b/baseboard/intelrvp/ite_ec.h @@ -10,6 +10,7 @@ /* Optional feature - used by ITE */ #define CONFIG_IT83XX_FLASH_CLOCK_48MHZ +#define CONFIG_IT83XX_VCC_1P8V /* ADC channels */ #define ADC_TEMP_SNS_AMBIENT_CHANNEL CHIP_ADC_CH13 diff --git a/baseboard/ite_evb/baseboard.h b/baseboard/ite_evb/baseboard.h index 34c4fee278..6f4f4810a3 100644 --- a/baseboard/ite_evb/baseboard.h +++ b/baseboard/ite_evb/baseboard.h @@ -16,6 +16,7 @@ #define CONFIG_I2C_MASTER #define CONFIG_IT83XX_ENABLE_MOUSE_DEVICE #define CONFIG_IT83XX_SMCLK2_ON_GPC7 +#define CONFIG_IT83XX_VCC_3P3V #define CONFIG_KEYBOARD_BOARD_CONFIG #define CONFIG_KEYBOARD_PROTOCOL_8042 #define CONFIG_LOW_POWER_IDLE diff --git a/baseboard/octopus/baseboard.h b/baseboard/octopus/baseboard.h index c8e4b24e56..c67c963c4f 100644 --- a/baseboard/octopus/baseboard.h +++ b/baseboard/octopus/baseboard.h @@ -58,6 +58,8 @@ /* Allow the EC to enter deep sleep in S0 */ #define CONFIG_LOW_POWER_S0 #elif defined(VARIANT_OCTOPUS_EC_ITE8320) + /* IT83XX config */ + #define CONFIG_IT83XX_VCC_1P8V /* I2C Bus Configuration */ #define I2C_PORT_BATTERY IT83XX_I2C_CH_A /* Shared bus */ #define I2C_PORT_CHARGER IT83XX_I2C_CH_A /* Shared bus */ -- cgit v1.2.1