From dc3e8d69dbffc330a0725eacf00da14f54ac86fc Mon Sep 17 00:00:00 2001 From: Denis Brockus Date: Tue, 30 Jun 2020 12:42:04 -0600 Subject: TCPMv2: make sure Vbus is not sourced in AttachWait.SRC The TCPC on zork appears to enable Vbus sourcing some of the time when we come out of auto-toggle. It looks like about a 60ms delay before it is enabled. We then go to AttachWait.SRC and since the exit condition to get to Attached.SRC is a debounced/valid Attached.SRC CC and Safe0V, it has to be disabled manually in order to move to Attached.SRC BUG=b:160227699,b:160253746 BRANCH=none TEST=dut-control servo_v4_role:snk should attach Signed-off-by: Denis Brockus Change-Id: I1dfc5d2536aaa4d7a5ffc7bbb52c647b15764196 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2276463 Tested-by: Denis Brockus Reviewed-by: Diana Z Reviewed-by: Keith Short Commit-Queue: Denis Brockus Auto-Submit: Denis Brockus --- baseboard/zork/variant_trembyle.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'baseboard') diff --git a/baseboard/zork/variant_trembyle.c b/baseboard/zork/variant_trembyle.c index 948b77632b..4249944760 100644 --- a/baseboard/zork/variant_trembyle.c +++ b/baseboard/zork/variant_trembyle.c @@ -252,7 +252,8 @@ const struct tcpc_config_t tcpc_config[] = { .addr_flags = NCT38XX_I2C_ADDR1_1_FLAGS, }, .drv = &nct38xx_tcpm_drv, - .flags = TCPC_FLAGS_TCPCI_REV2_0, + .flags = TCPC_FLAGS_TCPCI_REV2_0 | + TCPC_FLAGS_TCPCI_BAD_VBUS_SOURCING, }, [USBC_PORT_C1] = { .bus_type = EC_BUS_TYPE_I2C, @@ -261,7 +262,8 @@ const struct tcpc_config_t tcpc_config[] = { .addr_flags = NCT38XX_I2C_ADDR1_1_FLAGS, }, .drv = &nct38xx_tcpm_drv, - .flags = TCPC_FLAGS_TCPCI_REV2_0, + .flags = TCPC_FLAGS_TCPCI_REV2_0 | + TCPC_FLAGS_TCPCI_BAD_VBUS_SOURCING, }, }; BUILD_ASSERT(ARRAY_SIZE(tcpc_config) == USBC_PORT_COUNT); -- cgit v1.2.1