From bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 Mon Sep 17 00:00:00 2001 From: Gwendal Grignou Date: Mon, 11 Mar 2019 15:57:52 -0700 Subject: common: replace 1 << digits, with BIT(digits) Requested for linux integration, use BIT instead of 1 << First step replace bit operation with operand containing only digits. Fix an error in motion_lid try to set bit 31 of a signed integer. BUG=None BRANCH=None TEST=compile Change-Id: Ie843611f2f68e241f0f40d4067f7ade726951d29 Signed-off-by: Gwendal Grignou Reviewed-on: https://chromium-review.googlesource.com/1518659 Reviewed-by: Daisuke Nojiri --- board/atlas/board.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'board/atlas/board.c') diff --git a/board/atlas/board.c b/board/atlas/board.c index 3be1ebfb3d..e0fc4d07e7 100644 --- a/board/atlas/board.c +++ b/board/atlas/board.c @@ -274,7 +274,7 @@ static void board_report_pmic_fault(const char *str) BD99992GW_REG_RESETIRQ1, &vrfault) != EC_SUCCESS) return; - if (!(vrfault & (1 << 4))) + if (!(vrfault & BIT(4))) return; /* VRFAULT has occurred, print VRFAULT status bits. */ @@ -293,7 +293,7 @@ static void board_report_pmic_fault(const char *str) /* Clear all faults -- Write 1 to clear. */ i2c_write8(I2C_PORT_PMIC, I2C_ADDR_BD99992, - BD99992GW_REG_RESETIRQ1, (1 << 4)); + BD99992GW_REG_RESETIRQ1, BIT(4)); i2c_write8(I2C_PORT_PMIC, I2C_ADDR_BD99992, BD99992GW_REG_PWRSTAT1, pwrstat1); i2c_write8(I2C_PORT_PMIC, I2C_ADDR_BD99992, -- cgit v1.2.1