From 2e7ea4efdb56af411f13e0224a945a67dd6f0dcb Mon Sep 17 00:00:00 2001 From: Louis Yung-Chieh Lo Date: Wed, 23 Apr 2014 09:50:42 -0700 Subject: battery: move cut-off commands to common/battery.c So that host and EC commands will be defined in common/battery.c. The board-specific battery.c can focus on the proprietary method. BUG=chrome-os-partner:28248 BRANCH=tot,nyan TEST=make buildall runtest Tested "cutoff" in EC console on big. Change-Id: I213c0d601d0241c8dea309d6ac60c72452d2d100 Signed-off-by: Louis Yung-Chieh Lo Reviewed-on: https://chromium-review.googlesource.com/196621 Reviewed-by: Bill Richardson --- board/big/battery.c | 10 ++++------ board/big/board.h | 1 + 2 files changed, 5 insertions(+), 6 deletions(-) (limited to 'board/big') diff --git a/board/big/battery.c b/board/big/battery.c index 1ac9991bef..b795206bfc 100644 --- a/board/big/battery.c +++ b/board/big/battery.c @@ -20,7 +20,7 @@ #define SB_SHIP_MODE_DATA 0xc574 static struct battery_info *battery_info; -static int battery_cut_off; +static int support_cut_off; struct battery_device { char manuf[9]; @@ -293,7 +293,7 @@ const struct battery_info *battery_get_info(void) (support_batteries[i].design_mv == design_mv)) { CPRINTF("[%T battery Manuf:%s, Device=%s, design=%u]\n", manuf, device, design_mv); - battery_cut_off = support_batteries[i].support_cut_off; + support_cut_off = support_batteries[i].support_cut_off; battery_info = support_batteries[i].battery_info; return battery_info; } @@ -304,12 +304,10 @@ const struct battery_info *battery_get_info(void) return &info_precharge; } -int battery_command_cut_off(struct host_cmd_handler_args *args) +int board_cut_off_battery(void) { - if (battery_cut_off) + if (support_cut_off) return sb_write(SB_SHIP_MODE_ADDR, SB_SHIP_MODE_DATA); else return EC_RES_INVALID_COMMAND; } -DECLARE_HOST_COMMAND(EC_CMD_BATTERY_CUT_OFF, battery_command_cut_off, - EC_VER_MASK(0)); diff --git a/board/big/board.h b/board/big/board.h index dd1373b50c..6c39da3d58 100644 --- a/board/big/board.h +++ b/board/big/board.h @@ -11,6 +11,7 @@ /* Optional features */ #define CONFIG_AP_HANG_DETECT #define CONFIG_BATTERY_SMART +#define CONFIG_BATTERY_CUT_OFF #define CONFIG_CHARGER #define CONFIG_CHARGER_V2 #define CONFIG_CHARGER_BQ24725 -- cgit v1.2.1