From 58ac5f86059f85e24036fd4933a024dadae28f25 Mon Sep 17 00:00:00 2001 From: Jett Rink Date: Fri, 18 Oct 2019 11:57:13 -0600 Subject: octopus: lock gpio config for reset signal BRANCH=octopus BUG=b:142953493 TEST=verify that later modification of gpio flag will no allow driving signal high. Change-Id: I0b8c1503ba8c03afa3eb6fa4f921b3480106f05b Signed-off-by: Jett Rink Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1869407 Commit-Queue: Edward Hill Reviewed-by: Edward Hill --- board/bobba/gpio.inc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'board/bobba') diff --git a/board/bobba/gpio.inc b/board/bobba/gpio.inc index 699efa5cf3..7be85f7c72 100644 --- a/board/bobba/gpio.inc +++ b/board/bobba/gpio.inc @@ -85,8 +85,13 @@ GPIO(EC_BATT_PRES_L, PIN(E, 5), GPIO_INPUT) * being asserted. Also, it should be fine to have the EC in hibernate when H1 * or servo wants to hold the EC in reset since VCC1 will be down and so entire * EC logic (except PSL) as well as AP will be in reset. + * + * We need to lock the setting so this gpio can't be reconfigured to overdrive + * the real reset signal. (This is the PSL input pin not the real reset pin). */ -GPIO(EC_RST_ODL, PIN(0, 2), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH) +GPIO(EC_RST_ODL, PIN(0, 2), GPIO_INT_BOTH | + GPIO_HIB_WAKE_HIGH | + GPIO_LOCKED) /* * PCH_PROCHOT_ODL is primarily for monitoring the PROCHOT# signal which is -- cgit v1.2.1