From a27f1049b6d92d46de9a648ba64f451387a598d4 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Fri, 22 Sep 2017 12:54:28 -0700 Subject: power: Add flags parameter to power_signal_info Replace structure member "level" in power_signal_info with "flags". "level" has been used on all boards to indicate active-high or active-low levels. Addition of "flags" allows easy extension of power_signal_info structure to define various flags that might be applicable to power signals (e.g. "level"). Going forward, additional flag will be added in follow-up CLs. Also, provide a helper function power_signal_is_asserted that checks the actual level of a signal and compares it to the flags level to identify if a power signal is asserted. BUG=b:65421825 BRANCH=None TEST=make -j buildall Change-Id: Iacaabd1185b347c17b5159f05520731505b824b8 Signed-off-by: Furquan Shaikh Reviewed-on: https://chromium-review.googlesource.com/679979 Reviewed-by: Nicolas Boichat --- board/chell/board.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'board/chell') diff --git a/board/chell/board.c b/board/chell/board.c index 1d56ceb237..e02513548a 100644 --- a/board/chell/board.c +++ b/board/chell/board.c @@ -82,13 +82,13 @@ void usb1_evt(enum gpio_signal signal) /* power signal list. Must match order of enum power_signal. */ const struct power_signal_info power_signal_list[] = { #ifdef CONFIG_POWER_S0IX - {GPIO_PCH_SLP_S0_L, 1, "SLP_S0_DEASSERTED"}, + {GPIO_PCH_SLP_S0_L, POWER_SIGNAL_ACTIVE_HIGH, "SLP_S0_DEASSERTED"}, #endif - {GPIO_RSMRST_L_PGOOD, 1, "RSMRST_N_PWRGD"}, - {GPIO_PCH_SLP_S3_L, 1, "SLP_S3_DEASSERTED"}, - {GPIO_PCH_SLP_S4_L, 1, "SLP_S4_DEASSERTED"}, - {GPIO_PCH_SLP_SUS_L, 1, "SLP_SUS_DEASSERTED"}, - {GPIO_PMIC_DPWROK, 1, "PMIC_DPWROK"}, + {GPIO_RSMRST_L_PGOOD, POWER_SIGNAL_ACTIVE_HIGH, "RSMRST_N_PWRGD"}, + {GPIO_PCH_SLP_S3_L, POWER_SIGNAL_ACTIVE_HIGH, "SLP_S3_DEASSERTED"}, + {GPIO_PCH_SLP_S4_L, POWER_SIGNAL_ACTIVE_HIGH, "SLP_S4_DEASSERTED"}, + {GPIO_PCH_SLP_SUS_L, POWER_SIGNAL_ACTIVE_HIGH, "SLP_SUS_DEASSERTED"}, + {GPIO_PMIC_DPWROK, POWER_SIGNAL_ACTIVE_HIGH, "PMIC_DPWROK"}, }; BUILD_ASSERT(ARRAY_SIZE(power_signal_list) == POWER_SIGNAL_COUNT); -- cgit v1.2.1