From b7442b335d6b6a8549eb677058ae8f2782a82792 Mon Sep 17 00:00:00 2001 From: Vadim Bendebury Date: Fri, 10 Aug 2018 10:12:38 -0700 Subject: cr50: bitbang does not need to support multiple UARTs. The ability to support multiple UART interfaces complicates bit bang EC programming implementation without bringing any real benefits - we are not going to have to bit bang more than one UART interface in real Chrome OS hardware. In preparation in introducing bit a bang speed up patch let's change the API to not require passing the UART number to bit bang functions. To keep servod happy for now, the 'bitbang' cli command is being left unchanged and as such still requires to pass the UART number, it is just ignored. BRANCH=cr50, cr50-mp BUG=b:62539385 TEST=just verified that Cr50 still builds, the real test is done in the speed up patch. Change-Id: Icd5476ad777791ca483844cbf49316ddf58f03a3 Signed-off-by: Vadim Bendebury Reviewed-on: https://chromium-review.googlesource.com/1171220 Reviewed-by: Mary Ruthven --- board/cr50/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'board/cr50/board.c') diff --git a/board/cr50/board.c b/board/cr50/board.c index e92dd1f62c..67ed39ab38 100644 --- a/board/cr50/board.c +++ b/board/cr50/board.c @@ -106,7 +106,7 @@ struct uart_bitbang_properties bitbang_config = { void ec_tx_cr50_rx(enum gpio_signal signal) { - uart_bitbang_receive_char(UART_EC); + uart_bitbang_receive_char(); /* * Let the USART module know that there's new bits to consume. * -- cgit v1.2.1