From 03a3f864796d02196de8419b3c12c78f425b946c Mon Sep 17 00:00:00 2001 From: Mary Ruthven Date: Tue, 6 Sep 2016 17:11:33 +0000 Subject: Revert "cr50: remove internal pull up on DIOM0" This reverts commit 5e6da91fe86301d276b452a660139c27c3786a82. Change-Id: I65b37c087a86fab06f6e23e895ceee2ae2def5ee Reviewed-on: https://chromium-review.googlesource.com/381160 Reviewed-by: Mary Ruthven Commit-Queue: Mary Ruthven Commit-Queue: Vadim Bendebury Tested-by: Vadim Bendebury --- board/cr50/gpio.inc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'board/cr50/gpio.inc') diff --git a/board/cr50/gpio.inc b/board/cr50/gpio.inc index 454fe729bc..e68124d561 100644 --- a/board/cr50/gpio.inc +++ b/board/cr50/gpio.inc @@ -11,8 +11,11 @@ * We can assert SYS_RST_L but so can the EC, so we need react if it's pulled * low. The ARM core can't trigger an interrupt if it's driving it as an output * so we attach two internal GPIOs to the same pad. + * TODO: Remove this internal pullup at some point. It's only here so that + * boards that don't have an external pullup don't trigger due to noise. */ -GPIO_INT(SYS_RST_L_IN, PIN(1, 0), GPIO_INT_FALLING, sys_rst_asserted) +GPIO_INT(SYS_RST_L_IN, PIN(1, 0), GPIO_INT_FALLING | GPIO_PULL_UP, + sys_rst_asserted) GPIO_INT(AP_ON, PIN(1, 1), GPIO_INT_RISING, device_state_on) GPIO_INT(EC_ON, PIN(1, 2), GPIO_INT_RISING, device_state_on) GPIO_INT(SERVO_UART1_ON, PIN(1, 3), GPIO_INT_RISING | GPIO_PULL_DOWN, -- cgit v1.2.1