From 45de6930052039b25a980b5eacaf6309cba946b1 Mon Sep 17 00:00:00 2001 From: Peter Marheine Date: Wed, 30 Dec 2020 16:54:19 +1100 Subject: zork: use MKBP GPIO & host event for wake on DP GPIO-only MKBP only works when the AP is awake; we need to use GPIO_AND_HOST_EVENT in order to support waking the AP in response to MKBP events; in particular DP_ALT_MODE_ENTERED. We also configure the MKBP wakeup mask so powerd can apply configuration at runtime per chromeos-config: if no mask is configured then the hostcmd to set the wakeup mask is not included in the firmware. Wake on MKBP (and thus wake on DP) also requires AP firmware support. https://review.coreboot.org/c/coreboot/+/48844 implements it for Zork. BUG=b:174121852 TEST=Generating DP event via EC console on morphius with patched AP firmware successfully wakes system from S3. BRANCH=zork Signed-off-by: Peter Marheine Change-Id: Ifb193399259674da17694aac5213bfd1f189ee59 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2607026 Reviewed-by: Edward Hill --- board/dalboz/board.h | 1 - 1 file changed, 1 deletion(-) (limited to 'board/dalboz') diff --git a/board/dalboz/board.h b/board/dalboz/board.h index 9fa8ac6094..845048225d 100644 --- a/board/dalboz/board.h +++ b/board/dalboz/board.h @@ -14,7 +14,6 @@ #include "baseboard.h" #define CONFIG_IO_EXPANDER_PCAL6408 -#define CONFIG_MKBP_USE_GPIO #define CONFIG_USBC_PPC_NX20P3483 #define CONFIG_USB_MUX_PS8740 -- cgit v1.2.1