From 5a9a8f3dbf93cb651bef6ffbd420a24ca5ee01aa Mon Sep 17 00:00:00 2001 From: Bill Richardson Date: Thu, 25 Feb 2016 10:48:10 -0800 Subject: cleanup: Add warning comment to gpio.inc files With commit e9883124ff16, a GPIO_INT macro was added. That change also required that all instances of GPIO_INT in a board's gpio.inc file come before any GPIO macros, or the interrupt handler wouldn't work properly. This CL just adds a warning comment about requirement to all gpio.inc files. BUG=chromium:471331 BRANCH=none TEST=make buildall, test image on Cr50 This is a change to comments only. There is no new behavior to verify, although I did run try out one new image just to be sure nothing stupid happened. Change-Id: I83f7819929a53bce3a8bae04d15b3ee3bda11738 Signed-off-by: Bill Richardson Reviewed-on: https://chromium-review.googlesource.com/329334 Reviewed-by: Vadim Bendebury --- board/discovery/gpio.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'board/discovery') diff --git a/board/discovery/gpio.inc b/board/discovery/gpio.inc index 619b4396a0..92e835be54 100644 --- a/board/discovery/gpio.inc +++ b/board/discovery/gpio.inc @@ -5,7 +5,9 @@ * found in the LICENSE file. */ -/* Inputs with interrupt handlers are first for efficiency */ +/* Declare symbolic names for all the GPIOs that we care about. + * Note: Those with interrupt handlers must be declared first. */ + GPIO_INT(USER_BUTTON, PIN(A, 0), GPIO_INT_BOTH, button_event) /* Outputs */ -- cgit v1.2.1