From b3a033d2dfdc4bfe2b2e82207fea969cf3caee33 Mon Sep 17 00:00:00 2001 From: Aseda Aboagye Date: Wed, 16 Sep 2020 00:20:50 -0700 Subject: drawcia: Update OCPC PID constants Since changing the approach of charging via the sub board on systems that use the SM5803, we need to update the PID constants to work with this new approach. This commit updates the constants for drawcia. BUG=b:168253008 BRANCH=None TEST=Build and flash drawcia and verify charging is working as expected. Change-Id: I8073aa240f90a0ba1ba3d2adabdc0e9fd12dfc6d Signed-off-by: Aseda Aboagye Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2415512 Tested-by: Aseda Aboagye Commit-Queue: Aseda Aboagye Reviewed-by: Diana Z --- board/drawcia/board.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'board/drawcia') diff --git a/board/drawcia/board.c b/board/drawcia/board.c index 9abd33f4f9..fe9bb0e940 100644 --- a/board/drawcia/board.c +++ b/board/drawcia/board.c @@ -644,12 +644,12 @@ __override void ocpc_get_pid_constants(int *kp, int *kp_div, int *ki, int *ki_div, int *kd, int *kd_div) { - *kp = 1; - *kp_div = 6; + *kp = 3; + *kp_div = 14; - *ki = 0; - *ki_div = 1; + *ki = 3; + *ki_div = 500; - *kd = 0; - *kd_div = 1; + *kd = 4; + *kd_div = 40; } -- cgit v1.2.1