From a38f7585f1bad5bdff3a344daf67815d75f68614 Mon Sep 17 00:00:00 2001 From: Yilun Lin Date: Sat, 8 Sep 2018 00:31:36 +0800 Subject: type: Rename matrix_3x3_t to mat33_fp_t Naming of many vector types and matrix types are not clear enough. For example, we have: vector_3_t, which is a vector of three int. vec3_t, which is a vector of three float. size4_t, which is a vector of four size_t. mat33_t, which is a 3x3 matrix of float. matrix_3x3_t, which is a 3x3 matrix of fixed point. Besides, we have types like int8_t, uint16_t types. To clearly distinguished types, the CL propose to, For vector types, naming should be `$type + 'v' + $num + '_t'`: vector_3_t becomes intv3_t vec3_t becomes floatv3_t vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet) For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the matrix size: matrix_3x3_t becomes mat33_fp_t # fp: fixed point mat33_t becomes mat33_float_t TEST=make buildall -j BUG=b:114662791 Change-Id: I51d88d44252184e4b7b3564236833b0b892edc39 Signed-off-by: Yilun Lin Reviewed-on: https://chromium-review.googlesource.com/1215449 Commit-Ready: Yilun Lin Tested-by: Yilun Lin Reviewed-by: Nicolas Boichat Reviewed-on: https://chromium-review.googlesource.com/1230991 Reviewed-by: Martin Roth Commit-Queue: Martin Roth Tested-by: Martin Roth --- board/elm/board.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'board/elm') diff --git a/board/elm/board.c b/board/elm/board.c index 7ebf20225b..67a60d1aed 100644 --- a/board/elm/board.c +++ b/board/elm/board.c @@ -438,13 +438,13 @@ DECLARE_HOOK(HOOK_CHIPSET_SUSPEND, board_chipset_suspend, HOOK_PRIO_DEFAULT); static struct mutex g_kx022_mutex[2]; /* Matrix to rotate accelerometer into standard reference frame */ -const matrix_3x3_t base_standard_ref = { +const mat33_fp_t base_standard_ref = { { FLOAT_TO_FP(-1), 0, 0}, { 0, FLOAT_TO_FP(1), 0}, { 0, 0, FLOAT_TO_FP(-1)} }; -const matrix_3x3_t lid_standard_ref = { +const mat33_fp_t lid_standard_ref = { { FLOAT_TO_FP(1), 0, 0}, { 0, FLOAT_TO_FP(-1), 0}, { 0, 0, FLOAT_TO_FP(-1)} -- cgit v1.2.1