From 9ea3cbecb8d3fca58baf4aff8d7e97480fe25860 Mon Sep 17 00:00:00 2001 From: Jett Rink Date: Mon, 5 Mar 2018 10:46:06 -0700 Subject: npcx: Conforming CONFIG_UART_HOST define to match intention The CONFIG_UART_HOST is supposed to be defined to the index of the UART we want to use. It is not supposed to be defined as a boolean. Updated npcx and all incorrect uses. BRANCH=none BUG=none TEST=Added the following diff to ensure that everything still built: diff --git a/chip/npcx/lpc.c b/chip/npcx/lpc.c index 446baa842..826233744 100644 --- a/chip/npcx/lpc.c +++ b/chip/npcx/lpc.c @@ -897,6 +897,9 @@ static void lpc_init(void) /* Initialize Hardware for UART Host */ #ifdef CONFIG_UART_HOST +#if !CONFIG_UART_HOST +#error "Fix me" +#endif /* Init COMx LPC UART */ /* FMCLK have to using 50MHz */ NPCX_DEVALT(0xB) = 0xFF; Change-Id: Ia46c7cb86c6040a5c75dddf23d5ccd8e33210581 Signed-off-by: Jett Rink Reviewed-on: https://chromium-review.googlesource.com/949308 Reviewed-by: Randall Spangler --- board/eve/board.h | 1 - 1 file changed, 1 deletion(-) (limited to 'board/eve') diff --git a/board/eve/board.h b/board/eve/board.h index e843f3a952..bb72e4c3b4 100644 --- a/board/eve/board.h +++ b/board/eve/board.h @@ -44,7 +44,6 @@ #define CONFIG_PWM_KBLIGHT #define CONFIG_SPI_FLASH_REGS #define CONFIG_SPI_FLASH_W25X40 -#define CONFIG_UART_HOST 0 #define CONFIG_VBOOT_HASH #define CONFIG_VOLUME_BUTTONS #define CONFIG_VSTORE -- cgit v1.2.1