From d41766df11888d07a630dc97de9ce8ce1f6a8f9a Mon Sep 17 00:00:00 2001 From: Divya Sasidharan Date: Thu, 14 Dec 2017 12:14:43 -0800 Subject: glkrvp: Fix hibernate to allow wakeup from hibernation Issue was found when EC would not wake up from hibernate after specified time period. The infinite while loop blocks further hibernate functions that needs to be executed after the board specific hibernate method. Remove this while loop to complete hibernation logic. Also in hibernate function we should not be cutting down power to EC (SMC_SHUTDOWN) as this will limit supporting wake sources feature. Removing it in this patch. BRANCH=master BUG=b:70690772 TEST=On glkrvp EC console, check if "hibernate 30" wakes up EC after 30 sec, with only battery, only AC, with AC+battery. Change-Id: Iae735cc26eeef8e205771d2f3c6e5260918e093e Signed-off-by: Divya Sasidharan --- board/glkrvp/board.c | 6 ------ 1 file changed, 6 deletions(-) (limited to 'board/glkrvp') diff --git a/board/glkrvp/board.c b/board/glkrvp/board.c index 1038811f60..a8c9dcfd2f 100644 --- a/board/glkrvp/board.c +++ b/board/glkrvp/board.c @@ -153,12 +153,6 @@ void board_hibernate(void) /* Added delay to allow AP to settle down */ msleep(100); - - gpio_set_level(GPIO_SMC_SHUTDOWN, 1); - - /* Power to EC should shut down now */ - while (1) - ; } int board_get_version(void) -- cgit v1.2.1